Re: [Perl-workflow-devel] Action Input Field Types and Other Enhancements

[Alejandro I. <ai...@p2...>]

I checked out the complete svn tree and tried the trunk, just to make
sure it was consistent.

I'm trying to figure out the best way to propose easy extensions to
Action attributes and I still can't get past

Workflow::Action::init

Are the accessors broken on purpose? I mean are the accessors broken
legacy code or what?

Also, is there any actual interest on completing action field types?

Thanks,
Alejandro Imass



On Tue, Sep 15, 2009 at 11:32 AM, Alejandro Imass <ai...@p2...> wrote:
> Hi all,
>
> Thanks Jonas for pointing out the mailing list, and thanks to all for
> such wonderful work, started out by Chris Winters and continued with
> the current maintainer(s).
>
> I have been fiddling with Workflow.pm for a while now for the p2ee
> project, and now have the need to complete and figure out some stuff
> to discuss here.
>
> First, I would like to know the status of "Action Field Types" and if
> no one is working on this, would like to volunteer to do some work on
> it.
>
> Second, and it's kind-a in-line with the above, there should be an
> easy way to extend the attributes of any of the elements, starting
> with Actions. For example, it should be easy to add new parameters to
> the XML action tag both at the Workflow and the Action levels, and the
> should be automatically added to the object and accessors added to
> fiddle with them.
>
> When starting to figure this out I noticed that
> Workflow::Action::init() is not really doing anything but clobbering
> $self->param, because the $params received is not what is expected for
> things like $copy_params{class} to work. It seems that $params is
> getting the _workflow object_ instead of a filtered Action of it's
> type, So the accesors $self->name, class and such never have the
> actual values. Here is the code I am referring to. If you dump $params
> here you will see what I mean. Everything still works because the
> public functions don't seem to use the acessors but rather scan the
> wf_state in many cases.
>
> ########################################
> # PRIVATE
>
> sub init {
>   my ( $self, $wf, $params ) = @_;
>
>   # So we don't destroy the original...
>   my %copy_params = %{$params};
>
>   $self->class( $copy_params{class} );
>   $self->name( $copy_params{name} );
>   $self->description( $copy_params{description} );
>
>
> Thanks beforehand, and sorry for the long first post.
>
> Alejandro Imass
>