[Perl-workflow-devel] Next public release? or another beta/dev release

[Jonas B. N. <jo...@gm...>]

Hello,

I started to do some minor refactorings based on Perl::Critic feedback  
and I got some more tests implemented.

So this is the current state of the Changes file:

- Removed VERSION file, this has now been obsoleted

- Addressing RT #40750
   http://rt.cpan.org/Ticket/Display.html?id=40750

   We are now resolving the version number for the distribution from  
Workflow.pm
   the main module, this mean a jump from 0.32 to 1.32, but it does  
mean that
   an installation can be traced back to a given distribution

- Added new test file t/workflow_history.t, the new tests of  
Workflow::History
   methods. Added explicit returns so we return a true value when run

- All packages have been run through perltidy addressing the following
   Perl::Critic policies:

   [CodeLayout::ProhibitHardTabs]
   [CodeLayout::ProhibitTrailingWhitespace]
   [CodeLayout::RequireTidyCode]

- Perl::Critic policy [Subroutines::ProhibitExplicitReturnUndef]  
disabled
   this would break APIs at does not seem like a good idea, a more  
thorough
   analysis should however be completed at some point

- Perl::Critic policy [NamingConventions::ProhibitAmbiguousNames]  
disabled
   we have an overwrite of Class::Accessor, which happens to violate  
this policy

- Added use of File::Slurp refactoring a potential problematic body of  
code
   addressing Perl::Critic policy [InputOutput::ProhibitJoinedReadline]
   File::Slurp added to Build.PL

- Some hardcoded numbers have been made into constants, some of these  
are
   candidates however for propagation to a central place. (See TODO  
file)
   This addresses Perl::Critic policy
   [ValuesAndExpressions::ProhibitMagicNumbers] We do however run with  
this
   policy disabled since, it warns about some numbers, which it does  
not make
   sense to refactor into constants. In addition
   [ValuesAndExpressions::ProhibitConstantPragma] is deactivated since  
we
   are using constants

- Added use of warnings pragma, addressing Perl::Critic policy
   [TestingAndDebugging::RequireUseWarnings], I am however not sure  
whether this
   breaks backwards compatibility towards older perls. So this will  
have to be
   investigated (added to TODO file)

- Exchanged calls to die and warn to croak and carp addressing  
Perl::Critic
   policy [ErrorHandling::RequireCarping], this is also considered a  
good module
   practive so errors are perceived from the callers perspective. In  
addition
   Carp was listed in relevant packages and Build.PL

- Added Id keyword to Workflow::Validator::MatchesDateFormat addressing
   Perl::Critic policy [Miscellanea::RequireRcsKeywords]

- Added t/critic.t and t/perlcriticrc getting started on improving code
   quality based on Perl::Critic, the number of contributors are  
increasing and
   Perl::Critic might prove a good tool in assisting in quality  
assurance for
   Workflow in the future

So my question is whether I should push on and release 1.32 or whether  
we should have one more beta/dev release before this, meaning 0.32_8

I got the test coverage up to: 76.8% from 75.3% as mentioned in my  
last mail.

Let me know what you think,

I think a beta more would be appropriate and then I could spend some  
of my time looking into the POD.

If anybody wants to help out with the Perl::Critic addressing, please  
let me know and I will describe the process in detail, it is a bit  
like sudoku, just more rewarding...

jonasbn