Re: [Perl-workflow-devel] Workflow patch

[Jonas B. N. <jo...@gm...>]

Hi Phil and others,

I have pondered over this for a few days and I feel as you do that  
block sounds like stop and in workflow context this might be  
misinterpreted.

As for: type, this word could mean something else, since we are  
programmers and we are building a framework.

Section is good, but I might prefer to use that for a workflow step or  
a section of a workflow.

Which leads me to group.

Any other suggestions, we are talking about actions and logical  
grouping (okay that was cheap), of these - what is the best word to  
use for this.

I vote for group :)


jonasbn

On 12/12/2008, at 13.47, phil robinson wrote:

> Yes, 'block' suggests that it might be something
> to do with 'stop'.
>
> I'd suggest 'section' (if I understand its function
> correctly), but your 'type' or 'group' would also,
> imho, be better than 'block'.
>
> Cheers, Phil.
>
> +++++++++++++++++++++++++++++++++++++
> phi...@un...
> Tel: +44 (0)161 257 3532
> +++++++++++++++++++++++++++++++++++++
>
>
>
> Jonas Brømsø Nielsen wrote:
>> Hola,
>>
>> I have had a look at Ivan's description of the functionality and it
>> seems very useful, not to say powerful.
>>
>> So based on this I will move on with evaluating the actual patches.
>>
>> I only have one issue at this point and that is the word/attribute
>> 'block', I would prefer another name for this.
>>
>> What about: type or group
>>
>> Let me know what you think.
>>
>>
>> jonasbn
>>
>>
>> On 09/12/2008, at 11.06, Jonas Brømsø Nielsen wrote:
>>
>>
>>> Hello All,
>>>
>>> Robert have now been added to our little group of developer - YAY!.
>>>
>>> Which mean that his patch will be added to the branch dedicated for
>>> this. A development release will be made as soon as he gives me a
>>> heads up.
>>>
>>> We have received some additional patches from Ivan Paponov (see
>>> below), who has also joined this list.
>>>
>>> If anybody has the time to evaluate the patches, please feel free.
>>> We can discuss them openly here and I am sure Ivan will be happy to
>>> answer any questions. If a preliminary review of the patches goes
>>> through, I will create a branch for inclusion and test of the  
>>> patches.
>>>
>>> My $work TODO list is getting shorter, so I think I will be able to
>>> dedicate a lot of time over Christmas for Workflow.
>>>
>>>
>>> jonasbn
>>>
>>> Begin forwarded message:
>>>
>>>
>>>> From: Ivan Paponov <iva...@gm...>
>>>> Date: 8. dec 2008 21.59.04 GMT+01:00
>>>> To: jo...@cp...
>>>> Subject: Workflow patch
>>>> Reply-To: Ivan Paponov <iva...@gm...>
>>>>
>>>> Hi Jonas,
>>>>
>>>> My name is Ivan. I'm developing request management system, and the
>>>> base of it is Workflow framework. This module is really flexible  
>>>> and
>>>> powerful, it's really a pleasure to work with it.
>>>>
>>>> But I found one detail that I'm missing in Workflow.
>>>> Here is the situation.
>>>> We created request, and placed it into Submitted state.
>>>> In submitted state we have following actions: terminate, place on
>>>> hold
>>>> and approve.
>>>>
>>>> <action name="terminate"   class="MyApp::Action::Terminate" />
>>>> <action name="place on hold"   class="MyApp::Action::OnHold" />
>>>> <action name="approve request"   class="MyApp::Action::Approve" />
>>>>
>>>> First two should be available on page as simple links, and third is
>>>> approval form, with comment box and approve button. And it's clear
>>>> that
>>>> first two action links have to be placed at the one part of page  
>>>> (in
>>>> header near request title), and approval form at the other.
>>>> Also I want to use $wf->get_current_actions(); function, but how
>>>> should I distinguish where I should place current action, so I
>>>> decided
>>>> to add additional property to the action tag. It's - block.
>>>>
>>>> <action name="terminate"   block="state change"   class="..." />
>>>> <action name="place on hold"   block="state change"    
>>>> class="..." />
>>>> <action name="approve request"   block="approval"   class="..." />
>>>>
>>>> And modified get_current_actions(), so now I can call
>>>> my @actions = $wf->get_current_actions("approval");
>>>> or
>>>> my @actions = $wf->get_current_actions("state change");
>>>> And I get only actions that are members of specified block.
>>>>
>>>> Patches are in the attachments, in case if you'll find this idea
>>>> interesting.
>>>>
>>>> Thank you.
>>>>
>>>> -- Best regards,
>>>> Ivan Paponov
>>>> iva...@gm...
>>>>
>>> <State.pm.diff><Workflow.pm.diff>
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas,  
>> Nevada.
>> The future of the web can't happen without you.  Join us at MIX09  
>> to help
>> pave the way to the Next Web now. Learn more and register at
>> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
>> _______________________________________________
>> Perl-workflow-devel mailing list
>> Per...@li...
>> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel
>>
>
>
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas,  
> Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to  
> help
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> Perl-workflow-devel mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perl-workflow-devel