perl-win32-gui-users

[perl-win32-gui-users] putting my code into a package breaks UI?

[Jack C. <ja...@mo...>]

Hi,

I have a fairly large (>5K loc) Perl program that has a Windows UI.
I've been applying Perl::Critic recommendations to it, but packaging
the code breaks the UI (the buttons quit working and the scrollbar
disappears). Here's a sample:

sub DBWindow_Show {
...
    # build window
    $DBWindow = Win32::GUI::Window->new(
        -name     => 'DBWindow',
        -text     => 'ldms_core database setup',
        -class    => $ldms_core_class,
        -dialogui => 1,
    );
...
    # Begin button row
    $btn_DBWindowDefault = $DBWindow->AddButton(
        -name    => 'DBWindowDefault',
        -text    => 'Ok',
        -tabstop => 1,
        -default => 1,                   # Give button darker border
        -ok      => 1,                   # press 'Return' to click this button
        -pos => [ 25, $nexthoriz += 25 ],
        -size => [ 60, 20 ],
    );
...
    $DBWindowsb = $DBWindow->AddStatusBar();
...
    # Resize, position and display
    $DBWindow->Resize( $w, $h );
    $DBWindow->Move( $wx, $wy );

    $DBWindow->Show();
    return 0;
}
...
# What to do when the button is clicked #######################################
sub DBWindowDefault_Click {
...
return 0;
}

I'm just adding "package ldms_core;" at the top and "1;__END__" at the
bottom. Any ideas?

thanks,
-- 
"I spent all me tin with the ladies drinking gin,
So across the Western ocean I must wander" -- traditional

Re: [perl-win32-gui-users] putting my code into a package breaks UI?

[Jeremy W. <jez...@ho...>]

>     # Begin button row
>     $btn_DBWindowDefault = $DBWindow->AddButton(
>         -name    => 'DBWindowDefault',
>         -text    => 'Ok',
>         -tabstop => 1,
>         -default => 1,                   # Give button darker border
>         -ok      => 1,                   # press 'Return' to click this button
>         -pos => [ 25, $nexthoriz += 25 ],
>         -size => [ 60, 20 ],
>     );
> ...
>     $DBWindowsb = $DBWindow->AddStatusBar();
> ...
>     # Resize, position and display
>     $DBWindow->Resize( $w, $h );
>     $DBWindow->Move( $wx, $wy );
> 
>     $DBWindow->Show();
>     return 0;
> }
> ...
> # What to do when the button is clicked #######################################
> sub DBWindowDefault_Click {
> ...
> return 0;
> }
> 
> I'm just adding "package ldms_core;" at the top and "1;__END__" at the
> bottom. Any ideas?

Hi,

You are using the OEM (Old Event Model) where Win32::GUI assumes the event handlers are in the "main" name space. When you add a package to surround your code the sub DBWindowDefault_Click is actually ldms_core::DBWindowDefault_Click and therefore nothing is called when the event is fired (as Win32::GUI calls ::DBWindowDefault_Click) . If you want to use packages to encapsulate (which is the way to go IMHO) then you really need to use the NEM (New Event Model) where you specify a sub reference to the event handle on the creation of the object (or add it later). Alternatively, add "::" to the events which force them to be in the main name space.

Cheers,

Jeremy.

_________________________________________________________________
Imagine a life without walls.  See the possibilities
http://clk.atdmt.com/UKM/go/122465943/direct/01/