Re: [perl-win32-gui-users] Code Review?

[Johan L. <jo...@ba...>]

Morbus wrote:
>  - do you see any Window related handles that I've missed?
>    I'd much rather define every single possible event than miss
>    some and hope that the code figures it out. Does my code
>    always bring the Window to the top (in practice, sometimes
>    it does, sometimes it doesn't)?

Just looking at the code, I would make sure the event handlers always 
return exactly what I think they should:

>sub _Window_Minimize  { &note("Minimizing window."); $window->Hide(); }

Return 1 explicitly to avoid surprises.


/J

------ ---- --- -- -- -- -  -   -    -        -
Johan Lindström                    Boss Casinos
Sourcerer                     jo...@ba...
                  http://www.bahnhof.se/~johanl/
If the only tool you have is a hammer,
everything tends to look
like a nail