RE: [perl-win32-gui-hackers] Commit

[Jeremy W. <jez...@ho...>]

>I've just committed my Christmas set of changes.  There's quite a bit here:

Nice changes:)

Just tested under ming, and I had the following errors:

NotifyIcon.xs: In function `void 
XS_Win32__GUI__NotifyIcon__Add(PerlInterpreter*
, CV*)':
NotifyIcon.xs:27: error: `NOTIFYICONDATA_V1_SIZE' undeclared (first use this 
fun
ction)
NotifyIcon.xs:27: error: (Each undeclared identifier is reported only once 
for e
ach function it appears in.)
NotifyIcon.xs: In function `void 
XS_Win32__GUI__NotifyIcon__Modify(PerlInterpret
er*, CV*)':
NotifyIcon.xs:50: error: `NOTIFYICONDATA_V1_SIZE' undeclared (first use this 
fun
ction)
NotifyIcon.xs: In function `void 
XS_Win32__GUI__NotifyIcon__Delete(PerlInterpret
er*, CV*)':
NotifyIcon.xs:70: error: `NOTIFYICONDATA_V1_SIZE' undeclared (first use this 
fun
ction)
NotifyIcon.xs: In function `void 
XS_Win32__GUI__NotifyIcon__SetFocus(PerlInterpr
eter*, CV*)':
NotifyIcon.xs:88: error: `NOTIFYICONDATA_V1_SIZE' undeclared (first use this 
fun
ction)
NotifyIcon.xs: In function `void 
XS_Win32__GUI__NotifyIcon__SetVersion(PerlInter
preter*, CV*)':
NotifyIcon.xs:106: error: `NOTIFYICONDATA_V1_SIZE' undeclared (first use 
this fu
nction)
NMAKE : fatal error U1077: 'C:\WINDOWS\system32\cmd.exe' : return code '0x1'
Stop.

Looking at:

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/platform/shell/reference/structures/notifyicondata.asp

I changed:

nid.cbSize = NOTIFYICONDATA_V1_SIZE;

to:

nid.cbSize = sizeof(NOTIFYICONDATA);

and it compiled - I'm not sure what the implications would be of this 
change?

The tests all pass, and your example works fine (nice example BTW!).

Cheers,

jez.