perl-ldap-dev

preparing for release

[Graham B. <gb...@po...>]

Does anyone know of any outstanding problems with 0.23 that have
not been fixed in CVS ?

The RELEASE_NOTES so far for 0.24 are


perl-ldap 0.24
============================

* Added support for startTLS
* Better error checking in Net::LDAP methods
* VLV control now works
* Can now use oid or name for the matchingRule in filter extensible matches
* Major overhaul of LDIF.pm
* $schema->name2oid is now context sensetive
* test suite now works with openldap2

Re: preparing for release

[Chris R. <chr...@me...>]

Graham Barr <gb...@po...> wrote:
> Does anyone know of any outstanding problems with 0.23 that have
> not been fixed in CVS ?

Minor addition to LDAP.pod attached.

Cheers,

Chris

Re: preparing for release

[Graham B. <gb...@po...>]

On Fri, Jul 06, 2001 at 01:15:16PM +0100, Chris Ridd wrote:
> Graham Barr <gb...@po...> wrote:
> > Does anyone know of any outstanding problems with 0.23 that have
> > not been fixed in CVS ?
> 
> Minor addition to LDAP.pod attached.

Thanks

Graham.

Re: preparing for release

[Clif H. <cl...@di...>]

> 
> On Fri, Jul 06, 2001 at 01:15:16PM +0100, Chris Ridd wrote:
> > Graham Barr <gb...@po...> wrote:
> > > Does anyone know of any outstanding problems with 0.23 that have
> > > not been fixed in CVS ?
> > 
> > Minor addition to LDAP.pod attached.
> 
> Thanks
> 
> Graham.
> 
> 


Everything I have been working on has been checked in.

Regards,

Clif 

Re: preparing for release

[Christopher A B. <ca...@tc...>]

As Graham Barr once put it so eloquently:

> Does anyone know of any outstanding problems with 0.23 that have
> not been fixed in CVS ?

There's a bug in handling modrdn requests of Net::LDAP::LDIF.  Around
line 327 in version 0.23, there are a few calls to _write_attr using
the results from calling Entry's get_value method. _write_attr needs a 
reference, but get_value by default returns a value.

Two possible fixes: add asref => 1 to the options passed to the
get_value method, or fix _write_attr to not dereference its parameter
if it is not a reference.  (I fixed it myself the first way and could
probably provide the patch in a few days, but I suspect the latter fix 
would be more robust.)

%%  Christopher A. Bongaarts  %%  ca...@tc...       %%
%%  Internet Services         %%  http://umn.edu/~cab  %%
%%  University of Minnesota   %%  +1 (612) 625-1809    %%

Re: preparing for release

[Graham B. <gb...@po...>]

Can you send a patch ?

Graham.

On Fri, Jul 06, 2001 at 09:31:14AM -0500, Christopher A Bongaarts wrote:
> As Graham Barr once put it so eloquently:
> 
> > Does anyone know of any outstanding problems with 0.23 that have
> > not been fixed in CVS ?
> 
> There's a bug in handling modrdn requests of Net::LDAP::LDIF.  Around
> line 327 in version 0.23, there are a few calls to _write_attr using
> the results from calling Entry's get_value method. _write_attr needs a 
> reference, but get_value by default returns a value.
> 
> Two possible fixes: add asref => 1 to the options passed to the
> get_value method, or fix _write_attr to not dereference its parameter
> if it is not a reference.  (I fixed it myself the first way and could
> probably provide the patch in a few days, but I suspect the latter fix 
> would be more robust.)
> 
> %%  Christopher A. Bongaarts  %%  ca...@tc...       %%
> %%  Internet Services         %%  http://umn.edu/~cab  %%
> %%  University of Minnesota   %%  +1 (612) 625-1809    %%
> 

Re: preparing for release

[Clif H. <cl...@di...>]

> 
> Can you send a patch ?
> 
> Graham.
> 
> On Fri, Jul 06, 2001 at 09:31:14AM -0500, Christopher A Bongaarts wrote:
> > As Graham Barr once put it so eloquently:
> > 
> > > Does anyone know of any outstanding problems with 0.23 that have
> > > not been fixed in CVS ?
> > 
> > There's a bug in handling modrdn requests of Net::LDAP::LDIF.  Around
> > line 327 in version 0.23, there are a few calls to _write_attr using
> > the results from calling Entry's get_value method. _write_attr needs a 
> > reference, but get_value by default returns a value.
> > 
> > Two possible fixes: add asref => 1 to the options passed to the
> > get_value method, or fix _write_attr to not dereference its parameter
> > if it is not a reference.  (I fixed it myself the first way and could
> > probably provide the patch in a few days, but I suspect the latter fix 
> > would be more robust.)
> > 
> > %%  Christopher A. Bongaarts  %%  ca...@tc...       %%
> > %%  Internet Services         %%  http://umn.edu/~cab  %%
> > %%  University of Minnesota   %%  +1 (612) 625-1809    %%
> > 
> 
> 

Thought someone are ready sent a patch about the dereference
issue.


Regards,

Clif 

Re: preparing for release

[Christopher A B. <ca...@tc...>]

As Graham Barr once put it so eloquently:

> Can you send a patch ?

Done.

%%  Christopher A. Bongaarts  %%  ca...@tc...       %%
%%  Internet Services         %%  http://umn.edu/~cab  %%
%%  University of Minnesota   %%  +1 (612) 625-1809    %%
----snip----
--- perl-ldap-0.23/lib/Net/LDAP/LDIF.pm	Tue Apr 10 11:18:36 2001
+++ site_perl/5.6.0/Net/LDAP/LDIF.pm	Fri Jun 22 14:15:49 2001
@@ -325,9 +325,9 @@
       next;
     }
     elsif ($type eq 'modrdn') {
-      print _write_attr('newrdn',$entry->get_value('newrdn'),$wrap);
+      print _write_attr('newrdn',$entry->get_value('newrdn', asref => 1),$wrap);
       print 'deleteoldrdn: ',$entry->get_value('deleteoldrdn'),"\n";
-      my $ns = $entry->get_value('newsuperior');
+      my $ns = $entry->get_value('newsuperior', asref => 1);
       print _write_attr('newsuperior',$ns,$wrap) if defined $ns;
       next;
     }

Re: preparing for release

[Graham B. <gb...@po...>]

On Fri, Jul 06, 2001 at 11:01:12AM -0500, Christopher A Bongaarts wrote:
> As Graham Barr once put it so eloquently:
> 
> > Can you send a patch ?
> 
> Done.

Thanks.

Graham.

> 
> %%  Christopher A. Bongaarts  %%  ca...@tc...       %%
> %%  Internet Services         %%  http://umn.edu/~cab  %%
> %%  University of Minnesota   %%  +1 (612) 625-1809    %%
> ----snip----
> --- perl-ldap-0.23/lib/Net/LDAP/LDIF.pm	Tue Apr 10 11:18:36 2001
> +++ site_perl/5.6.0/Net/LDAP/LDIF.pm	Fri Jun 22 14:15:49 2001
> @@ -325,9 +325,9 @@
>        next;
>      }
>      elsif ($type eq 'modrdn') {
> -      print _write_attr('newrdn',$entry->get_value('newrdn'),$wrap);
> +      print _write_attr('newrdn',$entry->get_value('newrdn', asref => 1),$wrap);
>        print 'deleteoldrdn: ',$entry->get_value('deleteoldrdn'),"\n";
> -      my $ns = $entry->get_value('newsuperior');
> +      my $ns = $entry->get_value('newsuperior', asref => 1);
>        print _write_attr('newsuperior',$ns,$wrap) if defined $ns;
>        next;
>      }