Re: another DSML.pm error

[Graham B. <gb...@po...>]

On Thu, Jul 18, 2002 at 09:30:28PM -0500, Clif Harden wrote:
> 
> Nope I am not calling the end_dsml function.
> I did not know about it.

Hm, I mentioned it last time you tried the module, I am sure.

> It is not listed in the pod documentation either.

Patches welcome.

> I would rather not put it in the destroy method, I would 
> rather call it.

Yeah, I came to the same conclusion after having some sleep :)

Really you should be calling start_dsml, but the code does that for you
if you don't do it explicitly.

Graham.

> Your reason for using the end_dsml function
> is a very valid point. 
> 
> Later,
> 
> Clif
> 
> 
> 
> 
> Graham Barr wrote:
> > 
> > On Thu, Jul 18, 2002 at 05:02:10PM -0500, Clif Harden wrote:
> > >
> > > Graham,
> > >
> > > I think something did not merge the changes correctly on
> > > the DSML stuff or you changed somethings that I did not
> > > know about.
> > >
> > > I found another error that I damn well know that you and I
> > > fixed while working out the DSML bugs.
> > >
> > > Example
> > > <dsml:dsml xmlns:dsml='http://www.dsml.org/DSML'>
> > >     .
> > >     .
> > >     .
> > >     .
> > >     .
> > > </dsml:dsml>
> > >   ^^^^
> > > Missing this line.
> > >
> > > To fix add these 2 lines at the end of the write_schema method.
> > >
> > > @data{qw(Name LocalName)} = qw(dsml:dsml dsml);
> > > $handler->end_element(\%data);
> > 
> > No that is not the right fix. There is nothing to say that after
> > writing schema you cannot follow by writing entries to the same
> > file. So you dont want to close the <dsml:dsml> element
> > at that point.
> > 
> > Are you sure you are calling ->end_dsml
> > 
> > Actually, try adding
> > 
> > sub DESTROY { shift->end_dsml }
> > 
> > at about line 605, just before the line
> > package Net::LDAP::DSML::pp;
> > 
> > Graham.
> > 
> > -------------------------------------------------------
> > This sf.net email is sponsored by:ThinkGeek
> > Welcome to geek heaven.
> > http://thinkgeek.com/sf
> 
> -- 
> Regards,
> 
> Clif Harden          ch...@po...