Re: Authorization with Authen::SASL::Perl::External

[Graham B. <gb...@po...>]

On Tue, May 07, 2002 at 11:36:04AM +0200, Norbert Klasen wrote:
> Hi,
> RFC2222 says that in the EXTERNAL mechanism "The client sends an initial 
> response with the authorization identity." The attached patch does this. An 
> authorization identity can be set with the 'authname' callback.

Have you tried this, as it does not look right to me, But Chris could
confirm as he wrote the original. You have changed this from sending
the auth as a response to sending it with the initial request.

The reason it was using user, was for compatability with previous SASL
implementation.

Also, it needs to work the same as the Authen::SASL::Cyrus package
(I have CC'd the author), so if someone can confirm how that works,
we can make it match.

Graham.


> --- /archiv/cvs/perl-ldap/sasl/lib/Authen/SASL/Perl/EXTERNAL.pm	Thu Jan 24 13:04:16 2002
> +++ EXTERNAL.pm	Tue May  7 11:30:49 2002
> @@ -24,12 +24,16 @@
>  sub mechanism { 'EXTERNAL' }
>  
>  sub client_start {
> -  ''
> -}
> +  my $self = shift;
>  
> -sub client_step {
> -  shift->_call('user');
> +  my $v = $self->_call('authname');
> +  defined($v) ? $v : ''
>  }
> +
> +#sub client_step {
> +#  shift->_call('user');
> +#  ''
> +#}
>  
>  1;
>