Re: start_tls

[Chris R. <chr...@me...>]

Graham Barr <gb...@po...> wrote:
> On Fri, Jul 06, 2001 at 02:17:03PM +0100, Chris Ridd wrote:
>> Graham Barr <gb...@po...> wrote:
>> > On Fri, Jul 06, 2001 at 01:35:47PM +0100, Chris Ridd wrote:
>> >> Graham Barr <gb...@po...> wrote:
>> >> > On Fri, Jul 06, 2001 at 01:03:16PM +0100, Chris Ridd wrote:
>> >> >> The setting of capth/cafile to '' instead of undef is required by
>> >> >> 0.78. Hm, we could make our code check the IO::Socket::SSL version
>> >> >> and set the defaults appropriately...
>> >> > 
>> >> > Hm, I have o.78 here and it works fine with undef or ''
>> >> > 
>> >> > Graham.
>> >> 
>> >> You have to actually try verifying a server's cert using capath to see
>> >> this problem.
>> > 
>> > Ah, that would explain it.
>> > 
>> > Graham.
>> 
>> Would this patch be appropriate?
> 
> Yes. But it seems Marcus is going to release a new IO::Socket::SSL with
> my fix.
> 
> So rather than fill with version comparisons, I was thinking of the
> Makefile.PL warning if the version was < 0.80
> 
> What do you think ?
> 
> Graham.

Yes, I'm happy with that and for adding "use IO::Socket::SSL 0.80". We
probably want to wait until he's actually released 0.80 to make sure it
works correctly with perl-ldap, in case there are nasty surprises.

Cheers,

Chris