Re: FW: Net::LDAP::LDIF

[Graham B. <gb...@po...>]

OK, so this was down to bad test data.

The input LDIF for doing the modify had an entry which did not have a changetype: modify
line. Adding this in and the tests pass.

However the new code probably should have flagged a syntax error instead of what it
did.

Anyway the code looks good to me, so feel free to make similar changes to write

Graham.

On Thu, May 10, 2001 at 01:12:27AM +0100, Graham Barr wrote:
> Well it seems it is not 100% compatable.
> 
> $ SLAPD_EXE=/opt/openldap-1.2.11/libexec/slapd make test
> 
> t/00ldif-entry......ok
> t/01canon_dn........ok
> t/02filter..........ok
> t/50populate........ok
> t/51search..........ok
> t/52modify..........FAILED tests 47, 56
>         Failed 2/56 tests, 96.43% okay
> t/53schema..........ok
> Failed Test  Status Wstat Total Fail  Failed  List of failed
> -------------------------------------------------------------------------------
> t/52modify.t                 56    2   3.57%  47, 56
> Failed 1/7 test scripts, 85.71% okay. 2/347 subtests failed, 99.42% okay.
> *** Error code 2
> 
> I have not looked closly yet as it is getting late
> 
> Graham.
> 
> 
> On Thu, May 10, 2001 at 12:45:32AM +0100, Graham Barr wrote:
> > At first glance it looks OK to me.
> > 
> > Graham.
> > 
> > On Wed, May 09, 2001 at 04:09:52PM -0700, Robbie Allen wrote:
> > > Attached is a patch for LDIF.pm incorporating error handling using an
> > > onerror parameter in new() (just like in LDAP.pm) and a new read_entry()
> > > method.  read_entry() takes the place of read() and read_cmd() making both
> > > of those methods deprecated.  They will be removed in a future version.
> > > 
> > > Graham, let me know if I'm on the right track.  If so I'll work on the write
> > > methods next.
> > > 
> > > Robbie Allen
> >