Re: Net::LDAP::Util::canonical_dn

[Chris R. <chr...@me...>]

Graham Barr <gb...@po...> wrote:
> On Thu, Mar 08, 2001 at 12:45:42PM -0000, Chris Ridd wrote:
>> Graham Barr <gb...@po...> wrote:
>> > On Thu, Mar 08, 2001 at 11:04:06AM -0000, Chris Ridd wrote:
>> > 
>> >> Let's see, what canonicalisation does canonical_dn do..
>> >> 
>> >> * it lowercases values that are # followed by hex,
>> >> * it lowercases types that start with an OID,
> 
> Actually it removes the leading oid. caharacters if the type is
> an oid
> 
>> It also upper-cases attribute types.
> 
> Yes.
> 
>> I reckon it would be OK to call canonicalise_dn in the LDIF _write_cmd,
>> but perhaps only in the case where the DN has a char that is not a
>> 'SAFE-UTF8-CHAR', as per RFC 2849.
> 
> Well as we don't really handle UTF8 that wee yet (because perl does not
> either) I will go with the regexp [\x00-\x1f\x7f-\xff]
> 
> Graham.
> 

OK. The attached patch does the moddn stuff from Kartik, adds newsuperior
functionality, and canonicalises DNs when they are 'unsafe'.

Sing out anyone if they can see a dreadful flaw in this; otherwise I'll
integrate it in a couple of days.

Cheers,

Chris