Re: Changes to perl-ldap schema code

[Chris R. <chr...@me...>]

Graham Barr <gb...@po...> wrote:
> On Mon, Feb 05, 2001 at 10:21:30AM -0600, Clif Harden wrote:
>> > 
>> > Clif Harden <ch...@po...> wrote:
>> > > + =item schema ( OPTIONS )
>> > > + 
>> > > + Request that a schema search be performed.  This can be used to
>> > > read  + schema information.
>> > > + 
>> > > + The result is an object of class
>> > > L<Net::LDAP::Schema|Net::LDAP::Schema>. + Read this documentation
>> > > for further information about methods that + can be preformed with
>> > > this object.
>> > > + 
>> > > + =over 4
>> > > + 
>> > > + =item dn
>> > > + 
>> > > + If a DN is supplied, it will become the base object entry from 
>> > > + which the search for schema information will be conducted.  If
>> > > + no DN is supplied the base object entry will be determined from
>> > > + the rootDSE entry.
>> > 
>> > The changes look OK. I'd like to see it returning cached Schema
>> > objects, because these are quite expensive to keep retrieving and
>> > parsing. My second change of last week implemented a cache, it was
>> > kinda hacky but generally the right sort of approach.
> 
> I don't think it is the place of Net::LDAP to do the caching. As you say
> these can be quite large and for Net::LDAP tp cache them could just be a
> waste on memory. It should eb up to the user application to cache the
> object returned.

OK, fair argument. I'm not sure how we could implement caching up in the
application though, since the read of the subentry is very much hidden
inside schema(). But we can address that later on if it becomes necessary.

Cheers,

Chris