Re: Changes to perl-ldap schema code

[Chris R. <chr...@me...>]

Clif Harden <ch...@po...> wrote:
> + =item schema ( OPTIONS )
> + 
> + Request that a schema search be performed.  This can be used to read 
> + schema information.
> + 
> + The result is an object of class L<Net::LDAP::Schema|Net::LDAP::Schema>.
> + Read this documentation for further information about methods that
> + can be preformed with this object.
> + 
> + =over 4
> + 
> + =item dn
> + 
> + If a DN is supplied, it will become the base object entry from 
> + which the search for schema information will be conducted.  If
> + no DN is supplied the base object entry will be determined from
> + the rootDSE entry.

The changes look OK. I'd like to see it returning cached Schema objects,
because these are quite expensive to keep retrieving and parsing. My second
change of last week implemented a cache, it was kinda hacky but generally
the right sort of approach.

I'd suggest one change to the documentation above, to the effect that the
DN is the name of a subschema *subentry* containing the schema. ie replace
the word entry with subentry. I think that clarifies what it is doing.

We still need a mechanism for retrieving subschema given the DN of a plain
entry (, which is by far and away the *best* way of getting schema. (Maybe
we can add this to Net::LDAP::Entry?)

Cheers,

Chris