perl-css-devel

[css] CSS::SAC fails to parse p:first-line

[Bjoern H. <der...@gm...>]

Hi Robin,

  I have a ruleset

  p:first-line { }

CSS::SAC fails to parse it. Around line 1000 

| # here we need to check whether the next token is also a selector
| # if it is, we need to make an AND_CONDITION containing the two selectors
| # and to attach it to a universal selector
| # then we'll have to mix it into the $cond below.
|     if (@tokens) {
|         eval { $tokens[0]->SelectorType };
|         if (!$@) {
|             my $and_cond = $sac->[_cf_]->create_and_condition($selector,shift @tokens);
|             $selector = $sac->[_sf_]->create_element_selector(undef,undef);
|         }
|     }

$and_cond is lost and $selector is useless from this point, thus one
gets

  bless([bless([9],'CSS::SAC::Selector::Element')],'CSS::SAC::SelectorList')

rather than what is expected. Thoughts?

[css] Re: CSS::SAC fails to parse p:first-line

[Robin B. <rob...@ex...>]

Bjoern Hoehrmann wrote:
>   I have a ruleset
> 
>   p:first-line { }
> 
> CSS::SAC fails to parse it. Around line 1000 
> 
> Thoughts?

This is a long standing bug, it requires some change in the tokenizer, or a bit 
later to special-case pseudo-elements. I've started to put my head back into SAC 
for a clean-up, that's high on the list together with patches from you and Briac.

-- 
Robin Berjon <rob...@ex...>
Research Engineer, Expway        http://expway.fr/
7FC0 6F5F D864 EFB8 08CE  8E74 58E6 D5DB 4889 2488

Re: [css] Re: CSS::SAC fails to parse p:first-line

[Bjoern H. <der...@gm...>]

* Robin Berjon wrote:
>Bjoern Hoehrmann wrote:
>>   I have a ruleset
>> 
>>   p:first-line { }
>> 
>> CSS::SAC fails to parse it. Around line 1000 
>> 
>> Thoughts?
>
>This is a long standing bug, it requires some change in the tokenizer, or a bit 
>later to special-case pseudo-elements. I've started to put my head back into SAC 
>for a clean-up, that's high on the list together with patches from you and Briac.

Great. From the POD

  the problem with attaching pseudo-elements to elements as
  coselectors. I'm not sure which is the right representation. Don't
  forget to update CSS::SAC::Writer too so that it writes it out
  properly.

Flute and Batik both use

  $sf->create_child_selector(<p>, <first-line>)

for the selector above. Note that CSS Level 3 will eventually allow
attaching pseudo-elements to pseudo-elements. It's not in the selectors
CR, but the generated content WD has examples. CSS::SAC should parse
them properly. And as we are here, CSS::SAC recognizes :selection as
pseudo-elements. That's not accurate, since the single-colon notation is
allowed only for ::first-line, ::first-letter, ::after, and ::before,
:selection should thus parse as pseudo class.

regards.