perl-css-devel

[css] Text::Balanced test cases

[Bjoern H. <der...@gm...>]

Hi,

   CSS::SAC needs some addtitional test cases to fail some tests if the
required Text::Balanced version is not installed. I don't remember what
made the difference (probably multiline strings, Robin probably knows
better), therfore I cannot recommend some...

regards,
-- 
Björn Höhrmann { mailto:bj...@ho... } http://www.bjoernsworld.de
am Badedeich 7 } Telefon: +49(0)4667/981028 { http://bjoern.hoehrmann.de
25899 Dagebüll { PGP Pub. KeyID: 0xA4357E78 } http://www.learn.to/quote/

Re: [css] Text::Balanced test cases

[Robin B. <ro...@kn...>]

On Sunday 21 October 2001 20:30, Bjoern Hoehrmann wrote:
>    CSS::SAC needs some addtitional test cases to fail some tests if the
> required Text::Balanced version is not installed. I don't remember what
> made the difference (probably multiline strings, Robin probably knows
> better), therfore I cannot recommend some...

The problem was with a faulty regex in Text::Balanced. Unless you have found 
a new bug, that bug was fixed in version 1.84.

The way to check that the right version is installed is normally through 
Makefile.PL's PREREQ_PM hash. Right now that part is asking that the user 
have Text::Balanced 1.84 or better, and ought to warn if it's not there (the 
CPAN shell will fetch the dependency if it fails).

If people are installing it in other ways, then the only way to impose a 
version is to have SAC.pm say "use Text::Balanced '1.84'". Feel free to patch 
that if you think people may not be using Makefile.PL correctly (which would 
be silly, but you never know. And perhaps PPM doesn't work with that ?)

-- 
_______________________________________________________________________
Robin Berjon <ro...@kn...> -- CTO
k n o w s c a p e : // venture knowledge agency www.knowscape.com
-----------------------------------------------------------------------
Is life worth living?
It all depends upon the liver.

Re: [css] Text::Balanced test cases

[Bjoern H. <der...@gm...>]

* Robin Berjon wrote:
>On Sunday 21 October 2001 20:30, Bjoern Hoehrmann wrote:
>>    CSS::SAC needs some addtitional test cases to fail some tests if the
>> required Text::Balanced version is not installed. I don't remember what
>> made the difference (probably multiline strings, Robin probably knows
>> better), therfore I cannot recommend some...
>
>The problem was with a faulty regex in Text::Balanced. Unless you have found 
>a new bug, that bug was fixed in version 1.84.
>
>The way to check that the right version is installed is normally through 
>Makefile.PL's PREREQ_PM hash. Right now that part is asking that the user 
>have Text::Balanced 1.84 or better, and ought to warn if it's not there (the 
>CPAN shell will fetch the dependency if it fails).
>
>If people are installing it in other ways, then the only way to impose a 
>version is to have SAC.pm say "use Text::Balanced '1.84'". Feel free to patch 
>that if you think people may not be using Makefile.PL correctly (which would 
>be silly, but you never know. And perhaps PPM doesn't work with that ?)

What if Text::Balanced 1.99 re-introduces this bug? :-)
Having a test case, we can notice it.
-- 
Björn Höhrmann { mailto:bj...@ho... } http://www.bjoernsworld.de
am Badedeich 7 } Telefon: +49(0)4667/981028 { http://bjoern.hoehrmann.de
25899 Dagebüll { PGP Pub. KeyID: 0xA4357E78 } http://www.learn.to/quote/

Re: [css] Text::Balanced test cases

[Robin B. <ro...@kn...>]

On Monday 22 October 2001 05:18, Bjoern Hoehrmann wrote:
> What if Text::Balanced 1.99 re-introduces this bug? :-)
> Having a test case, we can notice it.

Well... it would be a bit over the border to test other modules in our own 
distribution. We might as well ship with Perl's test suite to check that it's 
working fine :)

If I remember correctly, the bug was that a backslash before a newline inside 
a block caused extract_bracketed to fail. The following should be a failing 
sample:

{
 prop: val\
ue;
}

The place for this test is, of course, Text::Balanced's own test suite. 
Cooking up a test for this would be easy (if Damian hasn't already included 
one). You can then submit it to him for inclusion (and wait ~three weeks for 
him to reach the bottom of his mail backlog ;-)

-- 
_______________________________________________________________________
Robin Berjon <ro...@kn...> -- CTO
k n o w s c a p e : // venture knowledge agency www.knowscape.com
-----------------------------------------------------------------------
Computer games don't affect kids, I mean if pac man affected us as kids,
we'd all sit around in a darkened room munching pills and listening to
repetitive music.

Re: [css] Text::Balanced test cases

[Bjoern H. <der...@gm...>]

* Robin Berjon wrote:
>On Monday 22 October 2001 05:18, Bjoern Hoehrmann wrote:
>> What if Text::Balanced 1.99 re-introduces this bug? :-)
>> Having a test case, we can notice it.
>
>Well... it would be a bit over the border to test other modules in our own 
>distribution.

We test only CSS::SAC which has to parse correctly, no matter what it
uses to do parsing. If other modules fail, CSS::SAC also fails. I just
don't want to get a 100% success for the tests if Text::Balanced is
outdated.
-- 
Björn Höhrmann { mailto:bj...@ho... } http://www.bjoernsworld.de
am Badedeich 7 } Telefon: +49(0)4667/981028 { http://bjoern.hoehrmann.de
25899 Dagebüll { PGP Pub. KeyID: 0xA4357E78 } http://www.learn.to/quote/

Re: [css] Text::Balanced test cases

[Robin B. <ro...@kn...>]

On Tuesday 23 October 2001 00:02, Bjoern Hoehrmann wrote:
> * Robin Berjon wrote:
> >On Monday 22 October 2001 05:18, Bjoern Hoehrmann wrote:
> >> What if Text::Balanced 1.99 re-introduces this bug? :-)
> >> Having a test case, we can notice it.
> >
> >Well... it would be a bit over the border to test other modules in our own
> >distribution.
>
> We test only CSS::SAC which has to parse correctly, no matter what it
> uses to do parsing. If other modules fail, CSS::SAC also fails. I just
> don't want to get a 100% success for the tests if Text::Balanced is
> outdated.

Then don't worry too much, it was one of the test cases that triggered the 
T::B bug. Normally, CSS::SAC should refuse to install (or at least warn 
violently) for outdated T::Bs. Unless of course you copy it by hand to its 
install dir, in which case you're obviously asking for trouble.

That's not to say that we don't want more test cases. Ideally, we'd test 
everything, and every fixed bug would get a test case to check for regression 
problems. It's just that tests are painful to write in normal situations, and 
even harder for event driven code. Thankfully, Barrie Slaymaker recently sent 
me a diff module that should help lots with that.

-- 
_______________________________________________________________________
Robin Berjon <ro...@kn...> -- CTO
k n o w s c a p e : // venture knowledge agency www.knowscape.com
-----------------------------------------------------------------------
Make it idiot proof and someone will make a better idiot.