From: Bjoern H. <der...@gm...> - 2001-10-22 03:19:36
|
* Robin Berjon wrote: >On Sunday 21 October 2001 20:30, Bjoern Hoehrmann wrote: >> CSS::SAC needs some addtitional test cases to fail some tests if the >> required Text::Balanced version is not installed. I don't remember what >> made the difference (probably multiline strings, Robin probably knows >> better), therfore I cannot recommend some... > >The problem was with a faulty regex in Text::Balanced. Unless you have found >a new bug, that bug was fixed in version 1.84. > >The way to check that the right version is installed is normally through >Makefile.PL's PREREQ_PM hash. Right now that part is asking that the user >have Text::Balanced 1.84 or better, and ought to warn if it's not there (the >CPAN shell will fetch the dependency if it fails). > >If people are installing it in other ways, then the only way to impose a >version is to have SAC.pm say "use Text::Balanced '1.84'". Feel free to patch >that if you think people may not be using Makefile.PL correctly (which would >be silly, but you never know. And perhaps PPM doesn't work with that ?) What if Text::Balanced 1.99 re-introduces this bug? :-) Having a test case, we can notice it. -- Björn Höhrmann { mailto:bj...@ho... } http://www.bjoernsworld.de am Badedeich 7 } Telefon: +49(0)4667/981028 { http://bjoern.hoehrmann.de 25899 Dagebüll { PGP Pub. KeyID: 0xA4357E78 } http://www.learn.to/quote/ |