Hello,
After upgrading to 101.1 I noticed that warning and critical lines
weren't drawn. After investigating this a little, I found out that this
data (critical and warning levels) wasn't even written to mysql.
And as I found out, in storage_mysql.c in save_bin_data() function
creation of INSERT query tried to insert wrong values there:
- warn value from: perf->d[PERF_VALUE_WARN_START]
- crit value from: perf->d[PERF_VALUE_CRIT_START]
But these were always 0. PERF_VALUE_WARN_END and PERF_VALUE_CRIT_END
contained correct values. Was this intentional and I missed something
during upgrade, or was this bug?
To get this working correctly I had to add infinite value checking to
getSafeD function also.
Just in case this was a bug I add patch also.
Best regards,
Viljo
|
