perfparse-devel-int

[Perfparse-devel-int] Patch for postgresql support and autotools

[Yves <yme...@pe...>]

Hi Ben,

I found time to check configure.ac and Makefile.am files.
Check the attached patch.

With that, you are supposed to have the pg_config executable (just like t=
he mysql_config
one) and configure will use it to set POSTGRESQL_CFLAGS and POSTGRESQL_LI=
BS.

I also noticed some mistakes :
- postgressql mistyping :)
- you cannot init the same variable in 2 distinct conditionnals blocs (li=
mitation of
automake ?)

I fixed them.

I have not tested what I did, so please do it.

I noticed some problems when compiling perfparse with mysql support. See =
the attached
file. No time to debug myself. Sorry :)

Yves


--=20
- Homepage    - http://ymettier.free.fr - http://www.logicacmg.com -
- GPG key     - http://ymettier.free.fr/gpg.txt                    -
- Maitretarot - http://www.nongnu.org/maitretarot/                 -
- Perfparse   - http://perfparse.sf.net/                           -

Re: [Perfparse-devel-int] Patch for postgresql support and autotools

[Ben C. <bcl...@pe...>]

Yves,

Thanks for the patches.  I'll apply those.  I found the pg_config 
program, but wasn't sure how to error if program not found.  Now I know :)

Thanks for the fix as well.

I'll look at the MySQL compilation problem and email you later.

Ben

Yves wrote:

> Hi Ben,
> 
> I found time to check configure.ac and Makefile.am files.
> Check the attached patch.
> 
> With that, you are supposed to have the pg_config executable (just like the mysql_config
> one) and configure will use it to set POSTGRESQL_CFLAGS and POSTGRESQL_LIBS.
> 
> I also noticed some mistakes :
> - postgressql mistyping :)
> - you cannot init the same variable in 2 distinct conditionnals blocs (limitation of
> automake ?)
> 
> I fixed them.
> 
> I have not tested what I did, so please do it.
> 
> I noticed some problems when compiling perfparse with mysql support. See the attached
> file. No time to debug myself. Sorry :)
> 
> Yves
> 
> 


-- 
Ben Clewett  bcl...@pe...
PerfParse    http://www.perfparse.org
PP FAQ       http://wiki.perfparse.org/tiki-list_faqs.php

Re: [Perfparse-devel-int] Patch for postgresql support and autotools

[Yves <yme...@pe...>]

> Thanks for the patches.  I'll apply those.  I found the pg_config
> program, but wasn't sure how to error if program not found.  Now I know=
 :)

Just like when mysql_config is missing :)


Yves

--=20
- Homepage    - http://ymettier.free.fr - http://www.logicacmg.com -
- GPG key     - http://ymettier.free.fr/gpg.txt                    -
- Maitretarot - http://www.nongnu.org/maitretarot/                 -
- Perfparse   - http://perfparse.sf.net/                           -

Re: [Perfparse-devel-int] Patch for postgresql support and autotools

[Ben C. <bcl...@pe...>]

I get the error.

Friedrich has enlarged the size of the time variables in order to hold 
the longer time format of PostgreSQL:  (not ISO standard definition :)

MySQL:	'YYYY-MM-DD HH:MM:SS'
PSQL:	'YYYY-MM-DD HH:MM:SS.mmm'

But not enlarged the definition held in MySQL code-space.

(Unfortunately the timestamp from Nag does not use milliseconds, so 
cannot use this anyway :)

This will need some work since I use this variable directly on the CGI 
pages, and PSQL will need shortening back to the MySQL variant....

For time being I believe ignoring the warning will work.  Odd, I don't 
get this on my setup.

There are some other bits I've fixed, so will move to get out 0.105.2 
soon.  Then publicly announce PerfParse with PostgreSQL!!!

Might you or Tim have the exit() problem solved on perfparsed for this 
release?

Friedrich,

Is there anything else you want to add to the release?

Ben.





Yves wrote:

> Hi Ben,
> 
> I found time to check configure.ac and Makefile.am files.
> Check the attached patch.
> 
> With that, you are supposed to have the pg_config executable (just like the mysql_config
> one) and configure will use it to set POSTGRESQL_CFLAGS and POSTGRESQL_LIBS.
> 
> I also noticed some mistakes :
> - postgressql mistyping :)
> - you cannot init the same variable in 2 distinct conditionnals blocs (limitation of
> automake ?)
> 
> I fixed them.
> 
> I have not tested what I did, so please do it.
> 
> I noticed some problems when compiling perfparse with mysql support. See the attached
> file. No time to debug myself. Sorry :)
> 
> Yves
> 
> 


-- 
Ben Clewett  bcl...@pe...
PerfParse    http://www.perfparse.org
PP FAQ       http://wiki.perfparse.org/tiki-list_faqs.php

Re: [Perfparse-devel-int] Patch for postgresql support and autotools

[Yves <yme...@pe...>]

> Might you or Tim have the exit() problem solved on perfparsed for this
> release?

Probably not.

Yves


--=20
- Homepage    - http://ymettier.free.fr - http://www.logicacmg.com -
- GPG key     - http://ymettier.free.fr/gpg.txt                    -
- Maitretarot - http://www.nongnu.org/maitretarot/                 -
- Perfparse   - http://perfparse.sf.net/                           -

Re: [Perfparse-devel-int] Patch for postgresql support and

[Ben C. <bcl...@pe...>]

Yves wrote:

> Just like when mysql_config is missing :)

OK, this is true.  But I was trying to understand how the code works, 
before coping what could be rubbish when applied to PostgreSQL...

You have to admit, although the code is perfect and well written, it 
looks horrible:

PG_CONFIG_DIR=
AC_ARG_WITH(pg_config_dir,
[  --with-pg_config_dir=PATH        pg_config full path (default=)],[
   if test "$withval" != "no" -a "$withval" != "yes"; then
     PG_CONFIG_DIR=$withval
   fi
])
AC_PATH_PROG([PG_CONFIG], pg_config,[no], ${PG_CONFIG_DIR}:${PATH})
if test "x$PG_CONFIG" = "xno"; then
   AC_MSG_ERROR([Could not find pg_config])
fi


My vision goes blurry just looking at it :)

Also I found a difference last night when half way there.

I got to this same as you:

POSTGRESQL_CFLAGS=`${PG_CONFIG} --cflags`
POSTGRESQL_LIBS=`${PG_CONFIG} --libs`

But in fact needs to be:

POSTGRESQL_CFLAGS="-I`${PG_CONFIG} --cflags`"
POSTGRESQL_LIBS="-L`${PG_CONFIG} --libs` -lpg"

Makes big difference :)

Ben.



-- 
Ben Clewett  bcl...@pe...
PerfParse    http://www.perfparse.org
PP FAQ       http://wiki.perfparse.org/tiki-list_faqs.php

Re: [Perfparse-devel-int] Patch for postgresql support and

[Yves <yme...@pe...>]

> You have to admit, although the code is perfect and well written, it
> looks horrible:

Yes, I do :)
But when you have some experience with autotools, you can see what is imp=
ortant and what
is not, and understand.

> My vision goes blurry just looking at it :)

:)


> Also I found a difference last night when half way there.
>
> I got to this same as you:
>
> POSTGRESQL_CFLAGS=3D`${PG_CONFIG} --cflags`
> POSTGRESQL_LIBS=3D`${PG_CONFIG} --libs`
>
> But in fact needs to be:
>
> POSTGRESQL_CFLAGS=3D"-I`${PG_CONFIG} --cflags`"
> POSTGRESQL_LIBS=3D"-L`${PG_CONFIG} --libs` -lpg"
>
> Makes big difference :)

I cannot be "-I`${PG_CONFIG} --cflags... and "-L`${PG_CONFIG} --libs... :=
)

It has to be "${PG_CONFIG} --some_option_to_get_cflags" and "${PG_CONFIG}
--some_options_to_get_libdirs_and_libs"

Run pg_config --help and try to understand what it does. Then update conf=
igure.ac :)

Yves


>
> Ben.
>
>
>
> --
> Ben Clewett  bcl...@pe...
> PerfParse    http://www.perfparse.org
> PP FAQ       http://wiki.perfparse.org/tiki-list_faqs.php
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
> Tool for open source databases. Create drag-&-drop reports. Save time
> by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
> Download a FREE copy at http://www.intelliview.com/go/osdn_nl
> _______________________________________________
> Perfparse-devel-int mailing list
> Per...@li...
> https://lists.sourceforge.net/lists/listinfo/perfparse-devel-int
>
>


--=20
- Homepage    - http://ymettier.free.fr - http://www.logicacmg.com -
- GPG key     - http://ymettier.free.fr/gpg.txt                    -
- Maitretarot - http://www.nongnu.org/maitretarot/                 -
- Perfparse   - http://perfparse.sf.net/                           -