Menu
▾
▴
perfparse-devel-int
|
From: Priewasser, F. <Fri...@fa...> - 2005-01-17 08:26:17
Attachments:
PerfparseWithPostgreSQL.tar.gz
|
Hello, I have created the PostgreSQL storage module, as said a few weeks=20 ago. It already works on my system (including web frontend) - after = makeing some changes to the makefiles by hand. Description of the files in the uploaded package: Makefiles.diff: Changes to Makefiles Changes.diff: Other changes New: New files perfparse_notes.txt: A few notes and problems I had Please let me know what you think about Regards, Friedrich -- Friedrich Priewasser Software Engineer Fabalabs Software GmbH Honauerstra=DFe 4 A-4020 Linz e-mail: mailto:fri...@fa... http://www.fabalabs.org |
|
From: Ben C. <bcl...@pe...> - 2005-01-17 10:21:14
|
Friedrich
Thanks for the returned package.
I'll comment on the SQL code. Yves may comment on the Makefile alterations.
I have had a brief look at the code, it looks impressive. Thanks for
making the SQL a little more robust where required. Using correct ANSI
SQL and correct SQL boolean values. This will help greatly the next
platform used.
We need to get a generic solution to iteration through a table. I see a
lot of:
#ifdef USE_DB_MYSQL
while ((result_row = mysql_fetch_row(query_result))) {
#elif defined USE_DB_POSTGRESQL
numberOfRows = rows();
for (currentRow = 0; currentRow<numberOfRows; currentRow++){
#endif
Maybe we can think of a way of abstracting this. Something like:
#ifdef USE_DB_MYSQL
#define TABLE_ITTERATE_START \
while ((result_row = mysql_fetch_row(query_result)))
#else
#define TABLE_ITTERATE_START \
numberOfRows = rows(); \
for (currentRow = 0; currentRow<numberOfRows; currentRow++)
#endif
There are a few more function that need abstracting as well. I note a
test whether current row exists. I note you have a new data types,
boolean and time. I'll reflect this in MySQL API.
I note your comments in the tar file about VARCHAR size limits. If this
is the case, please use TEXT instead. (My colleague tells me that Tom
Lane of PostgreSQL says use TEXT anyware you want, it's no less
efficient than VARCHAR yet having none of it's limits :)
I am not sure about releasing with the next version, since this will be
today. But if Yves is okay with it, I am all for releasing next
versions. It will be a great addition to the application.
There is also the boring bit: Documents. You may want to look at the
accessible documentation and change/add anything relevant.
I am very impressed with the work, look forward to it being part of the
project.
Regards,
Ben.
Priewasser, Friedrich wrote:
> Hello,
>
> I have created the PostgreSQL storage module, as said a few weeks
> ago. It already works on my system (including web frontend) - after makeing some changes to the makefiles by hand.
>
>
> Description of the files in the uploaded package:
>
> Makefiles.diff: Changes to Makefiles
> Changes.diff: Other changes
> New: New files
> perfparse_notes.txt: A few notes and problems I had
>
>
> Please let me know what you think about
>
> Regards,
> Friedrich
>
> --
> Friedrich Priewasser
> Software Engineer
> Fabalabs Software GmbH
> Honauerstraße 4
> A-4020 Linz
> e-mail: mailto:fri...@fa...
> http://www.fabalabs.org
>
>
>
--
Ben Clewett bcl...@pe...
PerfParse http://www.perfparse.org
PP FAQ http://wiki.perfparse.org/tiki-list_faqs.php
|
|
From: Yves <yme...@pe...> - 2005-01-17 11:08:17
|
Hi ! I have not tried the patch yet, and I have no postgresql to test. Ben, I suggest that you release 0.104.9 without postgresql as soon as pos= sible. 0.104.9 should be the latest version without postgresql support. At the same time, release 0.105.1 with postgresql support. Send only one mail for the release of 0.104.9 and 0.105.1 Users should naturally try the "latest" version 0.105.1 with or without u= sing the postgresql support feature. If there is any serious problem with 0.105.1,= we can tell users to downgrade to 0.104.9 that is more stable than 0.104.8 and ask th= em to wait for a more stable 0.105.2. Friedrich, I don't know who will support the postgresql feature at the be= ginning. Will you help users and fix bugs at the beginning ? When postgresql support be= comes more popular, other will help you to help users and fix bugs. Ben, I will not have time to work on perfparse today and tomorrow. I don'= t know for later in the week. Don't wait for me for 0.105.1. I'll only try to send c= omments for the Makefile stuff :) Thanks for your work and for the postgresql code ! :) Yves --=20 - Homepage - http://ymettier.free.fr - http://www.logicacmg.com - - GPG key - http://ymettier.free.fr/gpg.txt - - Maitretarot - http://www.nongnu.org/maitretarot/ - - Perfparse - http://perfparse.sf.net/ - |
|
From: Ben C. <bcl...@pe...> - 2005-01-17 11:55:42
|
Yves, You share my thoughts about the release. 0.104.9 will be without PostgreSQL. Released this evening, about 2000 GMT. The version with PostgreSQL. There is a problem. Friedrich has adjusted the Makefile to allow compilation on his machine. When I 'make configure' these changes will be deleted. I need to get these changes into the configure.ac and various Makefile.am files. For this I need your help :) After this, I can release the PostgreSQL version. My belief is that users not selecting PostgreSQL will get the same product. Therefore a joint release is safe. When the configure is altered. As you say, this will be 0.105.1. With this need a method of selecting database: ./configure --mysql (default) ./configure --psql ./configure --no_sql With documentation. ???? Yves, would you have time to make the required adjustments to the configuration? Regards, Ben. Yves wrote: > Hi ! > > I have not tried the patch yet, and I have no postgresql to test. > Ben, I suggest that you release 0.104.9 without postgresql as soon as possible. 0.104.9 > should be the latest version without postgresql support. > At the same time, release 0.105.1 with postgresql support. > Send only one mail for the release of 0.104.9 and 0.105.1 > > Users should naturally try the "latest" version 0.105.1 with or without using the > postgresql support feature. If there is any serious problem with 0.105.1, we can tell > users to downgrade to 0.104.9 that is more stable than 0.104.8 and ask them to wait for > a more stable 0.105.2. > > Friedrich, I don't know who will support the postgresql feature at the beginning. Will > you help users and fix bugs at the beginning ? When postgresql support becomes more > popular, other will help you to help users and fix bugs. > > Ben, I will not have time to work on perfparse today and tomorrow. I don't know for > later in the week. Don't wait for me for 0.105.1. I'll only try to send comments for the > Makefile stuff :) > > Thanks for your work and for the postgresql code ! :) > > Yves > > -- Ben Clewett bcl...@pe... PerfParse http://www.perfparse.org PP FAQ http://wiki.perfparse.org/tiki-list_faqs.php |
|
From: Yves <yme...@pe...> - 2005-01-17 12:05:44
Attachments:
perfparse-0.104.8.with_pg.Makefile_only.diff.gz
|
> The version with PostgreSQL. There is a problem. Friedrich has > adjusted the Makefile to allow compilation on his machine. When I 'mak= e > configure' these changes will be deleted. I need to get these changes > into the configure.ac and various Makefile.am files. For this I need > your help :) I had problem because I insisted on using patch with -p1 instead of -p0 p= arameter :) Attached : a patch for all Makefile.am and configure.ac. Use patch -p1 Apply it against 0.104.8 (and probably 0.104.9) > After this, I can release the PostgreSQL version. My belief is that > users not selecting PostgreSQL will get the same product. Therefore a > joint release is safe. When the configure is altered. As you say, thi= s > will be 0.105.1. > > With this need a method of selecting database: > > ./configure --mysql (default) > ./configure --psql > ./configure --no_sql This already exists (recent change : check the ChangeLog) ./configure --help | grep postgresql > Yves, would you have time to make the required adjustments to the > configuration? Check the patch. Some minor changes on most Makefile.am files. Major changes on cgi/Makefi= le.am because CGI_INCLUDES and CGI_LIBS should remain out of the if block. Yves --=20 - Homepage - http://ymettier.free.fr - http://www.logicacmg.com - - GPG key - http://ymettier.free.fr/gpg.txt - - Maitretarot - http://www.nongnu.org/maitretarot/ - - Perfparse - http://perfparse.sf.net/ - |
|
From: Ben C. <bcl...@pe...> - 2005-01-17 13:52:59
|
Yves, I have not applied the patch, but the contents looks excellent. I will release two versions this evening :) Ben Yves wrote: >>The version with PostgreSQL. There is a problem. Friedrich has >>adjusted the Makefile to allow compilation on his machine. When I 'make >>configure' these changes will be deleted. I need to get these changes >>into the configure.ac and various Makefile.am files. For this I need >>your help :) > > > I had problem because I insisted on using patch with -p1 instead of -p0 parameter :) > > Attached : a patch for all Makefile.am and configure.ac. > Use patch -p1 > Apply it against 0.104.8 (and probably 0.104.9) > > >>After this, I can release the PostgreSQL version. My belief is that >>users not selecting PostgreSQL will get the same product. Therefore a >>joint release is safe. When the configure is altered. As you say, this >>will be 0.105.1. >> >>With this need a method of selecting database: >> >>./configure --mysql (default) >>./configure --psql >>./configure --no_sql > > > This already exists (recent change : check the ChangeLog) > ./configure --help | grep postgresql > > > >>Yves, would you have time to make the required adjustments to the >>configuration? > > > Check the patch. > Some minor changes on most Makefile.am files. Major changes on cgi/Makefile.am because > CGI_INCLUDES and CGI_LIBS should remain out of the if block. > > Yves -- Ben Clewett bcl...@pe... PerfParse http://www.perfparse.org PP FAQ http://wiki.perfparse.org/tiki-list_faqs.php |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X