Re: [Perfparse-devel-int] Perfparse PostgreSQL Storage Module

[Ben C. <bcl...@pe...>]

Friedrich

Thanks for the returned package.

I'll comment on the SQL code.  Yves may comment on the Makefile alterations.

I have had a brief look at the code, it looks impressive.  Thanks for 
making the SQL a little more robust where required.  Using correct ANSI 
SQL and correct SQL boolean values.  This will help greatly the next 
platform used.

We need to get a generic solution to iteration through a table.  I see a 
lot of:

#ifdef USE_DB_MYSQL
      while ((result_row = mysql_fetch_row(query_result))) {
#elif defined USE_DB_POSTGRESQL
      numberOfRows = rows();
      for (currentRow = 0; currentRow<numberOfRows; currentRow++){
#endif

Maybe we can think of a way of abstracting this.  Something like:

#ifdef USE_DB_MYSQL
	#define TABLE_ITTERATE_START \
		while ((result_row = mysql_fetch_row(query_result)))
#else
	#define TABLE_ITTERATE_START \
		numberOfRows = rows(); \
		for (currentRow = 0; currentRow<numberOfRows; currentRow++)
#endif

There are a few more function that need abstracting as well.  I note a 
test whether current row exists.  I note you have a new data types, 
boolean and time.  I'll reflect this in MySQL API.

I note your comments in the tar file about VARCHAR size limits.  If this 
is the case, please use TEXT instead.  (My colleague tells me that Tom 
Lane of PostgreSQL says use TEXT anyware you want, it's no less 
efficient than VARCHAR yet having none of it's limits :)

I am not sure about releasing with the next version, since this will be 
today.  But if Yves is okay with it, I am all for releasing next 
versions.  It will be a great addition to the application.

There is also the boring bit:  Documents.  You may want to look at the 
accessible documentation and change/add anything relevant.

I am very impressed with the work, look forward to it being part of the 
project.

Regards,

Ben.









Priewasser, Friedrich wrote:

> Hello,
> 
> I have created the PostgreSQL storage module, as said a few weeks 
> ago. It already works on my system (including web frontend) - after makeing some changes to the makefiles by hand.
> 
> 
> Description of the files in the uploaded package:
> 
> Makefiles.diff: Changes to Makefiles
> Changes.diff: Other changes
> New: New files
> perfparse_notes.txt: A few notes and problems I had
> 
> 
> Please let me know what you think about
> 
> Regards,
> Friedrich
> 
> --
> Friedrich Priewasser
> Software Engineer
> Fabalabs Software GmbH
> Honauerstraße 4
> A-4020 Linz
> e-mail: mailto:fri...@fa...
> http://www.fabalabs.org
> 
> 
> 


-- 
Ben Clewett  bcl...@pe...
PerfParse    http://www.perfparse.org
PP FAQ       http://wiki.perfparse.org/tiki-list_faqs.php