From: Ben C. <Ben...@ro...> - 2005-01-04 12:16:23
|
Just another comment: Reinstating the perfparse.sh does not need any c code. This reads the perfparse.cfg file directly. All that is needed is the nagios.lock definition returned to this file :) Ben Ben Clewett wrote: > Yves, > > I kept the original thread in the 'users' mailing list, my thinking > being that they are the ones who uss this, and will therefore know. I > hope we get some response from them about who still uses this. > > I my self use the perfparse.sh script on a live server. I do a clean > parse every hour, which is the way I want to run that server. I have > not upgraded this one for a while, so was unaware of the nagios.lock > being taken out of the config. Do you remember which version this was > removed? > > Therefore I would prefer it is supported as-is. It's a nice ability if > people want it, although there may be better methods. > > I also comment on the 'contrib' directory. This contains the > create/drops scripts for the database. Which I chose because that's > where Nagios puts them, so users may find them more easily. These are > supported. Maybe these need another directory? > > I agree that the perfparse_deamon.sh should go. > > Ben > > > Yves wrote: > >> Hi ! >> >> There are 2 scripts perfparse.sh and perfparse_daemon.sh in the >> perfparse project. >> Are they working ? Are they supported ? Are they obsolete ? Should >> they be removed ? >> >> perfparse_daemon.sh >> =================== >> It's in the contrib/ directory. I consider that everything in contrib/ >> is unsupported. >> We can update things in contrib/ ourselves, but it's like a place to >> put things that we >> don't use and cannot support easily. >> >> perfparse_daemon.sh was made before perfparsed. Now, we have >> perfparsed that does better >> work than perfparse_daemon.sh and perfparse-log2mysql combined. >> I think that perfparse_daemon.sh should be removed, even if it seems >> to work and to be >> up to date :) >> It's better to force users who are running perfparse_daemon.sh to use >> perfparsed. Of >> course, they can keep their script if they want. >> >> perfparse.sh >> ============ >> >> This script contains a reference to nagios lock. For that reason, I >> consider it as >> obsolete. But it is in perfparse/ directory so we have to consider it >> as supported. A >> decision has to be taken here : remove it or update it quick ? :) >> >> In the doc, perfparse.sh is used in the crontab, to call perfparse-log2* >> We now have perfparsed, but perfparsed does not do exactly the same job. >> Users who are running perfparse.sh with a "* * * * *" scheduling >> should use perfparsed. >> Users who are running perfparse.sh every 10 minutes or every hour or >> every day cannot >> use perfparsed for that. Those users can run perfparse-log2* with the >> -c option >> (configuration file). Should we provide a script that just does it ? >> Decision to be taken : >> - do we update perfparse.sh and support it ? >> - do we remove perfparse.sh from perfparse ? >> - do we update perfparse.sh and move it to contrib/ (in order to say >> that we don't >> support it) ? >> >> Your opinion... ? >> >> Yves > > > |