RE: [Perfparse-users] Check_ifstatus patch

[Cook, G. <GW...@ma...>]

Ben Clewett wrote:
> Hi Garry,
>=20
> Good patch.  I couldn't help noticing a little error.  The
> delimiter for
> performance data is ' ' and not ','.  PP is very forgiving, but other
> programs may not be so.  Have a look at this for more information:
>=20
> http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN185
>=20
> Don't worry, I have posted may a bad comment in my time.
> Usually people
> are happy to see some enthusiasm and interest.  Let me know if your
> patch is accepted, in what ever format. :)
>=20
> Regards, Ben.

Thanks for the heads up Ben. I've poked and prodded a little more, and
this patch seems to work well. However, I'm not going to send it over to
the plugin development list just yet, as I've already notified them of
the issue, and I'm sure that there is probably someone over there who
can make it work even better. If I don't see anything about it in the
next few days, I'll send them this one.

In the meantime, if anyone is using check_ifstatus (Jon, are you still
out there?), please test this out and provide me some feedback.
Thanks.=20

Due to the fact that this is probably going to wordwrap, I've attached
the patchfile as well.

*** check_ifstatus2     2004-06-16 10:08:28.000000000 -0600
--- check_ifstatus.orig 2004-06-16 08:11:54.000000000 -0600
***************
*** 207,213 ****
                        $ifexclude,
                        $ifunused);
     }
! my $perfdata =3D sprintf("up=3D%d;;;; down=3D%d;;;; dormant=3D%d;;;;
excluded=3D%d;;;; =
unused=3D%d;;;;",$ifup,$ifdown,$ifdormant,$ifexclude,$i
funused);
  print ("$state: $answer |$perfdata\n");
  exit $ERRORS{$state};
 =20
--- 207,213 ----
                        $ifexclude,
                        $ifunused);
     }
! my $perfdata =3D
sprintf("up:%d,down:%d,dormant:%d,excluded:%d,unused:%d",$ifup,$ifdown,$
ifdormant,$ifexclude,$ifunused);
  print ("$state: $answer |$perfdata\n");
  exit $ERRORS{$state};

Garry W. Cook, CCNA
Network Infrastructure Manager
MACTEC, Inc. - http://www.mactec.com/
303.308.6228 (Office) - 720.220.1862 (Mobile)