From: <ct...@li...> - 2005-06-03 15:50:53
|
Hi, Fisrt i want to congratulate you for the great job you make. I want to submit you a little patch (based on version 0.105.6). It corrects little problems: - all of the tables were not dropped (scripts/mysql_delete.sql and scripts/postgresql_delete.sql files) - in modules/storage_mysql.c file, try to see if metric is in validated_services (it should be in validated_metrics) -----------%<------------- diff -Naur perfparse-0.105.6/modules/storage_mysql.c perfparse-0.105.6-p1/modules/storage_mysql.c --- perfparse-0.105.6/modules/storage_mysql.c 2005-01-12 11:24:56.000000000 +0100 +++ perfparse-0.105.6-p1/modules/storage_mysql.c 2005-06-03 17:01:59.000000000 +0200 @@ -469,7 +469,7 @@ /* Have we seen this one before? */ sprintf(sHash, "%100s:%45s:%45s", sMetric, sService, sHost); - iMetricID =3D g_tree_lookup(validated_services, sHash); + iMetricID =3D g_tree_lookup(validated_metrics, sHash); if (iMetricID) return *iMetricID; /* Does metric exist ? */ diff -Naur perfparse-0.105.6/scripts/mysql_delete.sql perfparse-0.105.6-p1/scripts/mysql_delete.sql --- perfparse-0.105.6/scripts/mysql_delete.sql 2005-01-01 01:41:54.000000000 +0100 +++ perfparse-0.105.6-p1/scripts/mysql_delete.sql 2005-05-30 14:39:30.000000000 +0200 @@ -19,5 +19,10 @@ DROP TABLE IF EXISTS perfdata_bin_summary_header; DROP TABLE IF EXISTS perfdata_bin_summary_data; DROP TABLE IF EXISTS perfdata_users; +DROP TABLE IF EXISTS perfdata_raw_summary; +DROP TABLE IF EXISTS perfdata_raw_summary_data; +DROP TABLE IF EXISTS perfdata_state; +DROP TABLE IF EXISTS perfdata_prefs; +DROP TABLE IF EXISTS perfdata_graphs; SET FOREIGN_KEY_CHECKS =3D 1; diff -Naur perfparse-0.105.6/scripts/postgresql_delete.sql perfparse-0.105.6-p1/scripts/postgresql_delete.sql --- perfparse-0.105.6/scripts/postgresql_delete.sql 2005-01-18 09:49:52.000000000 +0100 +++ perfparse-0.105.6-p1/scripts/postgresql_delete.sql 2005-06-03 17:39:58.228183411 +0200 @@ -10,7 +10,10 @@ DROP TABLE perfdata_host CASCADE; DROP TABLE perfdata_host_group CASCADE; DROP TABLE perfdata_delete_policy CASCADE; +DROP TABLE perfdata_state CASCADE; DROP TABLE perfdata_registry CASCADE; +DROP TABLE perfdata_prefs CASCADE; +DROP TABLE perfdata_graphs CASCADE; DROP TABLE perfdata_bin_summary_del_policy CASCADE; DROP TABLE perfdata_bin_summary CASCADE; DROP TABLE perfdata_bin_summary_header CASCADE; --------------%<--------------------------- Apply with patch -p0 < patch Regards, --=20 Temple C=E9dric - Linagora http://www.linagora.com 30, rue Saint Augustin 75002 Paris Cedex |