Re: [Perfparse-devel] storage_mysql.c in 101.1

[Yves M. <yme...@li...>]

> Hello,

Hello :)

> After upgrading to 101.1 I noticed that warning and critical lines
> weren't drawn. After investigating this a little, I found out that this
> data (critical and warning levels) wasn't even written to mysql.
>
> And as I found out, in storage_mysql.c in save_bin_data() function
> creation of INSERT query tried to insert wrong values there:
>
> - warn value from: perf->d[PERF_VALUE_WARN_START]
> - crit value from: perf->d[PERF_VALUE_CRIT_START]
>
> But these were always 0. PERF_VALUE_WARN_END and PERF_VALUE_CRIT_END
> contained correct values. Was this intentional and I missed something
> during upgrade, or was this bug?

This was already fixed in the development versions.

> To get this working correctly I had to add infinite value checking to
> getSafeD function also.

That was not fixed. You sent your mail few minutes before 0.102.1 release=
 and it will be
fixed in it.

> Just in case this was a bug I add patch also.

The changes in #ifdef DEBUG are not in 0.102 but I put them in the 0.103 =
development
branch.

Yves

>
> Best regards,
> Viljo
>
>


--=20
- Homepage    - http://ymettier.free.fr - http://www.logicacmg.com -
- GPG key     - http://ymettier.free.fr/gpg.txt                    -
- Maitretarot - http://www.nongnu.org/maitretarot/                 -
- Perfparse   - http://perfparse.sf.net/                           -