Re: [Perfparse-devel] Submitting work

[Ben C. <Ben...@ro...>]

Hi,

I saw my name mentioned eight times, let me add to this discussion :)

Love the code, nice work.

I totally agree about submitting patches.  There is a facility to do 
this on http://perfparse.sf.net.  I have not used this, but this might 
guarantee all of us can see the patch and gives you somewhere to post 
it.  If there are more than a few of us, might be time to us it.

In the future there will be development and live versions.  Right now I 
ask you to submit a new patch against each new release version until 
it's ready.  If you think this is a good idea!  Hopefully this will not 
be for too much time.

I think it may be too late for the current version.  I am in discussion 
with Yves about releasing over weekend.

Before this is included in the release version, we need to think about 
making the provided facilities concurrent with the existing services.

Let me list these below and we can comment on whether these are needed 
for release or can wait:

1/

We need to ensure that we have the control option on the parsing, to set 
whether the user gets this data or not.  On current methods, I suggest a:
	--no-raw-summary-data
Flag.

At the moment the single --no-raw-data flag will block both raw and raw 
summary. :)

2/

The deletion policies can wait a while.  After all, the point of these 
files is for long term storage.  But this must come at some time.

3/

You are using a fixed epoch of one day.  You comment about whether this 
is configurable.  If you decide it should be, we need a way of defining 
the used epochs, and delete those that are not needed any more.

4/

Reports.  Do you want any CGI reports?  Do you want to copy the ones 
that exist, or write your own, or would you like me to write them for 
you.  The final option may be the slowest :)

Anything else?

Anyway, busy time for me, I'll look over your code and make any coding 
comments directly with you.

Regards, Ben.




Yves Mettier wrote:

> Hi Tim,
> 
> 
> 
>>Hi,
>>
>>I've made some additions to storage_mysql.c to provide a summary table of
> 
> 
> Thanks for contributing :)
> I will let Ben accept or reject the patch after reviewing it.
> 
> 
>>And finally an important question: How do I submit my changes? I've never
>>used sourceforge (as a developer) before. For the moment, I just attached
>>the files to this email...
> 
> 
> I don't know if Ben uses sourceforge. I think that the best way is to :
> 1/ send a patch (not the full file)
> 2/ compress your patchs and files (with respect to those who still have low speed access
> to internet)
> 3/ describe what it does (you did it : good point :)
> 4/ add one line in ChangeLog : we are sure not to forget to add it. Don't forget to
> specify your initials :)
> 5/ add your name in the "Last Modified" line at the beginning. Without it, we consider
> that you give the copyright of your work to the author of the file
> 
> Well, that's a lot to think. If you do only 1/, 2/ and 3/, this is correct. 4/ and 5/
> are rather for you, not for the project :)
> 
> We prefer a patch because it's easier to
> - patch the current development version and not the current stable release :)
> - see the changes
> 
> OK, you asked and I gave you a full (but personnal) answer to your question :)
> 
> For both Ben and you :
> - I made the patch. Find it attached.
> - the coding style is the same as the rest. Very good.
> - the patch applies successfully on my latest development version
> (http://pagesperso.laposte.net/ymettier/perfparse-devel/)
> - I have not tried to understand what it does. Ben, you have to check that :)
> 
> I suggest that someone cat mysql_summary_raw.sql >> mysql_create.sql
> 
> And I don't think this will be accepted for next version because it is already ready and
> Ben can release it today evening if he has time.
> And there is something missing in your changes : perfparse-db-tool has to be updated to
> create your 2 new tables.
> 
> Maybe Ben will accept it for 0.102.2 or 0.103.1 ?
> 
> If Ben accepts, I can also accept next patches to include them in my development versions.
> Well, when perfparse-0.102.0ym5.tar.gz can be found on
> http://pagesperso.laposte.net/ymettier/perfparse-devel/, Ben can take it and release
> 0.102.1 :)
> 
> Yves
> 
> 
> 
>