Re: [Perfparse-devel] Submitting work

[Yves M. <yme...@li...>]

Hi Tim,


> Hi,
>
> I've made some additions to storage_mysql.c to provide a summary table =
of

Thanks for contributing :)
I will let Ben accept or reject the patch after reviewing it.

> And finally an important question: How do I submit my changes? I've nev=
er
> used sourceforge (as a developer) before. For the moment, I just attach=
ed
> the files to this email...

I don't know if Ben uses sourceforge. I think that the best way is to :
1/ send a patch (not the full file)
2/ compress your patchs and files (with respect to those who still have l=
ow speed access
to internet)
3/ describe what it does (you did it : good point :)
4/ add one line in ChangeLog : we are sure not to forget to add it. Don't=
 forget to
specify your initials :)
5/ add your name in the "Last Modified" line at the beginning. Without it=
, we consider
that you give the copyright of your work to the author of the file

Well, that's a lot to think. If you do only 1/, 2/ and 3/, this is correc=
t. 4/ and 5/
are rather for you, not for the project :)

We prefer a patch because it's easier to
- patch the current development version and not the current stable releas=
e :)
- see the changes

OK, you asked and I gave you a full (but personnal) answer to your questi=
on :)

For both Ben and you :
- I made the patch. Find it attached.
- the coding style is the same as the rest. Very good.
- the patch applies successfully on my latest development version
(http://pagesperso.laposte.net/ymettier/perfparse-devel/)
- I have not tried to understand what it does. Ben, you have to check tha=
t :)

I suggest that someone cat mysql_summary_raw.sql >> mysql_create.sql

And I don't think this will be accepted for next version because it is al=
ready ready and
Ben can release it today evening if he has time.
And there is something missing in your changes : perfparse-db-tool has to=
 be updated to
create your 2 new tables.

Maybe Ben will accept it for 0.102.2 or 0.103.1 ?

If Ben accepts, I can also accept next patches to include them in my deve=
lopment versions.
Well, when perfparse-0.102.0ym5.tar.gz can be found on
http://pagesperso.laposte.net/ymettier/perfparse-devel/, Ben can take it =
and release
0.102.1 :)

Yves




--=20
- Homepage    - http://ymettier.free.fr - http://www.logicacmg.com -
- GPG key     - http://ymettier.free.fr/gpg.txt                    -
- Maitretarot - http://www.nongnu.org/maitretarot/                 -
- Perfparse   - http://perfparse.sf.net/                           -