Re: [perfmon2] [PATCH 1/1] remove the pfm_spin_* macros
Status: Beta
Brought to you by:
seranian
From: Corey J A. <cja...@us...> - 2008-05-23 17:48:50
|
You can see them in the patch. I only removed the final sentence about modifying the macros. One of them is in __pfm_ctxswin_thread, and says: /* * we need to lock context because it could be accessed * from another CPU. Normally the schedule() functions * has masked interrupts which should be to * protect against PMU interrupts. If not then * pfm_spin_lock() can be overridden for each arch. */ - Corey "stephane eranian" <er...@go...> wrote on 05/23/2008 01:56:14 AM: > > Corey, > > On Thu, May 22, 2008 at 11:16 PM, Corey Ashford <cja...@us...> wrote: > > Hello, > > > > This patch removes the pfm_spin_* macros that were introduced to deal with > > soft interrupt disabling on the POWER architecture. Another solution is now > > being used to deal with soft disabling, so these macros are no longer > > needed. > > > > I didn't completely remove the comments that discuss masking, but I did > > remove the comments that say that the macros can be overridden per arch. > > > > Should I remove those comments completely? > > > Where are those comments? |