#468 Can't build with lazarus 1.8.0

[Luigi Baldoni]

After updating lazarus (although I'm not 100% positive on this), peazip 6.5.0
throws this error during the build, whatever interface is used:

/home/abuild/rpmbuild/BUILD/peazip-6.5.0.src/peach.pas(56709,22) Error: (5038) identifier idents no member "GetSelectedNodePath"
/home/abuild/rpmbuild/BUILD/peazip-6.5.0.src/peach.pas(58329,3) Warning: (5043) Symbol "CommandLine" is deprecated
/home/abuild/rpmbuild/BUILD/peazip-6.5.0.src/peach.pas(58357,3) Warning: (5043) Symbol "CommandLine" is deprecated
peach.pas(59426) Fatal: (10026) There were 1 errors compiling module, stopping
Fatal: (1018) Compilation aborted

[Delphi Temple]

You can't (re)compile Peazip with Lazarus v1.8.0.

Function GetSelectedNodePath (shellctrls.pas) doesn't exists anymore. I don't know, why this is removed, and may be necessary to add them manually (5 a 10 lines of code).

[Luigi Baldoni]

I see this in the Lazarus 1.4 changelog

r48302 TShellTreeView: deprecate function GetSelectedNodePath, since it's redundant. 

Any idea how it is redundant?

[Delphi Temple]

TShellTreeView vs TCutstomShellTreeView (<= used in Peazip)
I will take a look between the two of them.

[Luigi Baldoni]

I saw that. But I also see:

ShellTreeView1: TShellTreeView;
...
s:=ShellTreeView1.GetSelectedNodePath;

which looks like the opposite of what you said.

[Delphi Temple]

[Luigi Baldoni]

I dug up r48302 from svn and it says:

function  GetSelectedNodePath: string; deprecated 'Use property Path instead';

Which is what I do in the attached patch. What do you think?

[Giorgio Tani]

Thank you very much for taking time to track the issue, I'll test the patch for possible inclusion in next update.

[Delphi Temple]

I think, you can solve it by change GetSelectedNodePath in Path, and it compiles and works well.

[Giorgio Tani]

PeaZip 6.5.1 was recompiled with Lazarus 1.8.0
TShellTreeView Path was used in place of GetSelectedNodePath
TImageList Clear (which worked fine in 1.6.x) now has a glitch that prevents to correctly load icons for a TListView after the ImageList was cleared with Clear method, recoursive ImageList Delete was used instead, which works both with 1.6 and 1.8 versions.