#3 configure.in and makefile.am fixes

[Anonymous]

configure.in has this bit of code:
AC_ARG_WITH(x, build with X11 utilities, no_x=yes, no_x=no)
this incorrectly uses the AC_ARG_WITH macro ... the format of the
macro is this:
AC_ARG_WITH(package, help-text, [if-given], [if-not-given])
the logic currently assumes that the 3rd param is if configure is
given '--without-x' while the 4th param assumes that configure is
given '--with-x' ... the correct usage would be to detect *what* the
user gave via $withval in the 3rd param while the 4th param
specifies the default value (in this case, X will be enabled by default)
... if the variable was changed to 'use_x' instead of 'no_x' then
negation of the $withval would not be needed ... otherwise for the
3rd param you'll need something like this:
[ "$withval" == "yes" ] && no_x=no || no_x=yes
note that this is bash style and may not work well with sh ...

extra.mk has this bit of code:
$(INSTALL) -d $(prefix)/doc
it also runs many other install/rm commands on $(prefix) ... the
problem is that it does not prefix all paths with $(DESTDIR) ... if
you look through Makefile.in you will see that all operations on
$(prefix), $(bindir), etc... are of the form $(DESTDIR)$(prefix),
$(DESTDIR)$(bindir), etc...
so the correct form for extra.mk would be to prefix all paths with
$(DESTDIR) :)

my contact: vapier@gentoo.org