#2 PDM should not allow input that mkisofs cannot use

[Anonymous]

I chose a long 'out-core' ( -c option ) name when running the pdm.php script.

The relevant output is:

Do you want to proceed [Y]es/[n]o/[a]bort: Y
Creating DVD sets (mode: iso) in '/backup-temp'...
Preparing: [##################################################] 100.0%

Building index files...

I'm about to process DVD sets (mode 'iso') in '/backup-temp' directory

Do you want to proceed [Y]es/[n]o/[a]bort: ISO my-very-long-iso-filename-here-20100402_dvd01.iso: [##################################################] 100.0%

Operation done.
Cleaning up temporary data...
Cleaning: [##################################################] 100.0% ] 0.0%

Done.

I don't get an iso, nor do I get any error message.

I changed pdm.php to print the mkisofs command that was being invoked, commented out $do_clean so that pdm would not remove the files in the temporary directory, then ran the mkisofs command manually. The output was:

mkisofs: Volume ID string too long

It turns out that my version of mkisofs [ 2.01 (cpu-pc-linux-gnu) ] has a restriction of 32 characters for the Volume ID.

Accordingly, I suggest two options:

1. Applying a check in pdm.php to check the length of out-core and abort if the length is greater than 32 chars.
2. Alternatively (and this might be a better overall solution), print out stderr from mkisofs so that errors are silently discarded.

The second solution would also help in any case where mkisofs has somehow received invalid options, file sizes or file lists and will not proceed.