#41 fix t/fits.t to handle missing module cleanly

closed-accepted
nobody
Bugfix (30)
5
2006-03-17
2004-12-30
No

The FITS test program t/fits.t fails unless the
supposedly optional Astro::FITS::Header is installed.

One fix would be to add that to the list of required
modules and mod the main Makefile.PL to pull it in.

To keep required dependencies to a minimum, I fixed
t/fits.t to skip the failing tests. That results in
successful test results without a spurious failure.

I did not investigate the 79 skipped tests to determine
whether they could still be run. Since the tests will
run if you have Astro::FITS::Header installed, the worst
case is less test coverage than theoretically possible
when Astro::FITS::Header is not installed.

Discussion

  • Chris Marshall

    Chris Marshall - 2004-12-30

    fix test failure from missing Astro::FITS::Header

     
  • Craig DeForest

    Craig DeForest - 2006-03-17
    • status: open --> closed-accepted
     
  • Craig DeForest

    Craig DeForest - 2006-03-17

    Logged In: YES
    user_id=20200

    The patch was accepted and applied to the CVS sources.
    Thanks for helping out!

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks