#211 cpan autoinstall fails due to bad autoload.t test

critical
closed-fixed
nobody
other (94)
5
2009-05-08
2008-11-24
No

The autoloader test 3 (tilde expansion) compares the retrieved directory against getpwuid($>) rather than against getpwuid($<). This means that if the test is run under an effective uid (e.g. "sudo cpan PDL") it fails because the test is comparing the (correct) true-UID home directory to the (incorrect) effective-UID home directory.

This is not likely to be caught by developers who run the tests as themselves, but trips up automatic installation via a common path (cpan running as root).

Discussion

  • Chris Marshall

    Chris Marshall - 2008-11-24

    Thanks for figuring this one out. Did you patch the cvs?

     
  • Chris Marshall

    Chris Marshall - 2009-04-23

    Bug fixed in CVS.
    Thanks for reporting the problem!

     
  • Chris Marshall

    Chris Marshall - 2009-04-23
    • status: open --> pending-fixed
     
  • Chris Marshall

    Chris Marshall - 2009-04-23

    Thanks to the sharp eye of Craig, I've applied his suggested fix to t/autoload.t
    and will push it to PDL git once that comes online. A patch file is attached.

     
  • SourceForge Robot

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • SourceForge Robot

    • status: pending-fixed --> closed-fixed
     

Log in to post a comment.