#136 rfits bug with use strict

critical
closed-fixed
other (94)
5
2006-06-06
2006-04-06
No

With PDL 2.4.2 I get:

$x = rfits "ccd2001c1.fits"
Can't use string ("arc") as a HASH ref while "strict refs" in use at /Library/
Perl/5.8.6/darwin-thread-multi-2level/PDL/IO/FITS.pm line 410.

with a certain FITS file. Culprit is this FITS header keyword:

COMMENT = 'arc' / comment

I suspect this is an illegal FITS usage by Magellan instruments since
COMMENT has another use.

Anyway the fix is to remove the 'use strict' from FITS.pm

Is that OK????

Discussion

  • Tim Jenness

    Tim Jenness - 2006-04-06

    Logged In: YES
    user_id=23633

    Is this without Astro::FITS::Header? I don't think that removing strict checking is
    really going to fix the actual bug but at the very least can you use a localised 'no
    strict 'refs'' rather than removing strict checking completely?

     
  • Craig DeForest

    Craig DeForest - 2006-06-06

    Logged In: YES
    user_id=20200

    This appears to have been implemented -- there's a "no
    strict refs" line in the legacy parser block in CVS.

    I'm going to close this out, but if you have any more
    trouble, Karl, please hassle me about it.

    Cheers,
    Craig

     
  • Craig DeForest

    Craig DeForest - 2006-06-06
    • status: open --> closed-fixed
     
  • Karl Glazebrook

    Karl Glazebrook - 2006-06-06

    Logged In: YES
    user_id=1796

    Yes sorry I fixed in CVS but forgot to close it out. Did not help that sourceforge
    was playing silly buggers at the time.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks