Menu

#5 Fix for gcc43

open
nobody
None
5
2008-01-04
2008-01-04
kwizart
No

Here is a fix for preliminary gcc 4.3.0

Discussion

  • kwizart

    kwizart - 2008-01-04

    PerceptualDiff-1.0.1-gcc43

     
  • kwizart

    kwizart - 2008-01-04

    PerceptualDiff-1.0.1-gcc43-v2

     
  • kwizart

    kwizart - 2008-01-04

    Logged In: YES
    user_id=1683413
    Originator: YES

    File Added: PerceptualDiff-1.0.1-gcc43.patch

     
  • Chris Foster

    Chris Foster - 2008-01-12

    Logged In: YES
    user_id=1086736
    Originator: NO

    Hi kwizart, thanks a lot for the patch!

    However, I'd like to know why you put those includes in the *header* file? Isn't it sufficient to leave them in the file CompareArgs.cpp?
    It's generally good-practice to avoid pulling in extra headers inside a project header file if you can put them in the implementation file instead. (This reduces dependencies and total compile time.)

    When is gcc4.3 likely to be out?
    ~Chris.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.