From: Michal H. <ms...@gm...> - 2010-06-09 12:04:42
|
Hi Martin, I am trying to find out where do we change the text operator which represnts selected text in GUI. Could you help me with that please? Thanks -- Michal Hocko |
From: Martin P. <ma...@pe...> - 2010-06-13 02:45:51
|
On 9.6.2010 14:04, Michal Hocko wrote: > Hi Martin, > I am trying to find out where do we change the text operator which > represnts selected text in GUI. Could you help me with that please? You mean where is the code that changes the text if user selects some text and then edits the textbox? In callback.qs, function onTreeSelectionChange will call fillTextFromSelectedOperators(), which will retrieve text from operators - if all operators are text, the editbox is shown, otherwise it is hidden. fillTextFromSelectedOperators() function is declared in dialogs.qs If the text is changed, changeSelectedText() (declaration is right below the fillTextFromSelectedOperators function) is called which will remove all the text operators and reoplace them with one Tj operator with all the text setEditText/getEditText is functionm to set/retrieve the text in that text edit window Martin Petricek -- GPG/PGP Public key: http://www.petricek.net/petricm.pgp Fingerprint 6AA8 FFCE C061 1CB2 55F0 A1F3 3AA9 EB4F BD50 C1B8 /------------------------------------------------------------\ | WWW: http://www.petricek.net/ | \------------------------------------------------------------/ |
From: Michal H. <ms...@gm...> - 2010-06-14 12:50:07
|
On Sun, Jun 13, 2010 at 04:45:51AM +0200, Martin Petricek wrote: > On 9.6.2010 14:04, Michal Hocko wrote: > > Hi Martin, > > I am trying to find out where do we change the text operator which > > represnts selected text in GUI. Could you help me with that please? > > You mean where is the code that changes the text if user selects some text > and then edits the textbox? > > In callback.qs, function onTreeSelectionChange will call > fillTextFromSelectedOperators(), which will retrieve text from operators - > if all operators are text, the editbox is shown, otherwise it is hidden. > fillTextFromSelectedOperators() function is declared in dialogs.qs > > If the text is changed, changeSelectedText() (declaration is right below > the fillTextFromSelectedOperators function) is called which will remove all > the text operators and reoplace them with one Tj operator with all the text Thanks for clarification. I guess that I have to add createOperatorText (added by the last patch set) somewehere to gui/base.{cc,h} to make it visible to the scripting. Right? > > setEditText/getEditText is functionm to set/retrieve the text in that text > edit window > > Martin Petricek > > > -- > > > GPG/PGP Public key: http://www.petricek.net/petricm.pgp > Fingerprint 6AA8 FFCE C061 1CB2 55F0 A1F3 3AA9 EB4F BD50 C1B8 > /------------------------------------------------------------\ > | WWW: http://www.petricek.net/ | > \------------------------------------------------------------/ -- Michal Hocko |
From: Martin P. <ma...@pe...> - 2010-06-19 03:35:07
|
On 14.6.2010 14:49, Michal Hocko wrote: > On Sun, Jun 13, 2010 at 04:45:51AM +0200, Martin Petricek wrote: >> On 9.6.2010 14:04, Michal Hocko wrote: >>> Hi Martin, >>> I am trying to find out where do we change the text operator which >>> represnts selected text in GUI. Could you help me with that please? >> >> You mean where is the code that changes the text if user selects some text >> and then edits the textbox? >> >> In callback.qs, function onTreeSelectionChange will call >> fillTextFromSelectedOperators(), which will retrieve text from operators - >> if all operators are text, the editbox is shown, otherwise it is hidden. >> fillTextFromSelectedOperators() function is declared in dialogs.qs >> >> If the text is changed, changeSelectedText() (declaration is right below >> the fillTextFromSelectedOperators function) is called which will remove all >> the text operators and reoplace them with one Tj operator with all the text > > Thanks for clarification. > I guess that I have to add createOperatorText (added by the last patch > set) somewehere to gui/base.{cc,h} to make it visible to the scripting. > Right? Global functions come into gui/base.(cc|h), but I think we should rather make it in scripting a method of content stream, as it uses it's resources. So add it rather in qscontentstream.cc/qscontentstream.h - or I can add it there. Also, I noticed also helper createOperatorScale and createOperatorTranslation functions near createOperatorText, which exist there for some time. Should it be exposed to scripting too? Martin Petricek > >> >> setEditText/getEditText is functionm to set/retrieve the text in that text >> edit window >> >> Martin Petricek >> >> >> -- >> >> >> GPG/PGP Public key: http://www.petricek.net/petricm.pgp >> Fingerprint 6AA8 FFCE C061 1CB2 55F0 A1F3 3AA9 EB4F BD50 C1B8 >> /------------------------------------------------------------\ >> | WWW: http://www.petricek.net/ | >> \------------------------------------------------------------/ > -- GPG/PGP Public key: http://www.petricek.net/petricm.pgp Fingerprint 6AA8 FFCE C061 1CB2 55F0 A1F3 3AA9 EB4F BD50 C1B8 /------------------------------------------------------------\ | WWW: http://www.petricek.net/ | \------------------------------------------------------------/ |
From: Michal H. <ms...@gm...> - 2010-06-19 09:11:22
|
On Sat, Jun 19, 2010 at 05:34:59AM +0200, Martin Petricek wrote: > On 14.6.2010 14:49, Michal Hocko wrote: > > On Sun, Jun 13, 2010 at 04:45:51AM +0200, Martin Petricek wrote: > >> On 9.6.2010 14:04, Michal Hocko wrote: > >>> Hi Martin, > >>> I am trying to find out where do we change the text operator which > >>> represnts selected text in GUI. Could you help me with that please? > >> > >> You mean where is the code that changes the text if user selects some text > >> and then edits the textbox? > >> > >> In callback.qs, function onTreeSelectionChange will call > >> fillTextFromSelectedOperators(), which will retrieve text from operators - > >> if all operators are text, the editbox is shown, otherwise it is hidden. > >> fillTextFromSelectedOperators() function is declared in dialogs.qs > >> > >> If the text is changed, changeSelectedText() (declaration is right below > >> the fillTextFromSelectedOperators function) is called which will remove all > >> the text operators and reoplace them with one Tj operator with all the text > > > > Thanks for clarification. > > I guess that I have to add createOperatorText (added by the last patch > > set) somewehere to gui/base.{cc,h} to make it visible to the scripting. > > Right? > > Global functions come into gui/base.(cc|h), but I think we should rather > make it in scripting a method of content stream, as it uses it's resources. > > So add it rather in qscontentstream.cc/qscontentstream.h - or I can add it > there. OK. > > Also, I noticed also helper createOperatorScale and > createOperatorTranslation functions near createOperatorText, which exist > there for some time. Should it be exposed to scripting too? We need createOperatorText just for a correct text operator creation which is not the case for the other two helpers which are more convenient functions. Of course it would be nice to get rid of all duplications from scripting but I guess that this is out of scope at the moment. The new GUI shouldn't implement scripting the same way as it is done ATM, if it should contain scripting at all. The code we have now is far from being maintainable and the scripting itself never brought us a big win. There are no scripts flying on top of PDFedit which would add a new functionality. Currently we have only problems from it and I doubt that this will change with a new version of QSA. In short, it was a nice idea but it never worked as expected. > > Martin Petricek -- Michal Hocko |