From: Michal H. <ms...@gm...> - 2010-06-17 10:08:07
Attachments:
kernel-add-template-getProperty.patch
|
Hi Jozo, what do you think about the attached patch? It basically makes direct C{Array,Dict}::getProperty usage much easier without need for helper functions. See more in the patch description. If you ack this patch I will start working on the refactoring (remove all helpers which are not used much and replace them with getProperty and clean-up the code which does the casting without helpers). -- Michal Hocko |
From: Jozef M. <mis...@ho...> - 2010-06-17 10:13:52
|
ack, thx. > Hi Jozo, > what do you think about the attached patch? It basically makes direct > C{Array,Dict}::getProperty usage much easier without need for helper > functions. See more in the patch description. > If you ack this patch I will start working on the refactoring (remove > all helpers which are not used much and replace them with getProperty > and clean-up the code which does the casting without helpers). -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ |
From: Michal H. <ms...@gm...> - 2010-06-17 11:30:00
|
On Thu, Jun 17, 2010 at 12:13:37PM +0200, Jozef Misutka wrote: > ack, thx. Thanks for review. I have committed the updated patch from the other email. The refactoring patch will follow in some (hopefully) short time. I will be post it to the mailing list before committing of course. > > >Hi Jozo, > >what do you think about the attached patch? It basically makes direct > >C{Array,Dict}::getProperty usage much easier without need for helper > >functions. See more in the patch description. > >If you ack this patch I will start working on the refactoring (remove > >all helpers which are not used much and replace them with getProperty > >and clean-up the code which does the casting without helpers). > > > -- > Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ -- Michal Hocko |
From: Michal H. <ms...@gm...> - 2010-06-17 10:17:28
Attachments:
kernel-add-template-getProperty.patch
|
On Thu, Jun 17, 2010 at 12:07:58PM +0200, Michal Hocko wrote: > Hi Jozo, > what do you think about the attached patch? It basically makes direct > C{Array,Dict}::getProperty usage much easier without need for helper > functions. See more in the patch description. > If you ack this patch I will start working on the refactoring (remove > all helpers which are not used much and replace them with getProperty > and clean-up the code which does the casting without helpers). Hmm, the updated patch is attached. It just optimizes call to utils::getReferencedObject and adds an assert for the const char *name. -- Michal Hocko |