From: Gwurk <gw...@fi...> - 2008-01-29 02:40:38
|
Hi again, In cpage.cc, you use the default A4 rectangle for the CropBox if the CropBox is not specified. However, the CropBox should default to the MediaBox instead. (See section 3.6.2, subsection "Page Objects" in the PDF spec.) Can fillInheritedPageAttr() be changed to use a copy of the MediaBox for the CropBox if the CropBox isn't specified? Thanks! |
From: Michal H. <ms...@gm...> - 2008-01-29 09:03:39
Attachments:
crop_box-default.patch
|
On Mon, Jan 28, 2008 at 09:40:43PM -0500, Gwurk wrote: > Hi again, Hi. > > In cpage.cc, you use the default A4 rectangle for the CropBox if the > CropBox is not specified. However, the CropBox should default to the > MediaBox instead. (See section 3.6.2, subsection "Page Objects" in the > PDF spec.) You are right. I am not sure but I think that this function was done by me. I have checked specification down to version 1.3 and all of them states the same that default for crop box (if not present) is media box so don't understand the comment that specification is unclear in that way... > > Can fillInheritedPageAttr() be changed to use a copy of the MediaBox > for the CropBox if the CropBox isn't specified? See attached patch. Jozo, can you review and give it ack? > > Thanks! Thanks for reporting. -- Michal Hocko |
From: Jozef M. <mis...@ho...> - 2008-01-29 09:19:43
|
fine. just be sure tests work. =20 thanks gwurk, again :) > Date: Tue, 29 Jan 2008 10:03:34 +0100> From: ms...@gm...> To: gwurk= @figpost.com> CC: pdf...@li...; misutkajunior@hotmai= l.com> Subject: Re: CropBox should default to MediaBox if not specified> > = On Mon, Jan 28, 2008 at 09:40:43PM -0500, Gwurk wrote:> > Hi again,> > Hi.>= > > > > In cpage.cc, you use the default A4 rectangle for the CropBox if t= he> > CropBox is not specified. However, the CropBox should default to the>= > MediaBox instead. (See section 3.6.2, subsection "Page Objects" in the> = > PDF spec.)> > You are right. I am not sure but I think that this function= was done by> me. I have checked specification down to version 1.3 and all = of them> states the same that default for crop box (if not present) is medi= a box> so don't understand the comment that specification is unclear in tha= t> way...> > > > > Can fillInheritedPageAttr() be changed to use a copy of = the MediaBox> > for the CropBox if the CropBox isn't specified?> > See atta= ched patch.> Jozo, can you review and give it ack?> > > > > Thanks!> > Than= ks for reporting.> > -- > Michal Hocko _________________________________________________________________ Need to know the score, the latest news, or you need your Hotmail=AE-get yo= ur "fix". http://www.msnmobilefix.com/Default.aspx= |