Menu
▾
▴
pdbsql-devel — Development list
You can subscribe to this list here.
| 2006 |
Jan
|
Feb
(46) |
Mar
(78) |
Apr
(39) |
May
(36) |
Jun
(19) |
Jul
(14) |
Aug
(29) |
Sep
(7) |
Oct
(7) |
Nov
(8) |
Dec
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2007 |
Jan
(2) |
Feb
|
Mar
(3) |
Apr
(5) |
May
|
Jun
(3) |
Jul
(1) |
Aug
(1) |
Sep
|
Oct
|
Nov
(1) |
Dec
|
| 2008 |
Jan
(4) |
Feb
|
Mar
|
Apr
(1) |
May
(3) |
Jun
(2) |
Jul
(17) |
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
|
| 2010 |
Jan
(1) |
Feb
(1) |
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: SourceForge.net <no...@so...> - 2010-02-21 21:06:30
|
Bugs item #2956188, was opened at 2010-02-21 15:06 Message generated for change (Tracker Item Submitted) made by gary_mills You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=814157&aid=2956188&group_id=160018 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: pdb_sql (or both) Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Gary Mills (gary_mills) Assigned to: Nobody/Anonymous (nobody) Summary: pdbsql-0.3.1 will not compile with samba-3.4.3 Initial Comment: An attempt to compile pdbsql-0.3.1 with samba-3.4.3 results in errors like this: cc -g -I/usr/local/mysql/include/mysql -YP,/usr/ccs/lib:/usr/lib -xO4 -xstrconst -mt -I../samba-3.4.3/source3 -I../samba-3.4.3/source3/include -I../samba-3.4.3/source3/ubiqx -I../samba-3.4.3/source3/popt -I../samba-3.4.3/source3/lib/replace -I../samba-3.4.3/source3/tdb/include -I../samba-3.4.3/source3/librpc -fPIC -c pdb_multi.c "../samba-3.4.3/source3/include/includes.h", line 28: cannot find include file: "../replace/replace.h" "../samba-3.4.3/source3/include/includes.h", line 33: #error: "make sure you have removed all config.h files from standalone builds!" cc: acomp failed for pdb_multi.c gmake: *** [pdb_multi.o] Error 2 With attached patches it compiles and permits a domain login with a Windows XP Pro client. Most of the changes are to accomodate the different source layout and changed symbols in samba-3.4.3. Changed .c files should compile with older samba versions, but changes to Makefile.in are specific to samba-3.4.3. Somebody who understands configure will need to arrange for it to generate a Makefile.in for each samba version. I'd also appreciate it if a few other people could test this patched version of pdbsql-0.3.1. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=814157&aid=2956188&group_id=160018 |
|
From: SourceForge.net <no...@so...> - 2010-01-01 03:10:38
|
Bugs item #2924381, was opened at 2009-12-31 21:10 Message generated for change (Tracker Item Submitted) made by gary_mills You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=814157&aid=2924381&group_id=160018 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: pdb_sql (or both) Group: current Status: Open Resolution: None Priority: 5 Private: No Submitted By: Gary Mills (gary_mills) Assigned to: Nobody/Anonymous (nobody) Summary: Build fails with Sun compiler Initial Comment: I just built pdbsql-0.3.1-samba for use with samba-3.0.37. Initially, the build failed with this error: cc -Wall -g -I/usr/local/mysql/include/mysql -YP,/usr/ccs/lib:/usr/lib -xO4 -xstrconst -mt -I../samba-3.0.37/source -I../samba-3.0.37/source/include -I../samba-3.0.37/source/ubiqx -I../samba-3.0.37/source/popt -I../samba-3.0.37/source/lib/replace -I../samba-3.0.37/source/tdb/include -I../samba-3.0.37/source/librpc -fPIC -c pdb_multi.c cc: illegal option -Wall gmake: *** [pdb_multi.o] Error 1 The cause is the `-Wall' option in Makefile.in that only works with the gcc compiler. I just removed it, which is correct for the Sun compiler. The correct fix is to obtain compiler options from the configure script. Here's how I invoke configure: #!/bin/sh # Built on Solaris 9 for samba-3.0.37 # Mysql support is now in an external module # expects mysql-4.0.18 in /usr/local/mysql PATH=/opt/SUNWspro/bin:/usr/bin:/usr/ccs/bin:/usr/sbin; export PATH env CC=cc \ INSTALL=/usr/ucb/install \ ./configure \ --prefix=/usr/local/samba \ --with-mandir=/usr/local/share/man \ --with-samba-dir=../samba-3.0.37 \ --with-mysql-prefix=/usr/local/mysql #!/end ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=814157&aid=2924381&group_id=160018 |
|
From: Collen B. <co...@he...> - 2008-08-11 22:16:37
|
hi all.... sorry for all the svn post's i did some rearranging of the svn, and turned out that not all was standing correctly. also the 0.3.1 release is put in the tags dir.. so, we're fresh again, for the next development... Cheers, Collen |
|
From: Collen B. <co...@he...> - 2008-07-30 13:07:00
|
Hello All, we're proud to announce the release candidate for samba 3.2.x systems please report anny problems or bugs, so we can make this version final.!!! notes: ------ - pdbsql_32 will be gplv3 - should be working with samba 3.2.x only (for older samba versions, look at the other releases!) Cheers, Collen |
|
From: Herwin W. <he...@sn...> - 2008-07-28 18:16:39
|
> Cheers, I'll see if i can release a rc for the pdbsql_32 > shall we stick with the version numbering as it is ?? (0.4) > or shall we do something different, coz this one only works > with the new samba 3.2.x Because we aren't adding new features but only working on compatibility issues with newer Samba releases I would say it's better to number the release to the lowest samba version it works with, so next release would be 3.2.0. Might sound like a very big leap forward, but hey, microsoft once jumped from 3.11 to 95 ;) Herwin |
|
From: Herwin W. <he...@sn...> - 2008-07-25 16:21:35
|
> i did test too day, and all seems to be ok > accept for pdbedit -L > this one still returns users and machines ?? > i did not test against ldap and tdbsam, so i can't tell > if it's pdbsql problem or not. That's just the behaviour of pdbedit, in the source there's still a comment `TODO: chaeck if entry is a user or a workstation' Herwin |
|
From: Jelmer V. <je...@sa...> - 2008-07-21 23:16:39
|
Am Montag, den 21.07.2008, 22:51 +0200 schrieb Collen Blijenberg: > the gplv3 thing. > all i was wondering about, is if the two (v2 and v3) > where compatible. > i did read the 2, but as i said law and license aren't my thing (-: > > i'd rather stick with gplv2, coz' i know that one. > and i don't know what gplv3 means in every day's life. ?! > > Cheers, I'll see if i can release a rc for the pdbsql_32 > shall we stick with the version numbering as it is ?? (0.4) > or shall we do something different, coz this one only works > with the new samba 3.2.x you'll need the GPLv3 for pdbsql since Samba 3.2 is under the GPLv3 or later as well. Licensing it under the GPLv2 would make it impossible to distribute pdbsql since it's incompatible with the license of Samba. Cheers, Jelmer > > >> with this fix, the users and computers should be split again. > >> just curious, what does the 'acct_flags' hold ?? > >> or in better words, what does it do ?? > > > > The account flags store the information on what type of account we're > > dealing with. When you run a `pdbedit -v herwin` on my computer you get > > the output `Account flags: [UX ]', which mean I'm a user (U) and my > > password does not expire (X). > > Internally this is not stored as a string, but as an unsigned 32-bit > > integer, where all bits can be seen as on/off-switches. The values of > > the bits can be found in librpc/gen_ndr/samr.h. My UX is actually > > ACB_PWNOEXP | ACB_NORMAL = 528 (| means binary or, try googling for c > > bitwise operators). A random workstation will have the value ACB_WSTRUST > > (128), which gives us the string [W ]. > > > > The functions net_sam_list_users and net_sam_list_workstations > > (utils/net_sam.c) call the pdb_search_users with respectively the > > acct_flags ACB_NORMAL and ACB_WSTRUST, which means we only want to see > > the results that match the full bitmask provided by us (we could call > > pdb_search_users(ACB_PWNOEXP | ACB_NORMAL) to match only the users with > > passwords that do not expire if we would). The bitmask is then fed to > > the _next_user function of our plugin, and there it needs to check the > > user to see if the bitmask matches the given pattern: only return a user > > if it matches. > > > > Regards, > > > > Herwin > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's > > challenge > > Build the coolest Linux based applications with Moblin SDK & win great > > prizes > > Grand prize is a trip for two to an Open Source event anywhere in the > > world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ -- Jelmer Vernooij <je...@sa...> - http://samba.org/~jelmer/ Jabber: je...@ja... |
|
From: Collen B. <co...@he...> - 2008-07-21 20:14:27
|
Hi, Thx i knew about the acct_ctrl and all but didn't knew how they were stored or accessed always nice to learn new things. (-: i did test too day, and all seems to be ok accept for pdbedit -L this one still returns users and machines ?? i did not test against ldap and tdbsam, so i can't tell if it's pdbsql problem or not. the gplv3 thing. all i was wondering about, is if the two (v2 and v3) where compatible. i did read the 2, but as i said law and license aren't my thing (-: i'd rather stick with gplv2, coz' i know that one. and i don't know what gplv3 means in every day's life. ?! Cheers, I'll see if i can release a rc for the pdbsql_32 shall we stick with the version numbering as it is ?? (0.4) or shall we do something different, coz this one only works with the new samba 3.2.x Greetz, Collen >> with this fix, the users and computers should be split again. >> just curious, what does the 'acct_flags' hold ?? >> or in better words, what does it do ?? > > The account flags store the information on what type of account we're > dealing with. When you run a `pdbedit -v herwin` on my computer you get > the output `Account flags: [UX ]', which mean I'm a user (U) and my > password does not expire (X). > Internally this is not stored as a string, but as an unsigned 32-bit > integer, where all bits can be seen as on/off-switches. The values of > the bits can be found in librpc/gen_ndr/samr.h. My UX is actually > ACB_PWNOEXP | ACB_NORMAL = 528 (| means binary or, try googling for c > bitwise operators). A random workstation will have the value ACB_WSTRUST > (128), which gives us the string [W ]. > > The functions net_sam_list_users and net_sam_list_workstations > (utils/net_sam.c) call the pdb_search_users with respectively the > acct_flags ACB_NORMAL and ACB_WSTRUST, which means we only want to see > the results that match the full bitmask provided by us (we could call > pdb_search_users(ACB_PWNOEXP | ACB_NORMAL) to match only the users with > passwords that do not expire if we would). The bitmask is then fed to > the _next_user function of our plugin, and there it needs to check the > user to see if the bitmask matches the given pattern: only return a user > if it matches. > > Regards, > > Herwin > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the > world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > |
|
From: Herwin W. <he...@sn...> - 2008-07-21 19:18:38
|
> with this fix, the users and computers should be split again. > just curious, what does the 'acct_flags' hold ?? > or in better words, what does it do ?? The account flags store the information on what type of account we're dealing with. When you run a `pdbedit -v herwin` on my computer you get the output `Account flags: [UX ]', which mean I'm a user (U) and my password does not expire (X). Internally this is not stored as a string, but as an unsigned 32-bit integer, where all bits can be seen as on/off-switches. The values of the bits can be found in librpc/gen_ndr/samr.h. My UX is actually ACB_PWNOEXP | ACB_NORMAL = 528 (| means binary or, try googling for c bitwise operators). A random workstation will have the value ACB_WSTRUST (128), which gives us the string [W ]. The functions net_sam_list_users and net_sam_list_workstations (utils/net_sam.c) call the pdb_search_users with respectively the acct_flags ACB_NORMAL and ACB_WSTRUST, which means we only want to see the results that match the full bitmask provided by us (we could call pdb_search_users(ACB_PWNOEXP | ACB_NORMAL) to match only the users with passwords that do not expire if we would). The bitmask is then fed to the _next_user function of our plugin, and there it needs to check the user to see if the bitmask matches the given pattern: only return a user if it matches. Regards, Herwin |
|
From: Collen B. <co...@he...> - 2008-07-19 19:19:06
|
Hiya Herwin, Got my test rig up and running ok again. (remember the net user prob's) i did manage to test the pre-r133 version last friday and all seems quite right again could even use the usermanager from nt4 again with this fix, the users and computers should be split again. just curious, what does the 'acct_flags' hold ?? or in better words, what does it do ?? Thx for your good work. on Monday i'll be starting to work on the project again. Cheers, Collen > Actually I was using the wrong approach, the check is added in revision > 133 and fixed in r134. (The account flags filter is passed to the > _search_users function, and should be checked in either the preparation > in _search_users or skip the result in _next_entry). > > > On Fri, Jul 18, 2008 at 01:05:04PM +0200, Collen Blijenberg wrote: >> Hmm, odd >> >> could find it in smbpasswd.c ?! >> but how does tdbsam and others do it. >> >> still got some problems with samba 3.2.0 >> but i also got them with tdbsam and ldap, so it's samba related >> >> one other thing is that there might be a problem with the $ filter >> - net sam list users >> - net sam list workstations >> both uses the search user function, so that might trouble. >> >> Cheers >> >> Collen >> >> >> Herwin Weststrate wrote: >> >I guess we want to fix the users/computers mixup first, I wouldn't be >> >surprised if it would give some really strange errors when using samba >> >as a domain controller. Easiest workaround is to check the last >> >character of the name equals a dollar-sign (same hack is used in in the >> >smbpasswd module). I guess that once this works we can call it a RC. >> > >> >Herwin >> > >> >On Wed, Jul 16, 2008 at 11:03:31PM +0200, Collen Blijenberg wrote: >> > >> >>Hi, >> >> >> >>just tested against fedora 9. >> >>looks all fine, accept that i still get a time out error >> >>with './net user' >> >>but on the other hand, i also get it when using ldap as backend (-: >> >>so my guess is that i have some sort of firewall problem. >> >> >> >>nice work. i'll see if i can release a beta or a rc >> >>unless there are some cons or other things i forgot ?! >> >> >> >>Cheers, Collen >> >> >> >> >> >> >> >> >> >>>I just upgraded my samba from 3.2.0~rc2 to 3.2.0-2 (both debian >> >>>versions), and suddenly the `net user` works again for both mysql and >> >>>postgresql now. If someone could test this against the vanilla source >> of >> >>>samba, it would be great. >> >>>Only problem left is the users/workstations mixup in the lists. >> >>> >> >>> >> >>>Regards, Herwin >> >>> >> >>>On Fri, Jul 11, 2008 at 04:10:22PM +0200, Collen Blijenberg wrote: >> >>> >> >>>>Hi, i see what you mean. >> >>>> >> >>>>i fixed a little part for mysql (see svn) >> >>>>the "net sam list user" works again, but "net user" doesn't (but the >> >>>>core dumps are gone) >> >>>> >> >>>>still to struggle with: >> >>>> >> >>>>net user -> still no good. >> >>>>listing users also spit out the workstations accounts ?!?!? >> >>>>listing worksttions also spit out users (makes sense) >> >>>> >> >>>>so far so good.... >> >>>>little steps but where getting there. >> >>>> >> >>>>hope you'll get more out of it this weekend.. >> >>>> >> >>>>Cheers, Collen >> >>>> >> >>>> >> >>>>Herwin Weststrate wrote: >> >>>> >> >>>>>I guess the bugs are caused by the lazy filling of the entry >> struct: >> >>>>>when using the command `pdbedit -L' only the sid is read, probably >> the >> >>>>>other parts of the structure are used in this command (see my >> comments >> >>>>>on line 508-511 in the pdb_pgsql.c file). Currently these are not >> >>>>>initialized whatsoever, so that might cause the segfaults. >> >>>>>I won't have time until the weekend to have a look at it, if >> someone >> >>>>>would be able to check this (just filling the struct with some >> phony >> >>>>>values would be enough), I'd like to hear the results of it. >> >>>>> >> >>>>>Herwin >> >>>>> >> >>>>>Collen Blijenberg wrote: >> >>>>> >> >>>>> >> >>>>>>Well, here are the test results of the dutch jury (-: >> >>>>>> >> >>>>>>looks good (also cleaned up the svn code) >> >>>>>> >> >>>>>>bugs found: >> >>>>>> >> >>>>>>- net user -> seg. fault + core dump >> >>>>>>- user manager (windows) -> can't exec RPC + core dump >> >>>>>>- net sam list users -> strange sighs like (like -?_) >> >>>>>>- net sam list workstations -> dido strange signs. >> >>>>>> >> >>>>>>pdbedit -L works just fine... >> >>>>>>so we're getting there... thx. >> >>>>>> >> >>>>>>dunno if these faults are related to our module or to samba, but >> my >> >>>>>>guess is the module.. >> >>>>>>have fun... >> >>>>>> >> >>>>>>Collen. >> >>>>>> >> >>>>>> >> >>>>>>Collen Blijenberg wrote: >> >>>>>> >> >>>>>> >> >>>>>>>Oeh, excellent Herwin, >> >>>>>>> >> >>>>>>>i saw you did mysql also... ! thx >> >>>>>>>we were busy with it last Friday, but did come to a sollution on >> the >> >>>>>>>search_users thing. >> >>>>>>>also good notice of the init_module. now both will work. >> >>>>>>> >> >>>>>>>i'll down the svn to see the thing in action (-: >> >>>>>>> >> >>>>>>>- the table name, don't think it's much of a problem, 2 different >> >>>>>>> >> >>>>names. >> >>>> >> >>>>>>> so I'll suggest to leave it as it is. but must say users has my >> >>>>>>> >> >>>>pref. >> >>>> >> >>>>>>>- sure upcase the true/false statements.. no worry here. (and >> looks >> >>>>>>>nicer) >> >>>>>>>- there hasn't been done mutch work on the pgsql module, maybe we >> >>>>>>>simply forgot to alter it ?! >> >>>>>>> >> >>>>>>>Thx, i'll get back on it as soon as i test all kind of things.... >> >>>>>>> >> >>>>>>>Cheers, nice work!! >> >>>>>>> >> >>>>>>>Collen. >> >>>>>>> >> >>>>>>>Herwin Weststrate wrote: >> >>>>>>> >> >>>>>>> >> >>>>>>>>On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg >> wrote: >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> >> >>>>>>>>>[...] >> >>>>>>>>>still need to figure out: >> >>>>>>>>> >> >>>>>>>>>- enumeration on users (seems that it's no longer there with >> samba >> >>>>>>>>>3.2) >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind >> of >> >>>>>>>>iteration-mechanism to retreive the userlist, see the >> >>>>>>>>pgsqlsam_search_user function to see how it works. >> >>>>>>>> >> >>>>>>>>While working on it I noticed a number of things that were a >> little >> >>>>>>>> >> >>>>bit >> >>>> >> >>>>>>>>unlogical: >> >>>>>>>>- The mysql table defaults to `user', the postgres table to >> `users'. >> >>>>>>>> Probably because `user' is a keyword in postgres. This kind of >> >>>>>>>> inconsistency makes it hell to migrate to another database. I'd >> >>>>>>>> propose to use the names that work on both databases as a >> default, >> >>>>>>>> >> >>>>so >> >>>> >> >>>>>>>> the usertable should be called `users', the new grouptable >> should >> >>>>>>>> >> >>>>be >> >>>> >> >>>>>>>> called `groups' and the column with the name of the group >> should >> >>>>>>>> >> >>>>be >> >>>> >> >>>>>>>> called `groupname'. (Groups are added in Samba 3.2.0) >> >>>>>>>>- In the pdb_pgsql.c file I've counted three occurences of the >> >>>>>>>> >> >>>>`execute >> >>>> >> >>>>>>>> query, check results, print warnings if erorr'-session (line >> >>>>>>>> >> >>>>358-369, >> >>>> >> >>>>>>>> 470-479, 524-533) and without looking at the source I guess the >> >>>>>>>> >> >>>>mysql >> >>>> >> >>>>>>>> version is not much different. A simple function that accepts a >> >>>>>>>> string, tries to run the query, DEBUG and return NULL if error, >> >>>>>>>> >> >>>>return >> >>>> >> >>>>>>>> result pointer would be nicer, it saves some code-copy-paste. >> >>>>>>>>- The names True/true and False/false are both valid and both in >> use >> >>>>>>>> >> >>>>and >> >>>> >> >>>>>>>> sometimes mixed, but this problem also exists in the original >> >>>>>>>> >> >>>>source >> >>>> >> >>>>>>>> (take a look at pdb_smbpasswd). As long as there's no >> ``official'' >> >>>>>>>> Samba standard for this I'd propose to use the uppercased names >> >>>>>>>> >> >>>>(True >> >>>> >> >>>>>>>> and False). >> >>>>>>>> >> >>>>>>>>Any comments on these proposals? >> >>>>>>>> >> >>>>>>>>Regards, Herwin >> >>>>>>>> >> >>>>>>>>------------------------------------------------------------------------- >> >>>>>>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> >>>>>>>>Studies have shown that voting for your favorite open source >> >>>>>>>> >> >>>>project, >> >>>> >> >>>>>>>>along with a healthy diet, reduces your potential for chronic >> >>>>>>>> >> >>>>lameness >> >>>> >> >>>>>>>>and boredom. Vote Now at >> http://www.sourceforge.net/community/cca08 >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> >> >>>>>>>------------------------------------------------------------------------ >> >>>>>>> >> >>>>>>>------------------------------------------------------------------------- >> >>>>>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> >>>>>>>Studies have shown that voting for your favorite open source >> project, >> >>>>>>>along with a healthy diet, reduces your potential for chronic >> >>>>>>> >> >>>>lameness >> >>>> >> >>>>>>>and boredom. Vote Now at >> http://www.sourceforge.net/community/cca08 >> >>>>>>> >> >>>>>>> >> >>>>>>------------------------------------------------------------------------ >> >>>>>> >> >>>>>>------------------------------------------------------------------------- >> >>>>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> >>>>>>Studies have shown that voting for your favorite open source >> project, >> >>>>>>along with a healthy diet, reduces your potential for chronic >> lameness >> >>>>>>and boredom. Vote Now at >> http://www.sourceforge.net/community/cca08 >> >>>>>> >> >>>>>> >> >>>>>------------------------------------------------------------------------- >> >>>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> >>>>>Studies have shown that voting for your favorite open source >> project, >> >>>>>along with a healthy diet, reduces your potential for chronic >> lameness >> >>>>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> >>>>> >> >>>>> >> >>>>------------------------------------------------------------------------- >> >>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> >>>>Studies have shown that voting for your favorite open source >> project, >> >>>>along with a healthy diet, reduces your potential for chronic >> lameness >> >>>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> >>>> >> >>>------------------------------------------------------------------------- >> >>>This SF.Net email is sponsored by the Moblin Your Move Developer's >> >>>challenge >> >>>Build the coolest Linux based applications with Moblin SDK & win >> great >> >>>prizes >> >>>Grand prize is a trip for two to an Open Source event anywhere in the >> >>>world >> >>>http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> >>> >> >>> >> >> >> >>------------------------------------------------------------------------- >> >>This SF.Net email is sponsored by the Moblin Your Move Developer's >> >>challenge >> >>Build the coolest Linux based applications with Moblin SDK & win great >> >>prizes >> >>Grand prize is a trip for two to an Open Source event anywhere in the >> >>world >> >>http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> >> >> >> >> > >> >------------------------------------------------------------------------- >> >This SF.Net email is sponsored by the Moblin Your Move Developer's >> >challenge >> >Build the coolest Linux based applications with Moblin SDK & win great >> >prizes >> >Grand prize is a trip for two to an Open Source event anywhere in the >> world >> >http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> > > >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's >> challenge >> Build the coolest Linux based applications with Moblin SDK & win great >> prizes >> Grand prize is a trip for two to an Open Source event anywhere in the >> world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the > world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > |
|
From: Herwin W. <he...@sn...> - 2008-07-18 20:26:16
|
Actually I was using the wrong approach, the check is added in revision 133 and fixed in r134. (The account flags filter is passed to the _search_users function, and should be checked in either the preparation in _search_users or skip the result in _next_entry). On Fri, Jul 18, 2008 at 01:05:04PM +0200, Collen Blijenberg wrote: > Hmm, odd > > could find it in smbpasswd.c ?! > but how does tdbsam and others do it. > > still got some problems with samba 3.2.0 > but i also got them with tdbsam and ldap, so it's samba related > > one other thing is that there might be a problem with the $ filter > - net sam list users > - net sam list workstations > both uses the search user function, so that might trouble. > > Cheers > > Collen > > > Herwin Weststrate wrote: > >I guess we want to fix the users/computers mixup first, I wouldn't be > >surprised if it would give some really strange errors when using samba > >as a domain controller. Easiest workaround is to check the last > >character of the name equals a dollar-sign (same hack is used in in the > >smbpasswd module). I guess that once this works we can call it a RC. > > > >Herwin > > > >On Wed, Jul 16, 2008 at 11:03:31PM +0200, Collen Blijenberg wrote: > > > >>Hi, > >> > >>just tested against fedora 9. > >>looks all fine, accept that i still get a time out error > >>with './net user' > >>but on the other hand, i also get it when using ldap as backend (-: > >>so my guess is that i have some sort of firewall problem. > >> > >>nice work. i'll see if i can release a beta or a rc > >>unless there are some cons or other things i forgot ?! > >> > >>Cheers, Collen > >> > >> > >> > >> > >>>I just upgraded my samba from 3.2.0~rc2 to 3.2.0-2 (both debian > >>>versions), and suddenly the `net user` works again for both mysql and > >>>postgresql now. If someone could test this against the vanilla source of > >>>samba, it would be great. > >>>Only problem left is the users/workstations mixup in the lists. > >>> > >>> > >>>Regards, Herwin > >>> > >>>On Fri, Jul 11, 2008 at 04:10:22PM +0200, Collen Blijenberg wrote: > >>> > >>>>Hi, i see what you mean. > >>>> > >>>>i fixed a little part for mysql (see svn) > >>>>the "net sam list user" works again, but "net user" doesn't (but the > >>>>core dumps are gone) > >>>> > >>>>still to struggle with: > >>>> > >>>>net user -> still no good. > >>>>listing users also spit out the workstations accounts ?!?!? > >>>>listing worksttions also spit out users (makes sense) > >>>> > >>>>so far so good.... > >>>>little steps but where getting there. > >>>> > >>>>hope you'll get more out of it this weekend.. > >>>> > >>>>Cheers, Collen > >>>> > >>>> > >>>>Herwin Weststrate wrote: > >>>> > >>>>>I guess the bugs are caused by the lazy filling of the entry struct: > >>>>>when using the command `pdbedit -L' only the sid is read, probably the > >>>>>other parts of the structure are used in this command (see my comments > >>>>>on line 508-511 in the pdb_pgsql.c file). Currently these are not > >>>>>initialized whatsoever, so that might cause the segfaults. > >>>>>I won't have time until the weekend to have a look at it, if someone > >>>>>would be able to check this (just filling the struct with some phony > >>>>>values would be enough), I'd like to hear the results of it. > >>>>> > >>>>>Herwin > >>>>> > >>>>>Collen Blijenberg wrote: > >>>>> > >>>>> > >>>>>>Well, here are the test results of the dutch jury (-: > >>>>>> > >>>>>>looks good (also cleaned up the svn code) > >>>>>> > >>>>>>bugs found: > >>>>>> > >>>>>>- net user -> seg. fault + core dump > >>>>>>- user manager (windows) -> can't exec RPC + core dump > >>>>>>- net sam list users -> strange sighs like (like -?_) > >>>>>>- net sam list workstations -> dido strange signs. > >>>>>> > >>>>>>pdbedit -L works just fine... > >>>>>>so we're getting there... thx. > >>>>>> > >>>>>>dunno if these faults are related to our module or to samba, but my > >>>>>>guess is the module.. > >>>>>>have fun... > >>>>>> > >>>>>>Collen. > >>>>>> > >>>>>> > >>>>>>Collen Blijenberg wrote: > >>>>>> > >>>>>> > >>>>>>>Oeh, excellent Herwin, > >>>>>>> > >>>>>>>i saw you did mysql also... ! thx > >>>>>>>we were busy with it last Friday, but did come to a sollution on the > >>>>>>>search_users thing. > >>>>>>>also good notice of the init_module. now both will work. > >>>>>>> > >>>>>>>i'll down the svn to see the thing in action (-: > >>>>>>> > >>>>>>>- the table name, don't think it's much of a problem, 2 different > >>>>>>> > >>>>names. > >>>> > >>>>>>> so I'll suggest to leave it as it is. but must say users has my > >>>>>>> > >>>>pref. > >>>> > >>>>>>>- sure upcase the true/false statements.. no worry here. (and looks > >>>>>>>nicer) > >>>>>>>- there hasn't been done mutch work on the pgsql module, maybe we > >>>>>>>simply forgot to alter it ?! > >>>>>>> > >>>>>>>Thx, i'll get back on it as soon as i test all kind of things.... > >>>>>>> > >>>>>>>Cheers, nice work!! > >>>>>>> > >>>>>>>Collen. > >>>>>>> > >>>>>>>Herwin Weststrate wrote: > >>>>>>> > >>>>>>> > >>>>>>>>On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg wrote: > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>>>[...] > >>>>>>>>>still need to figure out: > >>>>>>>>> > >>>>>>>>>- enumeration on users (seems that it's no longer there with samba > >>>>>>>>>3.2) > >>>>>>>>> > >>>>>>>>> > >>>>>>>>I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind of > >>>>>>>>iteration-mechanism to retreive the userlist, see the > >>>>>>>>pgsqlsam_search_user function to see how it works. > >>>>>>>> > >>>>>>>>While working on it I noticed a number of things that were a little > >>>>>>>> > >>>>bit > >>>> > >>>>>>>>unlogical: > >>>>>>>>- The mysql table defaults to `user', the postgres table to `users'. > >>>>>>>> Probably because `user' is a keyword in postgres. This kind of > >>>>>>>> inconsistency makes it hell to migrate to another database. I'd > >>>>>>>> propose to use the names that work on both databases as a default, > >>>>>>>> > >>>>so > >>>> > >>>>>>>> the usertable should be called `users', the new grouptable should > >>>>>>>> > >>>>be > >>>> > >>>>>>>> called `groups' and the column with the name of the group should > >>>>>>>> > >>>>be > >>>> > >>>>>>>> called `groupname'. (Groups are added in Samba 3.2.0) > >>>>>>>>- In the pdb_pgsql.c file I've counted three occurences of the > >>>>>>>> > >>>>`execute > >>>> > >>>>>>>> query, check results, print warnings if erorr'-session (line > >>>>>>>> > >>>>358-369, > >>>> > >>>>>>>> 470-479, 524-533) and without looking at the source I guess the > >>>>>>>> > >>>>mysql > >>>> > >>>>>>>> version is not much different. A simple function that accepts a > >>>>>>>> string, tries to run the query, DEBUG and return NULL if error, > >>>>>>>> > >>>>return > >>>> > >>>>>>>> result pointer would be nicer, it saves some code-copy-paste. > >>>>>>>>- The names True/true and False/false are both valid and both in use > >>>>>>>> > >>>>and > >>>> > >>>>>>>> sometimes mixed, but this problem also exists in the original > >>>>>>>> > >>>>source > >>>> > >>>>>>>> (take a look at pdb_smbpasswd). As long as there's no ``official'' > >>>>>>>> Samba standard for this I'd propose to use the uppercased names > >>>>>>>> > >>>>(True > >>>> > >>>>>>>> and False). > >>>>>>>> > >>>>>>>>Any comments on these proposals? > >>>>>>>> > >>>>>>>>Regards, Herwin > >>>>>>>> > >>>>>>>>------------------------------------------------------------------------- > >>>>>>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >>>>>>>>Studies have shown that voting for your favorite open source > >>>>>>>> > >>>>project, > >>>> > >>>>>>>>along with a healthy diet, reduces your potential for chronic > >>>>>>>> > >>>>lameness > >>>> > >>>>>>>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>------------------------------------------------------------------------ > >>>>>>> > >>>>>>>------------------------------------------------------------------------- > >>>>>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >>>>>>>Studies have shown that voting for your favorite open source project, > >>>>>>>along with a healthy diet, reduces your potential for chronic > >>>>>>> > >>>>lameness > >>>> > >>>>>>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >>>>>>> > >>>>>>> > >>>>>>------------------------------------------------------------------------ > >>>>>> > >>>>>>------------------------------------------------------------------------- > >>>>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >>>>>>Studies have shown that voting for your favorite open source project, > >>>>>>along with a healthy diet, reduces your potential for chronic lameness > >>>>>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >>>>>> > >>>>>> > >>>>>------------------------------------------------------------------------- > >>>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >>>>>Studies have shown that voting for your favorite open source project, > >>>>>along with a healthy diet, reduces your potential for chronic lameness > >>>>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >>>>> > >>>>> > >>>>------------------------------------------------------------------------- > >>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >>>>Studies have shown that voting for your favorite open source project, > >>>>along with a healthy diet, reduces your potential for chronic lameness > >>>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >>>> > >>>------------------------------------------------------------------------- > >>>This SF.Net email is sponsored by the Moblin Your Move Developer's > >>>challenge > >>>Build the coolest Linux based applications with Moblin SDK & win great > >>>prizes > >>>Grand prize is a trip for two to an Open Source event anywhere in the > >>>world > >>>http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>> > >>> > >> > >>------------------------------------------------------------------------- > >>This SF.Net email is sponsored by the Moblin Your Move Developer's > >>challenge > >>Build the coolest Linux based applications with Moblin SDK & win great > >>prizes > >>Grand prize is a trip for two to an Open Source event anywhere in the > >>world > >>http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >> > >> > > > >------------------------------------------------------------------------- > >This SF.Net email is sponsored by the Moblin Your Move Developer's > >challenge > >Build the coolest Linux based applications with Moblin SDK & win great > >prizes > >Grand prize is a trip for two to an Open Source event anywhere in the world > >http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ |
|
From: Collen B. <co...@he...> - 2008-07-18 11:02:10
|
Hmm, odd could find it in smbpasswd.c ?! but how does tdbsam and others do it. still got some problems with samba 3.2.0 but i also got them with tdbsam and ldap, so it's samba related one other thing is that there might be a problem with the $ filter - net sam list users - net sam list workstations both uses the search user function, so that might trouble. Cheers Collen Herwin Weststrate wrote: > I guess we want to fix the users/computers mixup first, I wouldn't be > surprised if it would give some really strange errors when using samba > as a domain controller. Easiest workaround is to check the last > character of the name equals a dollar-sign (same hack is used in in the > smbpasswd module). I guess that once this works we can call it a RC. > > Herwin > > On Wed, Jul 16, 2008 at 11:03:31PM +0200, Collen Blijenberg wrote: > >> Hi, >> >> just tested against fedora 9. >> looks all fine, accept that i still get a time out error >> with './net user' >> but on the other hand, i also get it when using ldap as backend (-: >> so my guess is that i have some sort of firewall problem. >> >> nice work. i'll see if i can release a beta or a rc >> unless there are some cons or other things i forgot ?! >> >> Cheers, Collen >> >> >> >> >>> I just upgraded my samba from 3.2.0~rc2 to 3.2.0-2 (both debian >>> versions), and suddenly the `net user` works again for both mysql and >>> postgresql now. If someone could test this against the vanilla source of >>> samba, it would be great. >>> Only problem left is the users/workstations mixup in the lists. >>> >>> >>> Regards, Herwin >>> >>> On Fri, Jul 11, 2008 at 04:10:22PM +0200, Collen Blijenberg wrote: >>> >>>> Hi, i see what you mean. >>>> >>>> i fixed a little part for mysql (see svn) >>>> the "net sam list user" works again, but "net user" doesn't (but the >>>> core dumps are gone) >>>> >>>> still to struggle with: >>>> >>>> net user -> still no good. >>>> listing users also spit out the workstations accounts ?!?!? >>>> listing worksttions also spit out users (makes sense) >>>> >>>> so far so good.... >>>> little steps but where getting there. >>>> >>>> hope you'll get more out of it this weekend.. >>>> >>>> Cheers, Collen >>>> >>>> >>>> Herwin Weststrate wrote: >>>> >>>>> I guess the bugs are caused by the lazy filling of the entry struct: >>>>> when using the command `pdbedit -L' only the sid is read, probably the >>>>> other parts of the structure are used in this command (see my comments >>>>> on line 508-511 in the pdb_pgsql.c file). Currently these are not >>>>> initialized whatsoever, so that might cause the segfaults. >>>>> I won't have time until the weekend to have a look at it, if someone >>>>> would be able to check this (just filling the struct with some phony >>>>> values would be enough), I'd like to hear the results of it. >>>>> >>>>> Herwin >>>>> >>>>> Collen Blijenberg wrote: >>>>> >>>>> >>>>>> Well, here are the test results of the dutch jury (-: >>>>>> >>>>>> looks good (also cleaned up the svn code) >>>>>> >>>>>> bugs found: >>>>>> >>>>>> - net user -> seg. fault + core dump >>>>>> - user manager (windows) -> can't exec RPC + core dump >>>>>> - net sam list users -> strange sighs like (like -?_) >>>>>> - net sam list workstations -> dido strange signs. >>>>>> >>>>>> pdbedit -L works just fine... >>>>>> so we're getting there... thx. >>>>>> >>>>>> dunno if these faults are related to our module or to samba, but my >>>>>> guess is the module.. >>>>>> have fun... >>>>>> >>>>>> Collen. >>>>>> >>>>>> >>>>>> Collen Blijenberg wrote: >>>>>> >>>>>> >>>>>>> Oeh, excellent Herwin, >>>>>>> >>>>>>> i saw you did mysql also... ! thx >>>>>>> we were busy with it last Friday, but did come to a sollution on the >>>>>>> search_users thing. >>>>>>> also good notice of the init_module. now both will work. >>>>>>> >>>>>>> i'll down the svn to see the thing in action (-: >>>>>>> >>>>>>> - the table name, don't think it's much of a problem, 2 different >>>>>>> >>>> names. >>>> >>>>>>> so I'll suggest to leave it as it is. but must say users has my >>>>>>> >>>> pref. >>>> >>>>>>> - sure upcase the true/false statements.. no worry here. (and looks >>>>>>> nicer) >>>>>>> - there hasn't been done mutch work on the pgsql module, maybe we >>>>>>> simply forgot to alter it ?! >>>>>>> >>>>>>> Thx, i'll get back on it as soon as i test all kind of things.... >>>>>>> >>>>>>> Cheers, nice work!! >>>>>>> >>>>>>> Collen. >>>>>>> >>>>>>> Herwin Weststrate wrote: >>>>>>> >>>>>>> >>>>>>>> On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> [...] >>>>>>>>> still need to figure out: >>>>>>>>> >>>>>>>>> - enumeration on users (seems that it's no longer there with samba >>>>>>>>> 3.2) >>>>>>>>> >>>>>>>>> >>>>>>>> I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind of >>>>>>>> iteration-mechanism to retreive the userlist, see the >>>>>>>> pgsqlsam_search_user function to see how it works. >>>>>>>> >>>>>>>> While working on it I noticed a number of things that were a little >>>>>>>> >>>> bit >>>> >>>>>>>> unlogical: >>>>>>>> - The mysql table defaults to `user', the postgres table to `users'. >>>>>>>> Probably because `user' is a keyword in postgres. This kind of >>>>>>>> inconsistency makes it hell to migrate to another database. I'd >>>>>>>> propose to use the names that work on both databases as a default, >>>>>>>> >>>> so >>>> >>>>>>>> the usertable should be called `users', the new grouptable should >>>>>>>> >>>> be >>>> >>>>>>>> called `groups' and the column with the name of the group should >>>>>>>> >>>> be >>>> >>>>>>>> called `groupname'. (Groups are added in Samba 3.2.0) >>>>>>>> - In the pdb_pgsql.c file I've counted three occurences of the >>>>>>>> >>>> `execute >>>> >>>>>>>> query, check results, print warnings if erorr'-session (line >>>>>>>> >>>> 358-369, >>>> >>>>>>>> 470-479, 524-533) and without looking at the source I guess the >>>>>>>> >>>> mysql >>>> >>>>>>>> version is not much different. A simple function that accepts a >>>>>>>> string, tries to run the query, DEBUG and return NULL if error, >>>>>>>> >>>> return >>>> >>>>>>>> result pointer would be nicer, it saves some code-copy-paste. >>>>>>>> - The names True/true and False/false are both valid and both in use >>>>>>>> >>>> and >>>> >>>>>>>> sometimes mixed, but this problem also exists in the original >>>>>>>> >>>> source >>>> >>>>>>>> (take a look at pdb_smbpasswd). As long as there's no ``official'' >>>>>>>> Samba standard for this I'd propose to use the uppercased names >>>>>>>> >>>> (True >>>> >>>>>>>> and False). >>>>>>>> >>>>>>>> Any comments on these proposals? >>>>>>>> >>>>>>>> Regards, Herwin >>>>>>>> >>>>>>>> ------------------------------------------------------------------------- >>>>>>>> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >>>>>>>> Studies have shown that voting for your favorite open source >>>>>>>> >>>> project, >>>> >>>>>>>> along with a healthy diet, reduces your potential for chronic >>>>>>>> >>>> lameness >>>> >>>>>>>> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> ------------------------------------------------------------------------ >>>>>>> >>>>>>> ------------------------------------------------------------------------- >>>>>>> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >>>>>>> Studies have shown that voting for your favorite open source project, >>>>>>> along with a healthy diet, reduces your potential for chronic >>>>>>> >>>> lameness >>>> >>>>>>> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >>>>>>> >>>>>>> >>>>>> ------------------------------------------------------------------------ >>>>>> >>>>>> ------------------------------------------------------------------------- >>>>>> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >>>>>> Studies have shown that voting for your favorite open source project, >>>>>> along with a healthy diet, reduces your potential for chronic lameness >>>>>> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >>>>>> >>>>>> >>>>> ------------------------------------------------------------------------- >>>>> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >>>>> Studies have shown that voting for your favorite open source project, >>>>> along with a healthy diet, reduces your potential for chronic lameness >>>>> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >>>>> >>>>> >>>> ------------------------------------------------------------------------- >>>> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >>>> Studies have shown that voting for your favorite open source project, >>>> along with a healthy diet, reduces your potential for chronic lameness >>>> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >>>> >>> ------------------------------------------------------------------------- >>> This SF.Net email is sponsored by the Moblin Your Move Developer's >>> challenge >>> Build the coolest Linux based applications with Moblin SDK & win great >>> prizes >>> Grand prize is a trip for two to an Open Source event anywhere in the >>> world >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>> >>> >> >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >> Build the coolest Linux based applications with Moblin SDK & win great prizes >> Grand prize is a trip for two to an Open Source event anywhere in the world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> >> > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > |
|
From: Herwin W. <he...@sn...> - 2008-07-17 19:55:37
|
I guess we want to fix the users/computers mixup first, I wouldn't be surprised if it would give some really strange errors when using samba as a domain controller. Easiest workaround is to check the last character of the name equals a dollar-sign (same hack is used in in the smbpasswd module). I guess that once this works we can call it a RC. Herwin On Wed, Jul 16, 2008 at 11:03:31PM +0200, Collen Blijenberg wrote: > Hi, > > just tested against fedora 9. > looks all fine, accept that i still get a time out error > with './net user' > but on the other hand, i also get it when using ldap as backend (-: > so my guess is that i have some sort of firewall problem. > > nice work. i'll see if i can release a beta or a rc > unless there are some cons or other things i forgot ?! > > Cheers, Collen > > > > > I just upgraded my samba from 3.2.0~rc2 to 3.2.0-2 (both debian > > versions), and suddenly the `net user` works again for both mysql and > > postgresql now. If someone could test this against the vanilla source of > > samba, it would be great. > > Only problem left is the users/workstations mixup in the lists. > > > > > > Regards, Herwin > > > > On Fri, Jul 11, 2008 at 04:10:22PM +0200, Collen Blijenberg wrote: > >> Hi, i see what you mean. > >> > >> i fixed a little part for mysql (see svn) > >> the "net sam list user" works again, but "net user" doesn't (but the > >> core dumps are gone) > >> > >> still to struggle with: > >> > >> net user -> still no good. > >> listing users also spit out the workstations accounts ?!?!? > >> listing worksttions also spit out users (makes sense) > >> > >> so far so good.... > >> little steps but where getting there. > >> > >> hope you'll get more out of it this weekend.. > >> > >> Cheers, Collen > >> > >> > >> Herwin Weststrate wrote: > >> >I guess the bugs are caused by the lazy filling of the entry struct: > >> >when using the command `pdbedit -L' only the sid is read, probably the > >> >other parts of the structure are used in this command (see my comments > >> >on line 508-511 in the pdb_pgsql.c file). Currently these are not > >> >initialized whatsoever, so that might cause the segfaults. > >> >I won't have time until the weekend to have a look at it, if someone > >> >would be able to check this (just filling the struct with some phony > >> >values would be enough), I'd like to hear the results of it. > >> > > >> >Herwin > >> > > >> >Collen Blijenberg wrote: > >> > > >> >>Well, here are the test results of the dutch jury (-: > >> >> > >> >>looks good (also cleaned up the svn code) > >> >> > >> >>bugs found: > >> >> > >> >>- net user -> seg. fault + core dump > >> >>- user manager (windows) -> can't exec RPC + core dump > >> >>- net sam list users -> strange sighs like (like -?_) > >> >>- net sam list workstations -> dido strange signs. > >> >> > >> >>pdbedit -L works just fine... > >> >>so we're getting there... thx. > >> >> > >> >>dunno if these faults are related to our module or to samba, but my > >> >>guess is the module.. > >> >>have fun... > >> >> > >> >>Collen. > >> >> > >> >> > >> >>Collen Blijenberg wrote: > >> >> > >> >>>Oeh, excellent Herwin, > >> >>> > >> >>>i saw you did mysql also... ! thx > >> >>>we were busy with it last Friday, but did come to a sollution on the > >> >>>search_users thing. > >> >>>also good notice of the init_module. now both will work. > >> >>> > >> >>>i'll down the svn to see the thing in action (-: > >> >>> > >> >>>- the table name, don't think it's much of a problem, 2 different > >> names. > >> >>> so I'll suggest to leave it as it is. but must say users has my > >> pref. > >> >>> > >> >>>- sure upcase the true/false statements.. no worry here. (and looks > >> >>>nicer) > >> >>>- there hasn't been done mutch work on the pgsql module, maybe we > >> >>>simply forgot to alter it ?! > >> >>> > >> >>>Thx, i'll get back on it as soon as i test all kind of things.... > >> >>> > >> >>>Cheers, nice work!! > >> >>> > >> >>>Collen. > >> >>> > >> >>>Herwin Weststrate wrote: > >> >>> > >> >>>>On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg wrote: > >> >>>> > >> >>>> > >> >>>>>[...] > >> >>>>>still need to figure out: > >> >>>>> > >> >>>>>- enumeration on users (seems that it's no longer there with samba > >> >>>>>3.2) > >> >>>>> > >> >>>>I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind of > >> >>>>iteration-mechanism to retreive the userlist, see the > >> >>>>pgsqlsam_search_user function to see how it works. > >> >>>> > >> >>>>While working on it I noticed a number of things that were a little > >> bit > >> >>>>unlogical: > >> >>>>- The mysql table defaults to `user', the postgres table to `users'. > >> >>>> Probably because `user' is a keyword in postgres. This kind of > >> >>>> inconsistency makes it hell to migrate to another database. I'd > >> >>>> propose to use the names that work on both databases as a default, > >> so > >> >>>> the usertable should be called `users', the new grouptable should > >> be > >> >>>> called `groups' and the column with the name of the group should > >> be > >> >>>> called `groupname'. (Groups are added in Samba 3.2.0) > >> >>>>- In the pdb_pgsql.c file I've counted three occurences of the > >> `execute > >> >>>> query, check results, print warnings if erorr'-session (line > >> 358-369, > >> >>>> 470-479, 524-533) and without looking at the source I guess the > >> mysql > >> >>>> version is not much different. A simple function that accepts a > >> >>>> string, tries to run the query, DEBUG and return NULL if error, > >> return > >> >>>> result pointer would be nicer, it saves some code-copy-paste. > >> >>>>- The names True/true and False/false are both valid and both in use > >> and > >> >>>> sometimes mixed, but this problem also exists in the original > >> source > >> >>>> (take a look at pdb_smbpasswd). As long as there's no ``official'' > >> >>>> Samba standard for this I'd propose to use the uppercased names > >> (True > >> >>>> and False). > >> >>>> > >> >>>>Any comments on these proposals? > >> >>>> > >> >>>>Regards, Herwin > >> >>>> > >> >>>>------------------------------------------------------------------------- > >> >>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >> >>>>Studies have shown that voting for your favorite open source > >> project, > >> >>>>along with a healthy diet, reduces your potential for chronic > >> lameness > >> >>>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >> >>>> > >> >>>> > >> >>>------------------------------------------------------------------------ > >> >>> > >> >>>------------------------------------------------------------------------- > >> >>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >> >>>Studies have shown that voting for your favorite open source project, > >> >>>along with a healthy diet, reduces your potential for chronic > >> lameness > >> >>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >> >>> > >> >>------------------------------------------------------------------------ > >> >> > >> >>------------------------------------------------------------------------- > >> >>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >> >>Studies have shown that voting for your favorite open source project, > >> >>along with a healthy diet, reduces your potential for chronic lameness > >> >>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >> >> > >> > > >> > > >> >------------------------------------------------------------------------- > >> >Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >> >Studies have shown that voting for your favorite open source project, > >> >along with a healthy diet, reduces your potential for chronic lameness > >> >and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >> > > > > >> ------------------------------------------------------------------------- > >> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >> Studies have shown that voting for your favorite open source project, > >> along with a healthy diet, reduces your potential for chronic lameness > >> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's > > challenge > > Build the coolest Linux based applications with Moblin SDK & win great > > prizes > > Grand prize is a trip for two to an Open Source event anywhere in the > > world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > |
|
From: Collen B. <co...@he...> - 2008-07-16 20:27:30
|
Hi, just tested against fedora 9. looks all fine, accept that i still get a time out error with './net user' but on the other hand, i also get it when using ldap as backend (-: so my guess is that i have some sort of firewall problem. nice work. i'll see if i can release a beta or a rc unless there are some cons or other things i forgot ?! Cheers, Collen > I just upgraded my samba from 3.2.0~rc2 to 3.2.0-2 (both debian > versions), and suddenly the `net user` works again for both mysql and > postgresql now. If someone could test this against the vanilla source of > samba, it would be great. > Only problem left is the users/workstations mixup in the lists. > > > Regards, Herwin > > On Fri, Jul 11, 2008 at 04:10:22PM +0200, Collen Blijenberg wrote: >> Hi, i see what you mean. >> >> i fixed a little part for mysql (see svn) >> the "net sam list user" works again, but "net user" doesn't (but the >> core dumps are gone) >> >> still to struggle with: >> >> net user -> still no good. >> listing users also spit out the workstations accounts ?!?!? >> listing worksttions also spit out users (makes sense) >> >> so far so good.... >> little steps but where getting there. >> >> hope you'll get more out of it this weekend.. >> >> Cheers, Collen >> >> >> Herwin Weststrate wrote: >> >I guess the bugs are caused by the lazy filling of the entry struct: >> >when using the command `pdbedit -L' only the sid is read, probably the >> >other parts of the structure are used in this command (see my comments >> >on line 508-511 in the pdb_pgsql.c file). Currently these are not >> >initialized whatsoever, so that might cause the segfaults. >> >I won't have time until the weekend to have a look at it, if someone >> >would be able to check this (just filling the struct with some phony >> >values would be enough), I'd like to hear the results of it. >> > >> >Herwin >> > >> >Collen Blijenberg wrote: >> > >> >>Well, here are the test results of the dutch jury (-: >> >> >> >>looks good (also cleaned up the svn code) >> >> >> >>bugs found: >> >> >> >>- net user -> seg. fault + core dump >> >>- user manager (windows) -> can't exec RPC + core dump >> >>- net sam list users -> strange sighs like (like -?_) >> >>- net sam list workstations -> dido strange signs. >> >> >> >>pdbedit -L works just fine... >> >>so we're getting there... thx. >> >> >> >>dunno if these faults are related to our module or to samba, but my >> >>guess is the module.. >> >>have fun... >> >> >> >>Collen. >> >> >> >> >> >>Collen Blijenberg wrote: >> >> >> >>>Oeh, excellent Herwin, >> >>> >> >>>i saw you did mysql also... ! thx >> >>>we were busy with it last Friday, but did come to a sollution on the >> >>>search_users thing. >> >>>also good notice of the init_module. now both will work. >> >>> >> >>>i'll down the svn to see the thing in action (-: >> >>> >> >>>- the table name, don't think it's much of a problem, 2 different >> names. >> >>> so I'll suggest to leave it as it is. but must say users has my >> pref. >> >>> >> >>>- sure upcase the true/false statements.. no worry here. (and looks >> >>>nicer) >> >>>- there hasn't been done mutch work on the pgsql module, maybe we >> >>>simply forgot to alter it ?! >> >>> >> >>>Thx, i'll get back on it as soon as i test all kind of things.... >> >>> >> >>>Cheers, nice work!! >> >>> >> >>>Collen. >> >>> >> >>>Herwin Weststrate wrote: >> >>> >> >>>>On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg wrote: >> >>>> >> >>>> >> >>>>>[...] >> >>>>>still need to figure out: >> >>>>> >> >>>>>- enumeration on users (seems that it's no longer there with samba >> >>>>>3.2) >> >>>>> >> >>>>I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind of >> >>>>iteration-mechanism to retreive the userlist, see the >> >>>>pgsqlsam_search_user function to see how it works. >> >>>> >> >>>>While working on it I noticed a number of things that were a little >> bit >> >>>>unlogical: >> >>>>- The mysql table defaults to `user', the postgres table to `users'. >> >>>> Probably because `user' is a keyword in postgres. This kind of >> >>>> inconsistency makes it hell to migrate to another database. I'd >> >>>> propose to use the names that work on both databases as a default, >> so >> >>>> the usertable should be called `users', the new grouptable should >> be >> >>>> called `groups' and the column with the name of the group should >> be >> >>>> called `groupname'. (Groups are added in Samba 3.2.0) >> >>>>- In the pdb_pgsql.c file I've counted three occurences of the >> `execute >> >>>> query, check results, print warnings if erorr'-session (line >> 358-369, >> >>>> 470-479, 524-533) and without looking at the source I guess the >> mysql >> >>>> version is not much different. A simple function that accepts a >> >>>> string, tries to run the query, DEBUG and return NULL if error, >> return >> >>>> result pointer would be nicer, it saves some code-copy-paste. >> >>>>- The names True/true and False/false are both valid and both in use >> and >> >>>> sometimes mixed, but this problem also exists in the original >> source >> >>>> (take a look at pdb_smbpasswd). As long as there's no ``official'' >> >>>> Samba standard for this I'd propose to use the uppercased names >> (True >> >>>> and False). >> >>>> >> >>>>Any comments on these proposals? >> >>>> >> >>>>Regards, Herwin >> >>>> >> >>>>------------------------------------------------------------------------- >> >>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> >>>>Studies have shown that voting for your favorite open source >> project, >> >>>>along with a healthy diet, reduces your potential for chronic >> lameness >> >>>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> >>>> >> >>>> >> >>>------------------------------------------------------------------------ >> >>> >> >>>------------------------------------------------------------------------- >> >>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> >>>Studies have shown that voting for your favorite open source project, >> >>>along with a healthy diet, reduces your potential for chronic >> lameness >> >>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> >>> >> >>------------------------------------------------------------------------ >> >> >> >>------------------------------------------------------------------------- >> >>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> >>Studies have shown that voting for your favorite open source project, >> >>along with a healthy diet, reduces your potential for chronic lameness >> >>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> >> >> > >> > >> >------------------------------------------------------------------------- >> >Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> >Studies have shown that voting for your favorite open source project, >> >along with a healthy diet, reduces your potential for chronic lameness >> >and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> > > >> ------------------------------------------------------------------------- >> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> Studies have shown that voting for your favorite open source project, >> along with a healthy diet, reduces your potential for chronic lameness >> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the > world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > |
|
From: Herwin W. <he...@sn...> - 2008-07-16 18:18:50
|
I just upgraded my samba from 3.2.0~rc2 to 3.2.0-2 (both debian versions), and suddenly the `net user` works again for both mysql and postgresql now. If someone could test this against the vanilla source of samba, it would be great. Only problem left is the users/workstations mixup in the lists. Regards, Herwin On Fri, Jul 11, 2008 at 04:10:22PM +0200, Collen Blijenberg wrote: > Hi, i see what you mean. > > i fixed a little part for mysql (see svn) > the "net sam list user" works again, but "net user" doesn't (but the > core dumps are gone) > > still to struggle with: > > net user -> still no good. > listing users also spit out the workstations accounts ?!?!? > listing worksttions also spit out users (makes sense) > > so far so good.... > little steps but where getting there. > > hope you'll get more out of it this weekend.. > > Cheers, Collen > > > Herwin Weststrate wrote: > >I guess the bugs are caused by the lazy filling of the entry struct: > >when using the command `pdbedit -L' only the sid is read, probably the > >other parts of the structure are used in this command (see my comments > >on line 508-511 in the pdb_pgsql.c file). Currently these are not > >initialized whatsoever, so that might cause the segfaults. > >I won't have time until the weekend to have a look at it, if someone > >would be able to check this (just filling the struct with some phony > >values would be enough), I'd like to hear the results of it. > > > >Herwin > > > >Collen Blijenberg wrote: > > > >>Well, here are the test results of the dutch jury (-: > >> > >>looks good (also cleaned up the svn code) > >> > >>bugs found: > >> > >>- net user -> seg. fault + core dump > >>- user manager (windows) -> can't exec RPC + core dump > >>- net sam list users -> strange sighs like (like -?_) > >>- net sam list workstations -> dido strange signs. > >> > >>pdbedit -L works just fine... > >>so we're getting there... thx. > >> > >>dunno if these faults are related to our module or to samba, but my > >>guess is the module.. > >>have fun... > >> > >>Collen. > >> > >> > >>Collen Blijenberg wrote: > >> > >>>Oeh, excellent Herwin, > >>> > >>>i saw you did mysql also... ! thx > >>>we were busy with it last Friday, but did come to a sollution on the > >>>search_users thing. > >>>also good notice of the init_module. now both will work. > >>> > >>>i'll down the svn to see the thing in action (-: > >>> > >>>- the table name, don't think it's much of a problem, 2 different names. > >>> so I'll suggest to leave it as it is. but must say users has my pref. > >>> > >>>- sure upcase the true/false statements.. no worry here. (and looks > >>>nicer) > >>>- there hasn't been done mutch work on the pgsql module, maybe we > >>>simply forgot to alter it ?! > >>> > >>>Thx, i'll get back on it as soon as i test all kind of things.... > >>> > >>>Cheers, nice work!! > >>> > >>>Collen. > >>> > >>>Herwin Weststrate wrote: > >>> > >>>>On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg wrote: > >>>> > >>>> > >>>>>[...] > >>>>>still need to figure out: > >>>>> > >>>>>- enumeration on users (seems that it's no longer there with samba > >>>>>3.2) > >>>>> > >>>>I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind of > >>>>iteration-mechanism to retreive the userlist, see the > >>>>pgsqlsam_search_user function to see how it works. > >>>> > >>>>While working on it I noticed a number of things that were a little bit > >>>>unlogical: > >>>>- The mysql table defaults to `user', the postgres table to `users'. > >>>> Probably because `user' is a keyword in postgres. This kind of > >>>> inconsistency makes it hell to migrate to another database. I'd > >>>> propose to use the names that work on both databases as a default, so > >>>> the usertable should be called `users', the new grouptable should be > >>>> called `groups' and the column with the name of the group should be > >>>> called `groupname'. (Groups are added in Samba 3.2.0) > >>>>- In the pdb_pgsql.c file I've counted three occurences of the `execute > >>>> query, check results, print warnings if erorr'-session (line 358-369, > >>>> 470-479, 524-533) and without looking at the source I guess the mysql > >>>> version is not much different. A simple function that accepts a > >>>> string, tries to run the query, DEBUG and return NULL if error, return > >>>> result pointer would be nicer, it saves some code-copy-paste. > >>>>- The names True/true and False/false are both valid and both in use and > >>>> sometimes mixed, but this problem also exists in the original source > >>>> (take a look at pdb_smbpasswd). As long as there's no ``official'' > >>>> Samba standard for this I'd propose to use the uppercased names (True > >>>> and False). > >>>> > >>>>Any comments on these proposals? > >>>> > >>>>Regards, Herwin > >>>> > >>>>------------------------------------------------------------------------- > >>>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >>>>Studies have shown that voting for your favorite open source project, > >>>>along with a healthy diet, reduces your potential for chronic lameness > >>>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >>>> > >>>> > >>>------------------------------------------------------------------------ > >>> > >>>------------------------------------------------------------------------- > >>>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >>>Studies have shown that voting for your favorite open source project, > >>>along with a healthy diet, reduces your potential for chronic lameness > >>>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >>> > >>------------------------------------------------------------------------ > >> > >>------------------------------------------------------------------------- > >>Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >>Studies have shown that voting for your favorite open source project, > >>along with a healthy diet, reduces your potential for chronic lameness > >>and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > >> > > > > > >------------------------------------------------------------------------- > >Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > >Studies have shown that voting for your favorite open source project, > >along with a healthy diet, reduces your potential for chronic lameness > >and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > > > ------------------------------------------------------------------------- > Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > Studies have shown that voting for your favorite open source project, > along with a healthy diet, reduces your potential for chronic lameness > and boredom. Vote Now at http://www.sourceforge.net/community/cca08 |
|
From: Collen B. <co...@he...> - 2008-07-11 14:07:36
|
Hi, i see what you mean. i fixed a little part for mysql (see svn) the "net sam list user" works again, but "net user" doesn't (but the core dumps are gone) still to struggle with: net user -> still no good. listing users also spit out the workstations accounts ?!?!? listing worksttions also spit out users (makes sense) so far so good.... little steps but where getting there. hope you'll get more out of it this weekend.. Cheers, Collen Herwin Weststrate wrote: > I guess the bugs are caused by the lazy filling of the entry struct: > when using the command `pdbedit -L' only the sid is read, probably the > other parts of the structure are used in this command (see my comments > on line 508-511 in the pdb_pgsql.c file). Currently these are not > initialized whatsoever, so that might cause the segfaults. > I won't have time until the weekend to have a look at it, if someone > would be able to check this (just filling the struct with some phony > values would be enough), I'd like to hear the results of it. > > Herwin > > Collen Blijenberg wrote: > >> Well, here are the test results of the dutch jury (-: >> >> looks good (also cleaned up the svn code) >> >> bugs found: >> >> - net user -> seg. fault + core dump >> - user manager (windows) -> can't exec RPC + core dump >> - net sam list users -> strange sighs like (like -?_) >> - net sam list workstations -> dido strange signs. >> >> pdbedit -L works just fine... >> so we're getting there... thx. >> >> dunno if these faults are related to our module or to samba, but my >> guess is the module.. >> have fun... >> >> Collen. >> >> >> Collen Blijenberg wrote: >> >>> Oeh, excellent Herwin, >>> >>> i saw you did mysql also... ! thx >>> we were busy with it last Friday, but did come to a sollution on the >>> search_users thing. >>> also good notice of the init_module. now both will work. >>> >>> i'll down the svn to see the thing in action (-: >>> >>> - the table name, don't think it's much of a problem, 2 different names. >>> so I'll suggest to leave it as it is. but must say users has my pref. >>> >>> - sure upcase the true/false statements.. no worry here. (and looks nicer) >>> - there hasn't been done mutch work on the pgsql module, maybe we >>> simply forgot to alter it ?! >>> >>> Thx, i'll get back on it as soon as i test all kind of things.... >>> >>> Cheers, nice work!! >>> >>> Collen. >>> >>> Herwin Weststrate wrote: >>> >>>> On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg wrote: >>>> >>>> >>>>> [...] >>>>> still need to figure out: >>>>> >>>>> - enumeration on users (seems that it's no longer there with samba 3.2) >>>>> >>>>> >>>> I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind of >>>> iteration-mechanism to retreive the userlist, see the >>>> pgsqlsam_search_user function to see how it works. >>>> >>>> While working on it I noticed a number of things that were a little bit >>>> unlogical: >>>> - The mysql table defaults to `user', the postgres table to `users'. >>>> Probably because `user' is a keyword in postgres. This kind of >>>> inconsistency makes it hell to migrate to another database. I'd >>>> propose to use the names that work on both databases as a default, so >>>> the usertable should be called `users', the new grouptable should be >>>> called `groups' and the column with the name of the group should be >>>> called `groupname'. (Groups are added in Samba 3.2.0) >>>> - In the pdb_pgsql.c file I've counted three occurences of the `execute >>>> query, check results, print warnings if erorr'-session (line 358-369, >>>> 470-479, 524-533) and without looking at the source I guess the mysql >>>> version is not much different. A simple function that accepts a >>>> string, tries to run the query, DEBUG and return NULL if error, return >>>> result pointer would be nicer, it saves some code-copy-paste. >>>> - The names True/true and False/false are both valid and both in use and >>>> sometimes mixed, but this problem also exists in the original source >>>> (take a look at pdb_smbpasswd). As long as there's no ``official'' >>>> Samba standard for this I'd propose to use the uppercased names (True >>>> and False). >>>> >>>> Any comments on these proposals? >>>> >>>> Regards, Herwin >>>> >>>> ------------------------------------------------------------------------- >>>> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >>>> Studies have shown that voting for your favorite open source project, >>>> along with a healthy diet, reduces your potential for chronic lameness >>>> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >>>> >>>> >>> ------------------------------------------------------------------------ >>> >>> ------------------------------------------------------------------------- >>> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >>> Studies have shown that voting for your favorite open source project, >>> along with a healthy diet, reduces your potential for chronic lameness >>> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >>> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------- >> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> Studies have shown that voting for your favorite open source project, >> along with a healthy diet, reduces your potential for chronic lameness >> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> > > > ------------------------------------------------------------------------- > Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > Studies have shown that voting for your favorite open source project, > along with a healthy diet, reduces your potential for chronic lameness > and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > |
|
From: Herwin W. <he...@sn...> - 2008-07-07 22:33:59
|
I guess the bugs are caused by the lazy filling of the entry struct: when using the command `pdbedit -L' only the sid is read, probably the other parts of the structure are used in this command (see my comments on line 508-511 in the pdb_pgsql.c file). Currently these are not initialized whatsoever, so that might cause the segfaults. I won't have time until the weekend to have a look at it, if someone would be able to check this (just filling the struct with some phony values would be enough), I'd like to hear the results of it. Herwin Collen Blijenberg wrote: > Well, here are the test results of the dutch jury (-: > > looks good (also cleaned up the svn code) > > bugs found: > > - net user -> seg. fault + core dump > - user manager (windows) -> can't exec RPC + core dump > - net sam list users -> strange sighs like (like -?_) > - net sam list workstations -> dido strange signs. > > pdbedit -L works just fine... > so we're getting there... thx. > > dunno if these faults are related to our module or to samba, but my > guess is the module.. > have fun... > > Collen. > > > Collen Blijenberg wrote: >> Oeh, excellent Herwin, >> >> i saw you did mysql also... ! thx >> we were busy with it last Friday, but did come to a sollution on the >> search_users thing. >> also good notice of the init_module. now both will work. >> >> i'll down the svn to see the thing in action (-: >> >> - the table name, don't think it's much of a problem, 2 different names. >> so I'll suggest to leave it as it is. but must say users has my pref. >> >> - sure upcase the true/false statements.. no worry here. (and looks nicer) >> - there hasn't been done mutch work on the pgsql module, maybe we >> simply forgot to alter it ?! >> >> Thx, i'll get back on it as soon as i test all kind of things.... >> >> Cheers, nice work!! >> >> Collen. >> >> Herwin Weststrate wrote: >>> On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg wrote: >>> >>>> [...] >>>> still need to figure out: >>>> >>>> - enumeration on users (seems that it's no longer there with samba 3.2) >>>> >>> >>> I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind of >>> iteration-mechanism to retreive the userlist, see the >>> pgsqlsam_search_user function to see how it works. >>> >>> While working on it I noticed a number of things that were a little bit >>> unlogical: >>> - The mysql table defaults to `user', the postgres table to `users'. >>> Probably because `user' is a keyword in postgres. This kind of >>> inconsistency makes it hell to migrate to another database. I'd >>> propose to use the names that work on both databases as a default, so >>> the usertable should be called `users', the new grouptable should be >>> called `groups' and the column with the name of the group should be >>> called `groupname'. (Groups are added in Samba 3.2.0) >>> - In the pdb_pgsql.c file I've counted three occurences of the `execute >>> query, check results, print warnings if erorr'-session (line 358-369, >>> 470-479, 524-533) and without looking at the source I guess the mysql >>> version is not much different. A simple function that accepts a >>> string, tries to run the query, DEBUG and return NULL if error, return >>> result pointer would be nicer, it saves some code-copy-paste. >>> - The names True/true and False/false are both valid and both in use and >>> sometimes mixed, but this problem also exists in the original source >>> (take a look at pdb_smbpasswd). As long as there's no ``official'' >>> Samba standard for this I'd propose to use the uppercased names (True >>> and False). >>> >>> Any comments on these proposals? >>> >>> Regards, Herwin >>> >>> ------------------------------------------------------------------------- >>> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >>> Studies have shown that voting for your favorite open source project, >>> along with a healthy diet, reduces your potential for chronic lameness >>> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >>> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------- >> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> Studies have shown that voting for your favorite open source project, >> along with a healthy diet, reduces your potential for chronic lameness >> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > Studies have shown that voting for your favorite open source project, > along with a healthy diet, reduces your potential for chronic lameness > and boredom. Vote Now at http://www.sourceforge.net/community/cca08 |
|
From: Collen B. <co...@he...> - 2008-07-07 09:30:08
|
Well, here are the test results of the dutch jury (-: looks good (also cleaned up the svn code) bugs found: - net user -> seg. fault + core dump - user manager (windows) -> can't exec RPC + core dump - net sam list users -> strange sighs like (like -?_) - net sam list workstations -> dido strange signs. pdbedit -L works just fine... so we're getting there... thx. dunno if these faults are related to our module or to samba, but my guess is the module.. have fun... Collen. Collen Blijenberg wrote: > Oeh, excellent Herwin, > > i saw you did mysql also... ! thx > we were busy with it last Friday, but did come to a sollution on the > search_users thing. > also good notice of the init_module. now both will work. > > i'll down the svn to see the thing in action (-: > > - the table name, don't think it's much of a problem, 2 different names. > so I'll suggest to leave it as it is. but must say users has my pref. > > - sure upcase the true/false statements.. no worry here. (and looks nicer) > - there hasn't been done mutch work on the pgsql module, maybe we > simply forgot to alter it ?! > > Thx, i'll get back on it as soon as i test all kind of things.... > > Cheers, nice work!! > > Collen. > > Herwin Weststrate wrote: >> On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg wrote: >> >>> [...] >>> still need to figure out: >>> >>> - enumeration on users (seems that it's no longer there with samba 3.2) >>> >> >> I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind of >> iteration-mechanism to retreive the userlist, see the >> pgsqlsam_search_user function to see how it works. >> >> While working on it I noticed a number of things that were a little bit >> unlogical: >> - The mysql table defaults to `user', the postgres table to `users'. >> Probably because `user' is a keyword in postgres. This kind of >> inconsistency makes it hell to migrate to another database. I'd >> propose to use the names that work on both databases as a default, so >> the usertable should be called `users', the new grouptable should be >> called `groups' and the column with the name of the group should be >> called `groupname'. (Groups are added in Samba 3.2.0) >> - In the pdb_pgsql.c file I've counted three occurences of the `execute >> query, check results, print warnings if erorr'-session (line 358-369, >> 470-479, 524-533) and without looking at the source I guess the mysql >> version is not much different. A simple function that accepts a >> string, tries to run the query, DEBUG and return NULL if error, return >> result pointer would be nicer, it saves some code-copy-paste. >> - The names True/true and False/false are both valid and both in use and >> sometimes mixed, but this problem also exists in the original source >> (take a look at pdb_smbpasswd). As long as there's no ``official'' >> Samba standard for this I'd propose to use the uppercased names (True >> and False). >> >> Any comments on these proposals? >> >> Regards, Herwin >> >> ------------------------------------------------------------------------- >> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> Studies have shown that voting for your favorite open source project, >> along with a healthy diet, reduces your potential for chronic lameness >> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > Studies have shown that voting for your favorite open source project, > along with a healthy diet, reduces your potential for chronic lameness > and boredom. Vote Now at http://www.sourceforge.net/community/cca08 |
|
From: Collen B. <co...@he...> - 2008-07-07 08:20:55
|
Oeh, excellent Herwin, i saw you did mysql also... ! thx we were busy with it last Friday, but did come to a sollution on the search_users thing. also good notice of the init_module. now both will work. i'll down the svn to see the thing in action (-: - the table name, don't think it's much of a problem, 2 different names. so I'll suggest to leave it as it is. but must say users has my pref. - sure upcase the true/false statements.. no worry here. (and looks nicer) - there hasn't been done mutch work on the pgsql module, maybe we simply forgot to alter it ?! Thx, i'll get back on it as soon as i test all kind of things.... Cheers, nice work!! Collen. Herwin Weststrate wrote: > On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg wrote: > >> [...] >> still need to figure out: >> >> - enumeration on users (seems that it's no longer there with samba 3.2) >> > > I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind of > iteration-mechanism to retreive the userlist, see the > pgsqlsam_search_user function to see how it works. > > While working on it I noticed a number of things that were a little bit > unlogical: > - The mysql table defaults to `user', the postgres table to `users'. > Probably because `user' is a keyword in postgres. This kind of > inconsistency makes it hell to migrate to another database. I'd > propose to use the names that work on both databases as a default, so > the usertable should be called `users', the new grouptable should be > called `groups' and the column with the name of the group should be > called `groupname'. (Groups are added in Samba 3.2.0) > - In the pdb_pgsql.c file I've counted three occurences of the `execute > query, check results, print warnings if erorr'-session (line 358-369, > 470-479, 524-533) and without looking at the source I guess the mysql > version is not much different. A simple function that accepts a > string, tries to run the query, DEBUG and return NULL if error, return > result pointer would be nicer, it saves some code-copy-paste. > - The names True/true and False/false are both valid and both in use and > sometimes mixed, but this problem also exists in the original source > (take a look at pdb_smbpasswd). As long as there's no ``official'' > Samba standard for this I'd propose to use the uppercased names (True > and False). > > Any comments on these proposals? > > Regards, Herwin > > ------------------------------------------------------------------------- > Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! > Studies have shown that voting for your favorite open source project, > along with a healthy diet, reduces your potential for chronic lameness > and boredom. Vote Now at http://www.sourceforge.net/community/cca08 > |
|
From: Herwin W. <he...@sn...> - 2008-07-06 10:33:22
|
On Fri, Jun 27, 2008 at 02:03:41PM +0200, Collen Blijenberg wrote: > [...] > still need to figure out: > > - enumeration on users (seems that it's no longer there with samba 3.2) I fixed that one in pdb_pgsql.c yesterday: samba 3.2 uses a kind of iteration-mechanism to retreive the userlist, see the pgsqlsam_search_user function to see how it works. While working on it I noticed a number of things that were a little bit unlogical: - The mysql table defaults to `user', the postgres table to `users'. Probably because `user' is a keyword in postgres. This kind of inconsistency makes it hell to migrate to another database. I'd propose to use the names that work on both databases as a default, so the usertable should be called `users', the new grouptable should be called `groups' and the column with the name of the group should be called `groupname'. (Groups are added in Samba 3.2.0) - In the pdb_pgsql.c file I've counted three occurences of the `execute query, check results, print warnings if erorr'-session (line 358-369, 470-479, 524-533) and without looking at the source I guess the mysql version is not much different. A simple function that accepts a string, tries to run the query, DEBUG and return NULL if error, return result pointer would be nicer, it saves some code-copy-paste. - The names True/true and False/false are both valid and both in use and sometimes mixed, but this problem also exists in the original source (take a look at pdb_smbpasswd). As long as there's no ``official'' Samba standard for this I'd propose to use the uppercased names (True and False). Any comments on these proposals? Regards, Herwin |
|
From: Collen B. <co...@he...> - 2008-06-27 12:01:19
|
Ok, fixed broken compile. i comment out several things, but left them in. coz' i didn't test anny thing yet. they should go, after we get some more test results. i worked against the rc2 candidate, so no sure thing this is going to work with the official 3.2 things fixed:changed: - pstring -> fstring - sid_to_string is gone. - compile error in pgsql module (data handler) still need to figure out: - enumeration on users (seems that it's no longer there with samba 3.2) - sampwent - group and domain mappings. - if it works (-: - clean up after work.. Cheers, Collen Collen Blijenberg wrote: > Hi I'm kinda busy to make the backend work agains samba 3.2.XX > > so far: > > - seems that 'BOOL' became 'bool' with the new samba version > > - also sampwent is gone ?? dunno if there is something new instead so > that's why i comment them out instead of removing them.. > > - made extra structure to de mysql.dump (this should also be done for > the pgsql) > there should be new code in the backend for groups, domains, > machines and users > but i'm not sure if it is wise to split the users and machines apart > ?!?!? > > > it's still broke, it gives an error with sql.c and stops... > also there are far more compile error's as before.. > > lot of work is left, but if someone wants to help.. your welcome.. > > Cheers, Collen > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php |
|
From: Collen B. <co...@he...> - 2008-06-26 13:07:59
|
Hi I'm kinda busy to make the backend work agains samba 3.2.XX so far: - seems that 'BOOL' became 'bool' with the new samba version - also sampwent is gone ?? dunno if there is something new instead so that's why i comment them out instead of removing them.. - made extra structure to de mysql.dump (this should also be done for the pgsql) there should be new code in the backend for groups, domains, machines and users but i'm not sure if it is wise to split the users and machines apart ?!?!? it's still broke, it gives an error with sql.c and stops... also there are far more compile error's as before.. lot of work is left, but if someone wants to help.. your welcome.. Cheers, Collen |
|
From: Jelmer V. <je...@sa...> - 2008-05-15 10:49:13
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Collen, Collen Blijenberg wrote: > i was thinking to use a separated branche or tree for the 3.2.x > versions of pdbsql. sorry if i put my name in the copyright, i > thought that releasing a new version and making it work would be ok > for that. > guess a maintainer who puts in, and change code isn't copyright > worth it.. (what thanks for the motivation jelmer...) Please note that attribution and copyright are different things. It's the claiming of copyright on a file for changing a single word in that file that I was objecting to, not the putting your name in AUTHORS. Cheers, Jelmer > Jelmer Vernooij wrote: Collen, > > Sorry it's been so long since I've actually read this list... > Thanks for working on a 3.2-compatible release! I'm still happy to > answer any questions wrt the plugin, though you may have to ping me > personally since I don't read the list very often. > > Could you please copy the actual branch rather than the individual > files? This messes up the history of the files, removing some of > the usefulness of Subversion, and it spams the list like crazy. > Somewhat related to this; please only claim copyright on a file > when you make more than a trivial contribution (such as a typo). > > Happy hacking :-) > > Cheers, > > Jelmer > > co...@us... wrote: > >>>> Revision: 90 >>>> http://pdbsql.svn.sourceforge.net/pdbsql/?rev=90&view=rev >>>> Author: collen Date: 2008-01-09 08:12:43 -0800 (Wed, 09 >>>> Jan 2008) >>>> >>>> Log Message: ----------- Beta -> 3.0.25 - 3.0.28 >>>> >>>> Added Paths: ----------- >>>> branches/pdbsql/samba-pdbsql-3028/pdb_sql.h >>>> >>>> Copied: branches/pdbsql/samba-pdbsql-3028/pdb_sql.h (from rev >>>> 89, trunk/pdb_sql.h) >>>> =================================================================== >>>> --- branches/pdbsql/samba-pdbsql-3028/pdb_sql.h (rev 0) +++ >>>> branches/pdbsql/samba-pdbsql-3028/pdb_sql.h > 2008-01-09 >>>> 16:12:43 UTC (rev 90) @@ -0,0 +1,47 @@ +/* + * Common PDB SQL >>>> backend functions + * Copyright (C) Jelmer Vernooij >>>> 2003-2004 + * + * This program is free software; you can >>>> redistribute it and/or modify it under + * the terms of the >>>> GNU General Public License as published by the Free + * >>>> Software Foundation; either version 2 of the License, or (at >>>> your option) + * any later version. + * + * This program is >>>> distributed in the hope that it will be useful, but WITHOUT + >>>> * ANY WARRANTY; without even the implied warranty of >>>> MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See >>>> the GNU General Public License for + * more details. + * + * >>>> You should have received a copy of the GNU General Public >>>> License along with + * this program; if not, write to the >>>> Free Software Foundation, Inc., 675 + * Mass Ave, Cambridge, >>>> MA 02139, USA. + */ + +#include "includes.h" + +#ifndef >>>> _PDB_SQL_H +#define _PDB_SQL_H + +enum sql_search_field { + >>>> SQL_SEARCH_NONE = 0, + > SQL_SEARCH_USER_SID = >>>> 1, + SQL_SEARCH_USER_NAME = 2 +}; + + +char >>>> *sql_escape_string(TALLOC_CTX *mem_ctx, const char *unesc); + >>>> +char *sql_account_query_select(TALLOC_CTX *mem_ctx, const >>>> char *data, + BOOL update, enum sql_search_field field, > + const >>>> > char > >>>> *value); + +char *sql_account_query_delete(TALLOC_CTX >>>> *mem_ctx, const char *data, + const >>>> char *esc); + +char *sql_account_query_update(TALLOC_CTX >>>> *mem_ctx, const char *location, + >>>> struct samu *newpwd, char isupdate); + +BOOL >>>> sql_account_config_valid(const char *data); + +#endif /* >>>> _PDB_SQL_H */ + >>>> >>>> >>>> This was sent by the SourceForge.net collaborative >>>> development platform, the world's largest Open Source >>>> development site. >>>> >>>> > ------------------------------------------------------------------------- > >>>> Check out the new SourceForge.net Marketplace. It's the best >>>> place to buy or sell services for just about anything Open >>>> Source. >>>> > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > >>>> >>>> >>>> > >> >> - ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > ---------------------------------------------------------------------- > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft Defy all challenges. > Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iQCVAwUBSCwVGwy0JeEGD2blAQJrPAP+Nerda0GcGUQ1+/k8WfcQCRwrisENbkRX mjp//HBYBCQwBHcltrcxuZd2WWFfNzC5M1nJlvRwK9JPfsJg/XdhZx9/FZGcWs0j NmeisX8map3bCQfNOO/ZhFCXKhQ7gOC+EZGtWlicOe6JttXEdD4Eczjp7okUkIcn JWA5cm1jJGc= =jHj7 -----END PGP SIGNATURE----- |
|
From: Collen B. <co...@he...> - 2008-05-15 07:21:15
|
Hi Jelmer, yes that has been a while indeed. i saw that there are a few big changes in the samba release (3.2.x) but we'll get it... (i hope) we also have a new developer, Herwin from TU-Twente. since wilco lak's time it's nice to have a new person to team. i still need to update the svn, sorry for that. the 0.3.1 is still not update to there. it's just a thing called time.... i'll see if i manage this week to update it. i was thinking to use a separated branche or tree for the 3.2.x versions of pdbsql. sorry if i put my name in the copyright, i thought that releasing a new version and making it work would be ok for that. guess a maintainer who puts in, and change code isn't copyright worth it.. (what thanks for the motivation jelmer...) Greets, Collen... Jelmer Vernooij wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Collen, > > Sorry it's been so long since I've actually read this list... Thanks > for working on a 3.2-compatible release! I'm still happy to answer any > questions wrt the plugin, though you may have to ping me personally > since I don't read the list very often. > > Could you please copy the actual branch rather than the individual > files? This messes up the history of the files, removing some of the > usefulness of Subversion, and it spams the list like crazy. Somewhat > related to this; please only claim copyright on a file when you make > more than a trivial contribution (such as a typo). > > Happy hacking :-) > > Cheers, > > Jelmer > > co...@us... wrote: > >> Revision: 90 >> http://pdbsql.svn.sourceforge.net/pdbsql/?rev=90&view=rev Author: >> collen Date: 2008-01-09 08:12:43 -0800 (Wed, 09 Jan 2008) >> >> Log Message: ----------- Beta -> 3.0.25 - 3.0.28 >> >> Added Paths: ----------- >> branches/pdbsql/samba-pdbsql-3028/pdb_sql.h >> >> Copied: branches/pdbsql/samba-pdbsql-3028/pdb_sql.h (from rev 89, >> trunk/pdb_sql.h) >> =================================================================== >> --- branches/pdbsql/samba-pdbsql-3028/pdb_sql.h >> (rev 0) +++ branches/pdbsql/samba-pdbsql-3028/pdb_sql.h 2008-01-09 >> 16:12:43 UTC (rev 90) @@ -0,0 +1,47 @@ +/* + * Common PDB SQL >> backend functions + * Copyright (C) Jelmer Vernooij 2003-2004 + * + >> * This program is free software; you can redistribute it and/or >> modify it under + * the terms of the GNU General Public License as >> published by the Free + * Software Foundation; either version 2 of >> the License, or (at your option) + * any later version. + * + * >> This program is distributed in the hope that it will be useful, but >> WITHOUT + * ANY WARRANTY; without even the implied warranty of >> MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the >> GNU General Public License for + * more details. + * + * You should >> have received a copy of the GNU General Public License along with + >> * this program; if not, write to the Free Software Foundation, >> Inc., 675 + * Mass Ave, Cambridge, MA 02139, USA. + */ + +#include >> "includes.h" + +#ifndef _PDB_SQL_H +#define _PDB_SQL_H + +enum >> sql_search_field { + SQL_SEARCH_NONE = 0, + SQL_SEARCH_USER_SID = >> 1, + SQL_SEARCH_USER_NAME = 2 +}; + + +char >> *sql_escape_string(TALLOC_CTX *mem_ctx, const char *unesc); + +char >> *sql_account_query_select(TALLOC_CTX *mem_ctx, const char *data, + >> BOOL update, enum sql_search_field field, + const >> > char > >> *value); + +char *sql_account_query_delete(TALLOC_CTX *mem_ctx, >> const char *data, + const char *esc); + +char >> *sql_account_query_update(TALLOC_CTX *mem_ctx, const char >> *location, + struct samu *newpwd, char >> isupdate); + +BOOL sql_account_config_valid(const char *data); + >> +#endif /* _PDB_SQL_H */ + >> >> >> This was sent by the SourceForge.net collaborative development >> platform, the world's largest Open Source development site. >> >> ------------------------------------------------------------------------- >> Check out the new SourceForge.net Marketplace. It's the best place >> to buy or sell services for just about anything Open Source. >> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace >> >> >> > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iQCVAwUBSCuIHgy0JeEGD2blAQJBtgP9Evkbvpve/Z0bGeFwVEYpYZz1bRkytSpY > VCqG/mujJJDdO04jFVJGTYZIGBWLy0/JyU2A+J6F/vlUuSeMYgjwHE9jEQPT4h+8 > zVT4NfrJlaKpVp7+cue8PYVeTgkUmwlyrhMxOzvlynh9rE9k1ySFkAQ9RISwgspR > puBC99TO+Vg= > =Gaf6 > -----END PGP SIGNATURE----- > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > |
|
From: Jelmer V. <je...@sa...> - 2008-05-15 00:47:39
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Collen, Sorry it's been so long since I've actually read this list... Thanks for working on a 3.2-compatible release! I'm still happy to answer any questions wrt the plugin, though you may have to ping me personally since I don't read the list very often. Could you please copy the actual branch rather than the individual files? This messes up the history of the files, removing some of the usefulness of Subversion, and it spams the list like crazy. Somewhat related to this; please only claim copyright on a file when you make more than a trivial contribution (such as a typo). Happy hacking :-) Cheers, Jelmer co...@us... wrote: > Revision: 90 > http://pdbsql.svn.sourceforge.net/pdbsql/?rev=90&view=rev Author: > collen Date: 2008-01-09 08:12:43 -0800 (Wed, 09 Jan 2008) > > Log Message: ----------- Beta -> 3.0.25 - 3.0.28 > > Added Paths: ----------- > branches/pdbsql/samba-pdbsql-3028/pdb_sql.h > > Copied: branches/pdbsql/samba-pdbsql-3028/pdb_sql.h (from rev 89, > trunk/pdb_sql.h) > =================================================================== > --- branches/pdbsql/samba-pdbsql-3028/pdb_sql.h > (rev 0) +++ branches/pdbsql/samba-pdbsql-3028/pdb_sql.h 2008-01-09 > 16:12:43 UTC (rev 90) @@ -0,0 +1,47 @@ +/* + * Common PDB SQL > backend functions + * Copyright (C) Jelmer Vernooij 2003-2004 + * + > * This program is free software; you can redistribute it and/or > modify it under + * the terms of the GNU General Public License as > published by the Free + * Software Foundation; either version 2 of > the License, or (at your option) + * any later version. + * + * > This program is distributed in the hope that it will be useful, but > WITHOUT + * ANY WARRANTY; without even the implied warranty of > MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the > GNU General Public License for + * more details. + * + * You should > have received a copy of the GNU General Public License along with + > * this program; if not, write to the Free Software Foundation, > Inc., 675 + * Mass Ave, Cambridge, MA 02139, USA. + */ + +#include > "includes.h" + +#ifndef _PDB_SQL_H +#define _PDB_SQL_H + +enum > sql_search_field { + SQL_SEARCH_NONE = 0, + SQL_SEARCH_USER_SID = > 1, + SQL_SEARCH_USER_NAME = 2 +}; + + +char > *sql_escape_string(TALLOC_CTX *mem_ctx, const char *unesc); + +char > *sql_account_query_select(TALLOC_CTX *mem_ctx, const char *data, + > BOOL update, enum sql_search_field field, + const char > *value); + +char *sql_account_query_delete(TALLOC_CTX *mem_ctx, > const char *data, + const char *esc); + +char > *sql_account_query_update(TALLOC_CTX *mem_ctx, const char > *location, + struct samu *newpwd, char > isupdate); + +BOOL sql_account_config_valid(const char *data); + > +#endif /* _PDB_SQL_H */ + > > > This was sent by the SourceForge.net collaborative development > platform, the world's largest Open Source development site. > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. It's the best place > to buy or sell services for just about anything Open Source. > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iQCVAwUBSCuIHgy0JeEGD2blAQJBtgP9Evkbvpve/Z0bGeFwVEYpYZz1bRkytSpY VCqG/mujJJDdO04jFVJGTYZIGBWLy0/JyU2A+J6F/vlUuSeMYgjwHE9jEQPT4h+8 zVT4NfrJlaKpVp7+cue8PYVeTgkUmwlyrhMxOzvlynh9rE9k1ySFkAQ9RISwgspR puBC99TO+Vg= =Gaf6 -----END PGP SIGNATURE----- |
