Menu
▾
▴
pcmanfm-develop
|
From: PCMan <pcm...@gm...> - 2011-06-11 17:21:56
|
Hi all, I'm here to call for a review for PCManFM as the source code in git is in quite good shape now. Many known bugs are fixed and I did much refactor to the tabbed browsing part and merge changes in tab-rework3 branch with master. Please help test and update translations in various distros. If things are ok, I propose a new release. Some major changes: 1. "Reload Folder" is available now in View menu. 2. "Directory Tree" mode is available in side pane. 3. Filesystem size is updated in a more correctly and efficient way. 4. Many bugs causing crashes are fixed. 5. Shows a warning icon in toolbar when running as "root". 6. Supports menu keys. minor changes: 1. Fixed some memory leaks. 2. ~ and / to move focus to location bar 3. Improve internal structure of PCManFM. 4. Code cleanup. A new release as 0.9.9 is required. Please help review and test the code in git. Thanks a lot. |
|
From: Martin B. / b. <br...@bs...> - 2011-06-11 17:51:44
|
On Sun, 12 Jun 2011, PCMan wrote: > Please help test and update translations in various distros. If things > are ok, I propose a new release. PO files at Pootle (and in git ofc) are updated; these are the stats: LC Done Fuzzy Todo Ratio af 0 0 159 0,0% am 0 0 159 0,0% ar 30 3 126 18,9% be 144 6 9 90,6% bg 150 3 6 94,3% bn 144 6 9 90,6% bn_IN 0 0 159 0,0% bs 0 0 159 0,0% ca 137 13 9 86,2% cs 148 5 6 93,1% da 148 5 6 93,1% de 148 5 6 93,1% el 150 3 6 94,3% en_GB 150 3 6 94,3% es 150 3 6 94,3% es_VE 0 0 159 0,0% et 0 0 159 0,0% eu 0 0 159 0,0% fa 148 5 6 93,1% fi 149 3 7 93,7% fo 144 6 9 90,6% fr 150 3 6 94,3% gl 151 5 3 95,0% he 151 5 3 95,0% hr 122 2 35 76,7% hu 148 5 6 93,1% id 146 6 7 91,8% it 150 3 6 94,3% ja 148 5 6 93,1% jv 0 0 159 0,0% kk 0 0 159 0,0% km 47 5 107 29,6% ko 0 0 159 0,0% lg 150 3 6 94,3% li 0 0 159 0,0% lt 150 3 6 94,3% lv 146 5 8 91,8% ml 0 0 159 0,0% ms 0 0 159 0,0% nb 0 0 159 0,0% nl 150 3 6 94,3% nn 0 0 159 0,0% pa 141 5 13 88,7% pl 150 3 6 94,3% ps 0 0 159 0,0% pt 150 3 6 94,3% pt_BR 152 3 4 95,6% ro 0 0 159 0,0% ru 150 3 6 94,3% si 40 0 119 25,2% sk 145 8 6 91,2% sl 150 3 6 94,3% sr 148 5 6 93,1% sr@latin 148 5 6 93,1% sv 151 5 3 95,0% te 150 3 6 94,3% th 0 0 159 0,0% tr 150 3 6 94,3% uk 150 3 6 94,3% ur 0 0 159 0,0% ur_PK 0 0 159 0,0% vi 150 3 6 94,3% zh_CN 150 3 6 94,3% zh_TW 137 5 17 86,2% you probably ant to check libfm also: LC Done Fuzzy Todo Ratio af 0 0 184 0,0% am 0 0 184 0,0% ar 19 0 165 10,3% be 135 3 46 73,4% bg 179 1 4 97,3% bn 130 4 50 70,7% bn_IN 0 0 184 0,0% bs 0 0 184 0,0% ca 130 4 50 70,7% cs 179 1 4 97,3% da 179 1 4 97,3% de 163 17 4 88,6% el 179 1 4 97,3% en_GB 179 1 4 97,3% es 179 1 4 97,3% es_VE 0 129 55 0,0% et 0 0 184 0,0% eu 0 0 184 0,0% fa 179 1 4 97,3% fi 176 2 6 95,7% fo 178 1 5 96,7% fr 179 1 4 97,3% gl 181 0 3 98,4% he 179 1 4 97,3% hr 162 1 21 88,0% hu 179 1 4 97,3% id 135 3 46 73,4% it 179 1 4 97,3% ja 179 1 4 97,3% jv 0 0 184 0,0% kk 0 0 184 0,0% km 0 0 184 0,0% ko 0 0 184 0,0% lg 179 1 4 97,3% lt 179 2 3 97,3% ml 0 0 184 0,0% ms 0 0 184 0,0% nb 0 0 184 0,0% nl 179 1 4 97,3% nn 0 0 184 0,0% pa 0 0 184 0,0% pl 179 1 4 97,3% ps 0 0 184 0,0% pt 179 1 4 97,3% pt_BR 181 0 3 98,4% ro 0 0 184 0,0% ru 179 1 4 97,3% si 0 0 184 0,0% sk 151 28 5 82,1% sl 179 1 4 97,3% sr 155 25 4 84,2% sr@latin 155 25 4 84,2% sv 179 1 4 97,3% te 179 1 4 97,3% th 0 0 184 0,0% tr 179 1 4 97,3% uk 179 1 4 97,3% ur 0 0 184 0,0% ur_PK 0 0 184 0,0% vi 179 1 4 97,3% zh_CN 179 1 4 97,3% zh_TW 138 2 44 75,0% -- /brother http://martin.bagge.nu Bruce found a secure way to reuse a one-time pad. |
|
From: Chris <cyb...@gm...> - 2011-06-13 15:42:18
|
Aloha oukou, I've read all the other mails as well, but wanted to reply to this one. Is there an easy way to update/translate sections? I might be able to help in nl and on a side note; which language is the base as no language is 100% translated? With metta, Chris Druif On Sat, Jun 11, 2011 at 19:51, Martin Bagge / brother <br...@bs...>wrote: > On Sun, 12 Jun 2011, PCMan wrote: > >> Please help test and update translations in various distros. If things >> are ok, I propose a new release. >> > > PO files at Pootle (and in git ofc) are updated; these are the stats: > > LC Done Fuzzy Todo Ratio > af 0 0 159 0,0% > am 0 0 159 0,0% > ar 30 3 126 18,9% > be 144 6 9 90,6% > bg 150 3 6 94,3% > bn 144 6 9 90,6% > bn_IN 0 0 159 0,0% > bs 0 0 159 0,0% > ca 137 13 9 86,2% > cs 148 5 6 93,1% > da 148 5 6 93,1% > de 148 5 6 93,1% > el 150 3 6 94,3% > en_GB 150 3 6 94,3% > es 150 3 6 94,3% > es_VE 0 0 159 0,0% > et 0 0 159 0,0% > eu 0 0 159 0,0% > fa 148 5 6 93,1% > fi 149 3 7 93,7% > fo 144 6 9 90,6% > fr 150 3 6 94,3% > gl 151 5 3 95,0% > he 151 5 3 95,0% > hr 122 2 35 76,7% > hu 148 5 6 93,1% > id 146 6 7 91,8% > it 150 3 6 94,3% > ja 148 5 6 93,1% > jv 0 0 159 0,0% > kk 0 0 159 0,0% > km 47 5 107 29,6% > ko 0 0 159 0,0% > lg 150 3 6 94,3% > li 0 0 159 0,0% > lt 150 3 6 94,3% > lv 146 5 8 91,8% > ml 0 0 159 0,0% > ms 0 0 159 0,0% > nb 0 0 159 0,0% > nl 150 3 6 94,3% > nn 0 0 159 0,0% > pa 141 5 13 88,7% > pl 150 3 6 94,3% > ps 0 0 159 0,0% > pt 150 3 6 94,3% > pt_BR 152 3 4 95,6% > ro 0 0 159 0,0% > ru 150 3 6 94,3% > si 40 0 119 25,2% > sk 145 8 6 91,2% > sl 150 3 6 94,3% > sr 148 5 6 93,1% > sr@latin 148 5 6 93,1% > sv 151 5 3 95,0% > te 150 3 6 94,3% > th 0 0 159 0,0% > tr 150 3 6 94,3% > uk 150 3 6 94,3% > ur 0 0 159 0,0% > ur_PK 0 0 159 0,0% > vi 150 3 6 94,3% > zh_CN 150 3 6 94,3% > zh_TW 137 5 17 86,2% > > > > you probably ant to check libfm also: > LC Done Fuzzy Todo Ratio > af 0 0 184 0,0% > am 0 0 184 0,0% > ar 19 0 165 10,3% > be 135 3 46 73,4% > bg 179 1 4 97,3% > bn 130 4 50 70,7% > bn_IN 0 0 184 0,0% > bs 0 0 184 0,0% > ca 130 4 50 70,7% > cs 179 1 4 97,3% > da 179 1 4 97,3% > de 163 17 4 88,6% > el 179 1 4 97,3% > en_GB 179 1 4 97,3% > es 179 1 4 97,3% > es_VE 0 129 55 0,0% > et 0 0 184 0,0% > eu 0 0 184 0,0% > fa 179 1 4 97,3% > fi 176 2 6 95,7% > fo 178 1 5 96,7% > fr 179 1 4 97,3% > gl 181 0 3 98,4% > he 179 1 4 97,3% > hr 162 1 21 88,0% > hu 179 1 4 97,3% > id 135 3 46 73,4% > it 179 1 4 97,3% > ja 179 1 4 97,3% > jv 0 0 184 0,0% > kk 0 0 184 0,0% > km 0 0 184 0,0% > ko 0 0 184 0,0% > lg 179 1 4 97,3% > lt 179 2 3 97,3% > ml 0 0 184 0,0% > ms 0 0 184 0,0% > nb 0 0 184 0,0% > nl 179 1 4 97,3% > nn 0 0 184 0,0% > pa 0 0 184 0,0% > pl 179 1 4 97,3% > ps 0 0 184 0,0% > pt 179 1 4 97,3% > pt_BR 181 0 3 98,4% > ro 0 0 184 0,0% > ru 179 1 4 97,3% > si 0 0 184 0,0% > sk 151 28 5 82,1% > sl 179 1 4 97,3% > sr 155 25 4 84,2% > sr@latin 155 25 4 84,2% > sv 179 1 4 97,3% > te 179 1 4 97,3% > th 0 0 184 0,0% > tr 179 1 4 97,3% > uk 179 1 4 97,3% > ur 0 0 184 0,0% > ur_PK 0 0 184 0,0% > vi 179 1 4 97,3% > zh_CN 179 1 4 97,3% > zh_TW 138 2 44 75,0% > > -- > /brother > http://martin.bagge.nu > Bruce found a secure way to reuse a one-time pad. > > > _______________________________________________ > Mailing list: https://launchpad.net/~lubuntu-desktop > Post to : lub...@li... > Unsubscribe : https://launchpad.net/~lubuntu-desktop > More help : https://help.launchpad.net/ListHelp > |
|
From: Martin B. / b. <br...@bs...> - 2011-06-13 21:42:58
|
On Mon, 13 Jun 2011, Chris wrote: > I've read all the other mails as well, but wanted to reply to this one. Is > there an easy way to update/translate sections? I might be able to help in > nl and on a side note; which language is the base as no language is 100% > translated? English is the base language, if you know another language better you can use that as base but it is not really supported and you have to do stuff wourself. It's outside of using Pootle as tool at least. Doing the updates and stuff is very easy, I use intltool-update and some helper scripts around git to do the things. Most are executed by cron and it pings me when I need to manually solve things. Merge conflicts and such. nl got a new translator recently and he is very active (in cc) and you guys should take a chat offlist and stuff. Ping me if you need some assistance in any way. Welcome! -- /brother http://martin.bagge.nu BRUCE SCHNEIER understands that all finite sets are countable , but not all countable sets are finite. |
|
From: Martin B. / b. <br...@bs...> - 2011-06-11 20:19:43
|
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On Sun, 12 Jun 2011, PCMan wrote:
> Hi all,
> I'm here to call for a review for PCManFM as the source code in git is
> in quite good shape now.
> Many known bugs are fixed and I did much refactor to the tabbed
> browsing part and merge changes in tab-rework3 branch with master.
> Please help test and update translations in various distros. If things
> are ok, I propose a new release.
First impressions is that it works fine.
I've built and installed it at Debian Testing.
Three strings in libfm:sc/gtk/fm-side-pane.c was not translatable
rendering the menu thingie for the side pane (click "places" and you
should be able to select directory tree (or places if you already had the
tree showing))
line 49-51
{"Places", NULL, N_("Places"), NULL, NULL, FM_SP_PLACES},
{"DirTree", NULL, N_("Directory Tree"), NULL, NULL, FM_SP_DIR_TREE},
{"Remote", NULL, N_("Remote"), NULL, NULL, FM_SP_REMOTE},
I did translate these strings somewhere but they were not used in this
particular menu, the view menu works as intended. As well as the labeling.
Screenie:
http://lxde.bsnet.se/~brother/2011-06-libfm_places_menu.png
Also!
It would be a good thing if some native speaker could check the
strings for both libfm and pcmanfm. I am not a native speaker and I
haven't read all the strings for a very long time but they probably can be
improved given that pcman isn't a native speaker either. If you know of
anyone being able to do this let them/me know.
- --
/brother
http://martin.bagge.nu
Bruce Schneier reads RFID cards with the knuckles of his clenched fist.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iQEcBAEBCAAGBQJN883SAAoJEJbdSEaj0jV7sT8H/0uqAXhvjrZU1yfVC44LIJdI
4vqkhHq9gxlJLWlOMrKQCfZaocYfR6WafRbc32bcq+IbV1cBXsFMYlTt4BoJY26d
r43gqqJnoI1dVRD11mhxEO3jIGK+yTY+zqhkEOvOKjwc7+0UCz3/0mFDkEmyQiqx
inr4esM27B9ZSj31ope9mA3hdX4tzpuMXhpeNYleAG3QYP5wHfZPSiCsEoMNysOW
l6vjbIM59XHqSJ3h7ii+gTFuPuwH0Fx78v+dqbzHOl6W0Hyvz0e19xJdTnQ5BNHn
8iC4d5votNoAbfcFaqEQyoHYGt1+p6jV3CYmeWgO3nbxpomntXwROvEUY6C9N/o=
=32Bh
-----END PGP SIGNATURE-----
|
|
From: Sergio C. <sec...@gm...> - 2011-06-11 20:48:05
|
Thank you, pcman. I'll comment on the interface things as it seems everything is working (I don't have remote filesystems to test that). The drop-down in the side-pane doesn't show translated, as Martin said. Regarding the new sign for pcmanfm as root, first I agree it should be changed because setting the tooltip colour to the address bar sometimes would leave the text and the background with the same colour. For me that old warning icon in the address bar was fine. The new icon, depending on the icon theme, can be almost unoticeable. It should be the dialog-warning icon. |
|
From: Sergio C. <sec...@gm...> - 2011-06-11 21:04:47
|
It's still showing the filesystem in the side-pane untranslated. libfm/src/udisks/g-udisks-volume.c, line 241. |
|
From: Cilyan O. <ga...@gm...> - 2011-06-11 23:31:38
|
Hello all, After a crash of my disk, I'm no longer on ArchLinux, but there the pcmanfm-git PKGBUILD from aur could not compile. Did you check that ? http://sourceforge.net/mailarchive/forum.php?thread_name=BANLkTinj4%2BqhE5PtFBfer88zsxqAFdfz%2Bw%40mail.gmail.com&forum_name=lxde-list Regards, 2011/6/11 Sergio Cipolla <sec...@gm...>: > It's still showing the filesystem in the side-pane untranslated. > libfm/src/udisks/g-udisks-volume.c, line 241. > ------------------------------------------------------------------------------ > EditLive Enterprise is the world's most technically advanced content > authoring tool. Experience the power of Track Changes, Inline Image > Editing and ensure content is compliant with Accessibility Checking. > http://p.sf.net/sfu/ephox-dev2dev > _______________________________________________ > Lxde-i18n mailing list > Lxd...@li... > https://lists.sourceforge.net/lists/listinfo/lxde-i18n > > |
|
From: PCMan <pcm...@gm...> - 2011-06-12 01:57:55
|
The side pane menu should be translatable now. (fixed in git) The strings are in libfm, not pcmanfm. Cheers! On Sun, Jun 12, 2011 at 7:31 AM, Cilyan Olowen <ga...@gm...> wrote: > Hello all, > > After a crash of my disk, I'm no longer on ArchLinux, but there the > pcmanfm-git PKGBUILD from aur could not compile. Did you check that ? > > http://sourceforge.net/mailarchive/forum.php?thread_name=BANLkTinj4%2BqhE5PtFBfer88zsxqAFdfz%2Bw%40mail.gmail.com&forum_name=lxde-list > > Regards, > > 2011/6/11 Sergio Cipolla <sec...@gm...>: >> It's still showing the filesystem in the side-pane untranslated. >> libfm/src/udisks/g-udisks-volume.c, line 241. >> ------------------------------------------------------------------------------ >> EditLive Enterprise is the world's most technically advanced content >> authoring tool. Experience the power of Track Changes, Inline Image >> Editing and ensure content is compliant with Accessibility Checking. >> http://p.sf.net/sfu/ephox-dev2dev >> _______________________________________________ >> Lxde-i18n mailing list >> Lxd...@li... >> https://lists.sourceforge.net/lists/listinfo/lxde-i18n >> >> > |
|
From: Sergio C. <sec...@gm...> - 2011-06-12 12:01:13
|
@ Cilyan, that should be fixed by now. If you can try the latest libfm/pcmanfm. PCMan, thank you. I haven't built the latest yet to test but the one from yesterday had one other thing that wasn't set as translatable. When selecting more than one file/folder, it shows "X items selected" in English. Maybe it's from libfm/src/demo/main-win.c, line 236. Regards. |
|
From: Cilyan O. <ga...@gm...> - 2011-06-12 16:37:30
|
2011/6/12 Sergio Cipolla <sec...@gm...>: > @ Cilyan, that should be fixed by now. If you can try the latest > libfm/pcmanfm. > PCMan, thank you. I haven't built the latest yet to test but the one from > yesterday had one other thing that wasn't set as translatable. When > selecting more than one file/folder, it shows "X items selected" in English. > Maybe it's from libfm/src/demo/main-win.c, line 236. > Regards. > ------------------------------------------------------------------------------ > EditLive Enterprise is the world's most technically advanced content > authoring tool. Experience the power of Track Changes, Inline Image > Editing and ensure content is compliant with Accessibility Checking. > http://p.sf.net/sfu/ephox-dev2dev > _______________________________________________ > Lxde-i18n mailing list > Lxd...@li... > https://lists.sourceforge.net/lists/listinfo/lxde-i18n > > Indeed, I'm back on ArchLinux (yes, this was only a one day trip!) and it works I'm testing it now to see if it works OK. Regards, Cilyan |
|
From: Julien L. <gi...@ub...> - 2011-06-13 10:42:24
|
Le Sunday 12 June 2011 à 01:21 +0800, PCMan a écrit : > > A new release as 0.9.9 is required. Please help review and test the code in git. > Thanks a lot. Thanks PCMan. So far, It's working nice on L/Ubuntu 10.10. Some comments : - Please bump the soname of your library each time you change your API. Distributions can do smooth transitions between versions of libfm/pcmanfm. Also, if you expect other applications to use libfm, you need to use the soname. - Is it possible to force a reload when you do any operations on a remote place ? When I create a file on my sftp place, I expect that it appears on pcmanfm after the creation. Monitoring is not needed, but any user interactions should affect what pcmanfm shows. - I'm not sure having the tabs above the sidebar is good. I personally prefer to have them just above the main window, like Nautilus do. But maybe other people like this behavior ? - Don't hesitate to do releases often, it's better for distributions :) Even if bugs are discovered shortly after the release, you can still do a quick X.X.1 release to fix this. Regards, Julien Lavergne |
|
From: PCMan <pcm...@gm...> - 2011-06-13 11:24:22
|
On Mon, Jun 13, 2011 at 6:34 PM, Julien Lavergne <gi...@ub...> wrote: > Le Sunday 12 June 2011 à 01:21 +0800, PCMan a écrit : >> >> A new release as 0.9.9 is required. Please help review and test the code in git. >> Thanks a lot. > > Thanks PCMan. So far, It's working nice on L/Ubuntu 10.10. > > Some comments : > - Please bump the soname of your library each time you change your API. > Distributions can do smooth transitions between versions of > libfm/pcmanfm. Also, if you expect other applications to use libfm, you > need to use the soname. I want to do this for stable tarball releases only. In current stage of development, change of API/ABIs can be frequent. > - Is it possible to force a reload when you do any operations on a > remote place ? When I create a file on my sftp place, I expect that it > appears on pcmanfm after the creation. Monitoring is not needed, but any > user interactions should affect what pcmanfm shows. PCManFM should show the created files even on remote filesystems right after you create them. Otherwise it's a bug. > - I'm not sure having the tabs above the sidebar is good. I personally > prefer to have them just above the main window, like Nautilus do. But > maybe other people like this behavior ? Firefox + IE + Opera all does this. So does old PCManFM 0.5 series. In addition, design like nautilus greatly limited the usability of tabs since you can only have very few tabs due to limited space. > - Don't hesitate to do releases often, it's better for distributions :) > Even if bugs are discovered shortly after the release, you can still do > a quick X.X.1 release to fix this. Given the program is now used by so many users, it's better to have releases with better quality. > Regards, > Julien Lavergne > > |
|
From: Julien L. <gi...@ub...> - 2011-06-13 13:26:35
|
Le Monday 13 June 2011 à 19:17 +0800, PCMan a écrit : > > - Please bump the soname of your library each time you change your API. > > Distributions can do smooth transitions between versions of > > libfm/pcmanfm. Also, if you expect other applications to use libfm, you > > need to use the soname. > I want to do this for stable tarball releases only. In current stage > of development, change of API/ABIs can be frequent. Ok, but technically, it's used as a "stable" application on, at least, Debian and Ubuntu (and probably many other distributions). So, what is missing for having a stable release of pcmanfm ? Any major features are still missing ? > > - Is it possible to force a reload when you do any operations on a > > remote place ? When I create a file on my sftp place, I expect that it > > appears on pcmanfm after the creation. Monitoring is not needed, but any > > user interactions should affect what pcmanfm shows. > PCManFM should show the created files even on remote filesystems right > after you create them. Otherwise it's a bug. Ok, so it's a bug. I just test it with sftp, and the folder is not refreshed when I create a directory or a file, from right click and "New". > > - I'm not sure having the tabs above the sidebar is good. I personally > > prefer to have them just above the main window, like Nautilus do. But > > maybe other people like this behavior ? > Firefox + IE + Opera all does this. So does old PCManFM 0.5 series. > In addition, design like nautilus greatly limited the usability of > tabs since you can only have very few tabs due to limited space. But I don't think browsers are designed to work full time with a sidebar, like a files manager. I don't think the comparaison is fully accurate. But well, it's just personal taste here :) > > - Don't hesitate to do releases often, it's better for distributions :) > > Even if bugs are discovered shortly after the release, you can still do > > a quick X.X.1 release to fix this. > Given the program is now used by so many users, it's better to have > releases with better quality. But it's better than no release at all, especially for application still in development. Last official release is 2010-10-14 (according to http://sourceforge.net/projects/pcmanfm/files/ ), more than six months ago. Regards, Julien Lavergne |
|
From: Martin B. / b. <br...@bs...> - 2011-06-13 14:11:27
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 2011-06-13 14:27, Julien Lavergne wrote: > Le Monday 13 June 2011 à 19:17 +0800, PCMan a écrit : >>> - Please bump the soname of your library each time you change your API. >>> Distributions can do smooth transitions between versions of >>> libfm/pcmanfm. Also, if you expect other applications to use libfm, you >>> need to use the soname. >> I want to do this for stable tarball releases only. In current stage >> of development, change of API/ABIs can be frequent. > Ok, but technically, it's used as a "stable" application on, at least, > Debian and Ubuntu (and probably many other distributions). > > So, what is missing for having a stable release of pcmanfm ? Any major > features are still missing ? As far as I see it the current git HEAD is not /released/. When that happens a git tag will be produced and a tar ball distributed to sf.net project pages. Until then pcman do not want to bump things as they might change numerous times before the release is done. Using git HEAD as source for a package in a distribution is not what pcman wants (and I support this way). >>> - Don't hesitate to do releases often, it's better for distributions :) >>> Even if bugs are discovered shortly after the release, you can still do >>> a quick X.X.1 release to fix this. >>> >> Given the program is now used by so many users, it's better to have >> releases with better quality. >> > But it's better than no release at all, especially for application still > in development. Last official release is 2010-10-14 (according to > http://sourceforge.net/projects/pcmanfm/files/ ), more than six months > ago. I think the "old" saying "release early, release often" is key and important. I do think we should aim for qualty too ofc but with frequent updates it will be there and it will draw even more attention to the product imho. I am with gilir on this one. It also ties together with my notion of not using git HEAD to base packages in distributions on, if there are frequent releases it is more likely the distributions will use $LATEST_TAG rather than giot HEAD. If needed be I am willing to set up a development model with branches for this, this is what I do for a living anyhow (I don't think we do need that though). - -- brother http://sis.bthstudent.se -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJN9hp/AAoJEJbdSEaj0jV7CEUH/ijymzoTwao/8uDfgBHhyl0n 33umPx1IhWBjsfpI3jw6qF7MmaoGorvKJw7XTgx0nvIog8Hv8Qm6nVTjnd8ayvBo +/Dz0hMG65BY6VPc/eoQkWAwkapCJEW+qLC13/SfvrD+fz/8Cn1SxCQPlFIXtJrD DYtKhOXY4cWX5OhGVx/cuIffodZOxpb0uFd+vtCw+eE9SDtJqS3qng3MFu2bZaEk LimpIxiJMzk8d8YYhlPUvcM0ryb8/vXc20ZbVY+G9bCyx9h40Q/rpmT5NXUb4uBJ gIZaSven2zSpIxO7nk7FphULwap9st/dyJtrujLFeCA1DaFMtyK3SOp5QveG430= =yBsk -----END PGP SIGNATURE----- |
|
From: Jonathan M. <jma...@fa...> - 2011-06-13 15:57:01
|
On 06/13/2011 07:11 AM, Martin Bagge / brother wrote: > On 2011-06-13 14:27, Julien Lavergne wrote: >> So, what is missing for having a stable release of pcmanfm ? Any >> major features are still missing ? This is a key question for Lubuntu right now. > Using git HEAD as source for a package in a distribution is not what > pcman wants (and I support this way). Agreed -- and the simplest way to prevent this is to release often enough that distributions do not feel any need to package from git :) >> Last official release is 2010-10-14 ... Which is both fairly old, and also "bad timing" regarding Ubuntu releases, being only about two weeks before the Ubuntu 10.10 final release. SUGGESTION: Let's test the current "almost-0.9.9" codebase, fix any major issues found in the next week or so, then bump the SONAME version and release it before the end of June 2011. Can we do that? Since some testers seem to need packaged versions to test, I'll look at creating a test unofficial package from git for them, so we get slightly more testing. Another way to go would be to release a 0.9.9~rc1 tarball, and a corresponding one for libfm, if that is preferred -- doing that means noone has to use git head for packaging :) Jonathan |
|
From: PCMan <pcm...@gm...> - 2011-06-13 17:12:14
|
On Mon, Jun 13, 2011 at 11:48 PM, Jonathan Marsden <jma...@fa...> wrote: > On 06/13/2011 07:11 AM, Martin Bagge / brother wrote: > >> On 2011-06-13 14:27, Julien Lavergne wrote: > >>> So, what is missing for having a stable release of pcmanfm ? Any >>> major features are still missing ? > > This is a key question for Lubuntu right now. See this: https://sourceforge.net/tracker/?group_id=156956&atid=801864 I give the bugs different priority. The ones with highest priority should be fixed before 0.9.9, I think. Please see if you can help. Personally I will take this one: https://sourceforge.net/tracker/?func=detail&aid=3094303&group_id=156956&atid=801864 This is my bottom line. At least this one should be fixed before 0.9.9. >> Using git HEAD as source for a package in a distribution is not what >> pcman wants (and I support this way). > > Agreed -- and the simplest way to prevent this is to release often > enough that distributions do not feel any need to package from git :) Yes, so I plan to make a new release and asked for testing here. In the past I mistakenly released some broken stuff, and this should not happen again, especially when there are more and more people using this. >>> Last official release is 2010-10-14 ... > > Which is both fairly old, and also "bad timing" regarding Ubuntu > releases, being only about two weeks before the Ubuntu 10.10 final release. > > SUGGESTION: Let's test the current "almost-0.9.9" codebase, fix any > major issues found in the next week or so, then bump the SONAME version > and release it before the end of June 2011. Can we do that? Yes, if with help from the community. No if I do it myself. Patches from Lubuntu is appreciated. > Since some testers seem to need packaged versions to test, I'll look at > creating a test unofficial package from git for them, so we get slightly > more testing. Another way to go would be to release a 0.9.9~rc1 > tarball, and a corresponding one for libfm, if that is preferred -- > doing that means noone has to use git head for packaging :) That's true. > Jonathan Actually I have a primitive button-style path bar implemented in libfm already, but I don't have time yet to add it to pcmanfm. I decided to do it next time. Let's fix the important bugs first and make a good release first. |
|
From: Sergio C. <sec...@gm...> - 2011-06-13 18:05:56
|
I'm not a developer and I can't talk about the distribution side of it, but I'm with pcman in the sense that he has been improving and fixing bugs in pcmanfm in a very sensible way, so after accompanying the development process for some time I trust his priorities. Also Ubuntu isn't a parameter for launching nothing (except its own applications). |
|
From: Jonathan M. <jma...@fa...> - 2011-06-14 05:05:49
|
On Tue, 14 Jun 2011 01:12:06 +0800 PCMan <pcm...@gm...> wrote: > https://sourceforge.net/tracker/?group_id=156956&atid=801864 OK, thanks, that's good to know. >> SUGGESTION: Let's test the current "almost-0.9.9" codebase, fix any >> major issues found in the next week or so, then bump the SONAME version >> and release it before the end of June 2011. Can we do that? > Yes, if with help from the community. No if I do it myself. > Patches from Lubuntu is appreciated. Since you mentioned it: I *already* turned libfm patches from Julien's Ubuntu package of libfm into a git repo for you, six commits, and posted about doing that to this list. All that was left for you to do was to cherrypick which ones you want to include in the upstream sources: https://lists.launchpad.net/lubuntu-desktop/msg03977.html As far as I can see, *none* of them have been included so far! Either I did something wrong, or else you don't really want those patches? Help me understand what I have to do so you will accept the commits I made for you from Ubuntu patches, please. >> Since some testers seem to need packaged versions to test, I'll look at >> creating a test unofficial package from git for them, so we get slightly >> more testing. Another way to go would be to release a 0.9.9~rc1 >> tarball, and a corresponding one for libfm, if that is preferred -- >> doing that means noone has to use git head for packaging :) > That's true. I'm playing with writing a script to grab the libfm git head and Julien's package and automatically create a new package based on the combination of the two. It doesn't quite work yet... if it does, I'll try to do the same for pcmanfm, and then we can create test packages for pcmanfm testers much more easily :) Jonathan |
|
From: PCMan <pcm...@gm...> - 2011-06-19 05:07:40
|
Thank you for the patches. I took some time to look at them and found
some issues.
jmarsden committed 1963619
Add LINGUAS, reference doc files and libfm-pref-apps.desktop launcher:
We do not translate desktop files directly. Neither do we commit the
translated desktop files.
We did the translation for desktop files in po files, and only put
*.desktop.in files in git.
So the translation should go to *.po, and merged with *.desktop.in
during build process.
jmarsden committed 530ac5a
Ensure correct icon is used in panel.
A better fix is to set the icon-name property for the window in
GtkBuilder glade file instead.
We generally avoid building dialog UI in source code and tend to use
GtkBuilder instead when applicable.
jmarsden committed 284a164
Add GLIB_LIBS when linking documentation.
This seems to be fine, but I'm not sure which files should be pushed
to git repo since some are generated files.
jmarsden committed b61f3d6
Disable deprecated gio code by default.
This looks fine, but will this affect distros with older versions of glib?
jmarsden committed 618594e
API change deprecating fmpath_new
This one looks fine.
jmarsden committed 09b6061
Specify default terminal emulator (was: 01-lxde-conf.patch in Ubuntu
The x-terminal-emulator thing IIRC is Debian-specific. So this better
goes to debian package rather than upstream.
On Tue, Jun 14, 2011 at 1:05 PM, Jonathan Marsden <jma...@fa...> wrote:
> On Tue, 14 Jun 2011 01:12:06 +0800 PCMan <pcm...@gm...> wrote:
>
>> https://sourceforge.net/tracker/?group_id=156956&atid=801864
>
> OK, thanks, that's good to know.
>
>>> SUGGESTION: Let's test the current "almost-0.9.9" codebase, fix any
>>> major issues found in the next week or so, then bump the SONAME version
>>> and release it before the end of June 2011. Can we do that?
>
>> Yes, if with help from the community. No if I do it myself.
>> Patches from Lubuntu is appreciated.
>
> Since you mentioned it:
>
> I *already* turned libfm patches from Julien's Ubuntu package of
> libfm into a git repo for you, six commits, and posted about doing
> that to this list. All that was left for you to do was to cherrypick
> which ones you want to include in the upstream sources:
>
> https://lists.launchpad.net/lubuntu-desktop/msg03977.html
>
> As far as I can see, *none* of them have been included so far! Either I did
> something wrong, or else you don't really want those patches? Help me
> understand what I have to do so you will accept the commits I made for you from
> Ubuntu patches, please.
>
>>> Since some testers seem to need packaged versions to test, I'll look at
>>> creating a test unofficial package from git for them, so we get slightly
>>> more testing. Another way to go would be to release a 0.9.9~rc1
>>> tarball, and a corresponding one for libfm, if that is preferred --
>>> doing that means noone has to use git head for packaging :)
>
>> That's true.
>
> I'm playing with writing a script to grab the libfm git head and
> Julien's package and automatically create a new package based on the
> combination of the two. It doesn't quite work yet... if it does, I'll
> try to do the same for pcmanfm, and then we can create test packages for
> pcmanfm testers much more easily :)
>
> Jonathan
>
|
|
From: Jonathan M. <jma...@fa...> - 2011-06-18 07:53:51
|
>>>> So, what is missing for having a stable release of pcmanfm ? Any >>>> major features are still missing ? On 06/13/2011 10:12 AM, PCMan wrote: > https://sourceforge.net/tracker/?group_id=156956&atid=801864 > I give the bugs different priority. The ones with highest priority > should be fixed before 0.9.9, I think. Please see if you can help. > Personally I will take this one: > https://sourceforge.net/tracker/?func=detail&aid=3094303&group_id=156956&atid=801864 > This is my bottom line. At least this one should be fixed before 0.9.9. An interesting choice of #1 bug. I'd think that any "kills the app" bugs should perhaps have higher priority than a missing drag and drop bookmarking feature? So, if it can be reproduced in current code, I'd suggest that > http://sourceforge.net/tracker/?func=detail&aid=3131504&group_id=156956&atid=801864 might need addressing fairly urgently? COPYRIGHT/LICENSING: In packaging from the pcmanfm git head, since we don't have a 0.9.9~rc1 tarball to work from, I found a few minor copyright-related or license-related issues that it would be good to get tidied up before a tarball release, if possible: (1) Copyright statements generally say 2009-2010, and it is now 2011. (2) The translatable one that shows in the About dialog box also does this, so this may be annoying to fix, because it will need matching fixes in every translation file! (3) A couple of source files seem to lack a copyright and licence statement: src/xml-purge.c: *No copyright* UNKNOWN autogen.sh: *No copyright* UNKNOWN I realize autogen.sh is just a short script, but technically it is source code in the application source tree, so it should be treated like all other source code files as far as copyright and licensing go. (4) One has a rather different copyright, and a license statement that needs fixing: src/gseal-gtk-compat.h: LGPL (with incorrect FSF address) However the only COPYRIGHT file in the source tree is the GPLv2 one, not an LGPL one. Also, this file is not mentioned in debian/copyright as having different authorship or license from the rest of the sources. (This may be a packaging bug at least as much as an upstream application source bug!) BACKWARD COMPATIBILITY: As Julien mentioned, a libfm SONAME version bump seems to be needed. Some symbols are now missing that were present in earlier library versions, so (as I understand it) backward compatibility with those versions of the library has now been lost. AUTOMATED PACKAGE BUILDS: Earlier, I wrote: >> Since some testers seem to need packaged versions to test, I'll >> look at creating a test unofficial package from git for them, so >> we get slightly more testing. I have made good progress with this, and expect there will be test packages automatically showing up in my ppa:jmarsden/lubuntu in a few hours, for both libfm and pcmanfm. We can decide where we really want such automatically generated test packages to go once it actually works -- maybe there is already an appropriate pcmanfm or LXDE PPA for this? My work so far on recipes for doing this is at: https://code.launchpad.net/~jmarsden/+recipe/libfm-daily https://code.launchpad.net/~jmarsden/+recipe/pcmanfm-daily Packages built this way locally on my own PC (as opposed to being built automatically on Canonical-managed build machines) work for me, at least in my limited testing so far, in an Lubuntu 11.04 virtual machine. IMPROVING TEST COVERAGE: One more thought about increased test coverage, since you mentioned you are wary of releasing code that is buggy: currently both the libfm and pcmanfm packages disable the test suites... fixing things so the test suites work, so we can enable them at package build time, would be a helpful way to minimize regression bugs. I have not looked at this in any depth -- do we have any sense of how much work it will be to get the current test suites for libfm and pcmanfm to the point that the current (git head) code passes them? Thanks, Jonathan |
|
From: Jonathan M. <jma...@fa...> - 2011-06-18 08:02:37
|
On 06/18/2011 12:53 AM, Jonathan Marsden wrote: > On 06/13/2011 10:12 AM, PCMan wrote: >> https://sourceforge.net/tracker/?group_id=156956&atid=801864 I think we might also want to go through the bugs reported at https://bugs.launchpad.net/ubuntu/+source/pcmanfm since some of these look like "pcmanfm crashes if you do *this*" type of bugs, which IMO are important to fix, if they can be reproduced. Jonathan |
|
From: Martin B. / b. <br...@bs...> - 2011-06-23 13:07:05
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 2011-06-18 09:53, Jonathan Marsden wrote: > (1) Copyright statements generally say 2009-2010, and it is now 2011. Probably due to no release in 2011. > (2) The translatable one that shows in the About dialog box also does > this, so this may be annoying to fix, because it will need matching > fixes in every translation file! For languages using standard numbers I can take care of this change. I did something similar for a tab character bug in gpicview last night. When we go into the release process the fuzzy string of 2010->2011 will get treated too on the other hand. > (3) A couple of source files seem to lack a copyright and licence statement: > src/xml-purge.c: *No copyright* UNKNOWN > autogen.sh: *No copyright* UNKNOWN > (4) One has a rather different copyright, and a license statement that > needs fixing: > src/gseal-gtk-compat.h: LGPL (with incorrect FSF address) For debian this is RC and will possibly prevent pcmanfm from being included in the stable release. > AUTOMATED PACKAGE BUILDS: >>> Since some testers seem to need packaged versions to test, I'll >>> look at creating a test unofficial package from git for them, so >>> we get slightly more testing. > > I have made good progress with this, and expect there will be test > packages automatically showing up in my ppa:jmarsden/lubuntu in a few I have been working on getting better shape of the server that hosts the buildbot. I was thinking about adding a auto export at the end of each successful build. The plan is also to get the code tree updates to trigger builds (I do them by hand at the moment). By doing this we could keep X number of builds for each component in something like http://latest.lxde.bsnet.se/$COMPONENT/filename.tar.gz - -- brother http://sis.bthstudent.se -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJOAzpuAAoJEJbdSEaj0jV7UgYIAIisP+njchHIBJV+UOaFpuBS IbQ3Ur8s5ypm6c04FGEh0WN7u4bCHiMa7/PDe3/8EiwMhm9nAT+g0ZZKgmxAccuj Z8pyoMqh9L/GUtikDQQvkueFZaLHOQZGQ/TtaXQ+BBUVj5068L42uzZxmBEiLSrx /fpHDUR7IL5R7pTIk7KkOHGY12uMWjPAyrr/l2fiE8Yka7G/YSIixXGOv0TNyLbS 0mY0NrGeaP8u77IvigSMgLCOc3v4yF6apVs2IGNaLQ5/ePVsDBseNMWasUc941AI 80tHY+xLvqaNDu1lvO5vwKuqkfG2Ud6rr6FgqEwCb6jIlIBV93b7A3vvKGonfOQ= =20RB -----END PGP SIGNATURE----- |
|
From: Chris <cyb...@gm...> - 2011-06-13 16:08:40
|
Aloha oukou, > >> Last official release is 2010-10-14 ... > > Which is both fairly old, and also "bad timing" regarding Ubuntu > releases, being only about two weeks before the Ubuntu 10.10 final release. > That was 4 days AFTER the Ubuntu 10.10 release. But if you want to get something in L/Ubuntu, you have to keep in mind the Feature Freeze [1] this cycle set on August 11th. With metta, Chris Druif [1] https://wiki.ubuntu.com/FeatureFreeze |
|
From: Sérgio C. <sec...@gm...> - 2011-06-13 22:24:03
|
Martin, you're the git specialist. But regarding releasing LXDE components, maybe some could have a new release. LXTask had a memory leak fixed and was about to be released then nobody talked about it anymore. Most components have much improved translations since they were last released and these could have a minor point release. Now an observation. In a constructive manner. I see that Julien Lavergne is mostly the only one that has been working on the apps but ideally, in a non technical opinion as I'm not a programmer, I think that the master branch in git should be reserved for bug fixes and pre-tested improvements. Untested code (like these recent gtk3 compatibility commits that have broken, for instance, lxpanel and lxterminal in a very basic way or gpicview that has something that looks like a typo and makes it not even compile) would be commited to another branch and then the commiter could ask for testing in the mailing list. The benefits for the workflow and for multiple contributions is evident. |
Thanks for helping keep SourceForge clean.
X