pcmanfm-develop

[Pcmanfm-develop] PCManFM crashes in completion.......

[Andrej N. G. <an...@re...>]

    Hello!

    I've found a bug and cannot find if I can do anything with it. May be
someone else can help. Bug is reproducible with Git version as well as
with any older one:

1) open PCManFM window;
2) enter in prompt some path which doesn't exist (just add a character to
the path which already is in there, no need to press 'Enter');
3) press 'New Tab' button;
4) result is below:

(pcmanfm:26871): Gtk-CRITICAL **: IA__gtk_entry_get_text: assertion `GTK_IS_ENTRY (entry)' failed

Program received signal SIGSEGV, Segmentation fault.
0x00abca79 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
(gdb) bt
#0  0x00abca79 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
#1  0x00abcf76 in g_utf8_normalize () from /lib/i386-linux-gnu/libglib-2.0.so.0
#2  0x00329fca in gtk_entry_completion_complete () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
#3  0x003164ca in ?? () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
#4  0x00a2125c in ?? () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
#5  0x00a04c3c in g_closure_invoke () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
#6  0x00a211ce in ?? () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
#7  0x00a86110 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
#8  0x00a8a25f in g_main_context_dispatch () from /lib/i386-linux-gnu/libglib-2.0.so.0
#9  0x00a8a990 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
#10 0x00a8af9b in g_main_loop_run () from /lib/i386-linux-gnu/libglib-2.0.so.0
#11 0x0039cfcf in gtk_main () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
#12 0x08052a95 in main (argc=1, argv=0xbffff5b4) at pcmanfm.c:227

I don't know how exactly completion works and what could cause that crash
so probably someone of you can help anyhow to find a workaround.

    With best wishes.
    Andriy.

Re: [Pcmanfm-develop] PCManFM crashes in completion.......

[Axel F. <axe...@gm...>]

Maybe "entry" is null here :

http://pcmanfm.git.sourceforge.net/git/gitweb.cgi?p=pcmanfm/libfm;a=blob;f=src/gtk/fm-path-entry.c;h=a4b9b4f3ac507dc54143c15adf61eb0a2e2a5ec3;hb=HEAD#l612

What happens if you add a g_return_val_if_fail like so :

FmPathEntry *entry = FM_PATH_ENTRY(
gtk_entry_completion_get_entry(completion) );

g_return_val_if_fail (entry != NULL, FALSE);



On 07/07/2012 13:08, Andrej N. Gritsenko wrote:
>     Hello!
> 
>     I've found a bug and cannot find if I can do anything with it. May be
> someone else can help. Bug is reproducible with Git version as well as
> with any older one:
> 
> 1) open PCManFM window;
> 2) enter in prompt some path which doesn't exist (just add a character to
> the path which already is in there, no need to press 'Enter');
> 3) press 'New Tab' button;
> 4) result is below:
> 
> (pcmanfm:26871): Gtk-CRITICAL **: IA__gtk_entry_get_text: assertion `GTK_IS_ENTRY (entry)' failed
> 
> Program received signal SIGSEGV, Segmentation fault.
> 0x00abca79 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
> (gdb) bt
> #0  0x00abca79 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
> #1  0x00abcf76 in g_utf8_normalize () from /lib/i386-linux-gnu/libglib-2.0.so.0
> #2  0x00329fca in gtk_entry_completion_complete () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
> #3  0x003164ca in ?? () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
> #4  0x00a2125c in ?? () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
> #5  0x00a04c3c in g_closure_invoke () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
> #6  0x00a211ce in ?? () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
> #7  0x00a86110 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
> #8  0x00a8a25f in g_main_context_dispatch () from /lib/i386-linux-gnu/libglib-2.0.so.0
> #9  0x00a8a990 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
> #10 0x00a8af9b in g_main_loop_run () from /lib/i386-linux-gnu/libglib-2.0.so.0
> #11 0x0039cfcf in gtk_main () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
> #12 0x08052a95 in main (argc=1, argv=0xbffff5b4) at pcmanfm.c:227
> 
> I don't know how exactly completion works and what could cause that crash
> so probably someone of you can help anyhow to find a workaround.
> 
>     With best wishes.
>     Andriy.
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Pcmanfm-develop mailing list
> Pcm...@li...
> https://lists.sourceforge.net/lists/listinfo/pcmanfm-develop
> 

-- 
Axel FILMORE
#--------------------------------------------#
        https://github.com/afilmore
#--------------------------------------------#
 Vala - Compiler For The GObject Type System
        https://live.gnome.org/Vala
#--------------------------------------------#

Re: [Pcmanfm-develop] PCManFM crashes in completion.......

[Andrej N. G. <an...@re...>]

    Hello!

Axel FILMORE has written on Saturday,  7 July, at 13:54:
>Maybe "entry" is null here :

>http://pcmanfm.git.sourceforge.net/git/gitweb.cgi?p=pcmanfm/libfm;a=blob;f=src/gtk/fm-path-entry.c;h=a4b9b4f3ac507dc54143c15adf61eb0a2e2a5ec3;hb=HEAD#l612

>What happens if you add a g_return_val_if_fail like so :

>FmPathEntry *entry = FM_PATH_ENTRY(
>gtk_entry_completion_get_entry(completion) );

>g_return_val_if_fail (entry != NULL, FALSE);

    Unfortunately that doesn't help (I've tried that of course) but if
you missed the fact that Gtk-CRITICAL came from gtk_entry_get_text() but
if that would came from fm_path_entry_match_func() then there should be
a Gtk-Warning before that message complaining the value isn't GTK_ENTRY
as it always happens with macros such as GTK_ENTRY() when GTK debug is
on. And also you can see in GDB output which I've cited it happened
outside of libfm code at all but in some of signal handlers ("on-idle"
perhaps) inside of completion library. :(

>> 1) open PCManFM window;
>> 2) enter in prompt some path which doesn't exist (just add a character to
>> the path which already is in there, no need to press 'Enter');
>> 3) press 'New Tab' button;
>> 4) result is below:
>> 
>> (pcmanfm:26871): Gtk-CRITICAL **: IA__gtk_entry_get_text: assertion `GTK_IS_ENTRY (entry)' failed
>> 
>> Program received signal SIGSEGV, Segmentation fault.
>> 0x00abca79 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
>> (gdb) bt
>> #0  0x00abca79 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
>> #1  0x00abcf76 in g_utf8_normalize () from /lib/i386-linux-gnu/libglib-2.0.so.0
>> #2  0x00329fca in gtk_entry_completion_complete () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
>> #3  0x003164ca in ?? () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
>> #4  0x00a2125c in ?? () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
>> #5  0x00a04c3c in g_closure_invoke () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
>> #6  0x00a211ce in ?? () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
>> #7  0x00a86110 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
>> #8  0x00a8a25f in g_main_context_dispatch () from /lib/i386-linux-gnu/libglib-2.0.so.0
>> #9  0x00a8a990 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
>> #10 0x00a8af9b in g_main_loop_run () from /lib/i386-linux-gnu/libglib-2.0.so.0
>> #11 0x0039cfcf in gtk_main () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
>> #12 0x08052a95 in main (argc=1, argv=0xbffff5b4) at pcmanfm.c:227
>> 
>> I don't know how exactly completion works and what could cause that crash
>> so probably someone of you can help anyhow to find a workaround.

    With the best wishes.
    Andriy.