Help save net neutrality! Learn more.
Close

#267 Display image dimensions in status bar

closed-wont-fix
5
2014-01-06
2012-10-08
No

It would be handy, if pcmanfm would show image dimensions in status bar, when you select it.
Probably, make it as option, so it can be disabled for perfomance.

Discussion

<< < 1 2 (Page 2 of 2)
  • Alexander Varnin

    • status: open-later --> closed-fixed
     
  • Lonely Stranger

    Lonely Stranger - 2014-01-05
    • status: closed-fixed --> closed-wont-fix
     
  • Lonely Stranger

    Lonely Stranger - 2014-01-05

    Well, strictly said, it is not "Fixed". It is not implemented in PCManFM because it is not lightweight solution but implemented in your plugin, which you can use.

    BTW, you've got a memory leak in your code - data returned by fm_path_display_name() should be freed after usage. And also that function returns string not appropriate to use for anything but display, and to get a path string the fm_path_to_str() should be used instead.

     
  • Alexander Varnin

    Thank you. Fixed this too.

    Maybe this points should be better documented.
    You can place link to fm_path_to_str from fm_path_display_name description and add note about need of freeing memory after both of them with g_free.

     
  • Alexander Varnin

    • status: closed-wont-fix --> open-wont-fix
     
  • Lonely Stranger

    Lonely Stranger - 2014-01-06

    You are wrong. From description for fm_path_display_name() in HTML docs:

    Returns : path string. [transfer full]

    The [transfer full] means exactly - string is allocated and should be freed aftwards. :)
    And thanks, I'll revise that file for more clear documentation.
    Thank you very much.

     
  • Lonely Stranger

    Lonely Stranger - 2014-01-06
    • status: open-wont-fix --> closed-wont-fix
     
<< < 1 2 (Page 2 of 2)


Anonymous

Cancel  Add attachments