#186 Menu key to call context menu

closed
PCMan
None
4
2012-08-14
2011-01-21
nicodoggie
No

This patch is for the nitpicky people who want to keep away from the mouse when they browse files.

I modified the on_view_key_press_event in the main-win.c file to handle GDK_Menu for the main window. It calls on_file_clicked and passes FM_FV_CONTEXT_MENU as theFmFolderViewClickEventType, etc so I can reuse the context menu code.

In desktop.c, I added a GDK_Menu case in the on_key_press_event function as well, this one calls the popup_menu function.

I'm still sort of new to the GTK stuff, so it might not be the best way this should be done. Anyway, even if my code isn't really used, I hope you guys add this feature in future releases, it really isn't much, but it helps with useability for some people.

Thanks for the great program :D

Discussion

  • nicodoggie

    nicodoggie - 2011-01-21

    enables menu key

     
  • PCMan

    PCMan - 2011-06-11
    • status: open --> closed-accepted
     
  • PCMan

    PCMan - 2011-06-11

    Applied. Thanks a lot.

     
  • PCMan

    PCMan - 2011-06-11
    • assigned_to: nobody --> pcmanx
     
  • PCMan

    PCMan - 2011-06-11

    Applied. Thanks a lot.

     
  • PCMan

    PCMan - 2011-06-20
    • status: closed-accepted --> open-accepted
     
  • PCMan

    PCMan - 2011-06-20

    Reading gtk+ API doc, I found that the correct way to do this is to handle "popup-menu" signal of the widgets, not to handle raw key events.
    This needs to be done later.

     
  • PCMan

    PCMan - 2011-11-18
    • priority: 5 --> 4
    • milestone: --> 2334032
     
  • PCMan

    PCMan - 2011-11-18

    Version 1.0 is in feature freeze and string freeze now.
    Let's fix this later in 1.1.

     
  • Lonely Stranger

    Lonely Stranger - 2012-05-26
    • milestone: 2334032 -->
     
  • Lonely Stranger

    Lonely Stranger - 2012-08-14
    • milestone: --> 2297538
     
  • Lonely Stranger

    Lonely Stranger - 2012-08-14
    • milestone: 2297538 -->
     
  • Lonely Stranger

    Lonely Stranger - 2012-08-14
    • status: open-accepted --> closed
     
  • Lonely Stranger

    Lonely Stranger - 2012-08-14

    Sure thing, handling raw key events is too bad. And "popup-menu" is extra signal to handle so it's implemented even more simpler way in libfm which will be used by pcmanfm a bit later. Thank you everyone, issue is fixed.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks