PCmanFM crash while doing search in ftp folder, using regex for file contents.
Reproduction:
Got following stacktrace:
[New Thread 0xafc60b70 (LWP 4489)]
(pcmanfm:4433): DEBUG: reactivated gestures to page 1
(pcmanfm:4433): DEBUG: found matched: screenshot.png
(pcmanfm:4433): DEBUG: found matched: admin-meta-boxes.php
(pcmanfm:4433): DEBUG: found matched: options.php
(pcmanfm:4433): DEBUG: found matched: tools.php
(pcmanfm:4433): DEBUG: found matched: knockout.js
(pcmanfm:4433): DEBUG: found matched: admin-write.php
(pcmanfm:4433): DEBUG: found matched: admin.php
(pcmanfm:4433): DEBUG: found matched: seo.php
(pcmanfm:4433): DEBUG: found matched: layout.php
(pcmanfm:4433): DEBUG: found matched: compatibility-woocommerce.php
(pcmanfm:4433): DEBUG: found matched: woocommerce-design-elements.php
(pcmanfm:4433): DEBUG: found matched: woocommerce-design-defaults.php
(pcmanfm:4433): DEBUG: found matched: woocommerce-breadcrumbs.php
(pcmanfm:4433): DEBUG: found matched: Tumblr.png
(pcmanfm:4433): DEBUG: found matched: Flickr.png
** (pcmanfm:4433): DEBUG: found matched: Digg.png
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb0468b70 (LWP 4441)]
0xb6fa974c in ?? () from /lib/i386-linux-gnu/libpcre.so.3
gdb:
(gdb) bt full
No symbol table info available.
No symbol table info available.
No symbol table info available.
No symbol table info available.
No symbol table info available.
priv=0x82b71d0, info=<optimized out>) at vfs-search.c:662 line_len = 27 line = 0x8195b48 "\211\242\222H\247ZyWT+\212\222\250\374\342\356-[ܕ[\246\326\362\312\324J" ret = 0 input_stream = 0x838dd98
at vfs-search.c:774 file = <optimized out> stream = 0x8332a68 ret = 0
at vfs-search.c:874
No locals.
enu = 0x82b71d0 iter = <optimized out> file_info = 0x83ad068 err = 0x0 container = <optimized out>
No symbol table info available.
inf = <optimized out> err = 0x0 enu = 0x82b71d0 fi = <optimized out> fmjob = 0x829e5b0 gf = <optimized out> query = <optimized out>
ret = 0 job = 0x82b71d0
klass = <optimized out>
---Type <return> to continue, or q <return> to quit---
No symbol table info available.
No symbol table info available.
No symbol table info available.
No symbol table info available.
Thanks
Anonymous
Unfortunately I cannot reproduce your issue. Could you provide more detailed information to repruce it, please? Exact search pattern (from the address bar) would be perfect but I suspect it cannot be retrieved due to crash so at least exact ftp site, file name pattern and search pattern would be very helpful. Thank you very much.
Given the crash has somewhat higher priority, I really would like to get some information to reproduce it and fix. Thank you in advance.
Shouldn't the nullity of
GFileEnumerator *enumerator
be checked in the beginning of_fm_vfs_search_enumerator_next_file()
?Just for the record, using of
G_REGEX_RAW
fixes a very similar crash.g_regex_match()
should be fed by utf8 strings unlessG_REGEX_RAW
is used. Otherwise, a crash might happen.I think this issue is the same that was reported on Github and is fixed recently in GIT sources. Thank you very much.