- labels: --> libfm
- status: open --> closed-rejected
- assigned_to: Lonely Stranger
With pcmanfm 1.2.0 / libfm 1.2.0, when once executing $ pcmanfm --desktop-off , and then executing $ pcmanfm --desktop , it shows a warning like:
** (pcmanfm:28525): WARNING **: modules directory is not accessible
gdb says:
[tasaka1@localhost ~]$ gdb pcmanfm GNU gdb (GDB) Fedora 7.7-1.fc21 (gdb) break fm-module.c:383 No source file named fm-module.c. Make breakpoint pending on future shared library load? (y or [n]) y Breakpoint 1 (fm-module.c:383) pending. (gdb) r --desktop Starting program: /usr/bin/pcmanfm --desktop Breakpoint 1, _fm_modules_load (unused=0x0) at base/fm-module.c:383 383 g_warning("modules directory is not accessible"); (gdb) p dir_name $1 = 0x8142c68 "/usr/lib/pcmanfm" (gdb) n ** (pcmanfm:28525): WARNING **: modules directory is not accessible 449 if (dir_l)
So I guess this line of pcmanfm source code is the reason of this.
As pcmanfm now always refers to this directory, I think installing pcmanfm 1.2 should always create this directory, even if this is empty for now. I tried writing a trial patch for this as attached.
Well, if modules directory does not exist, that means installation is broken and the warning is reasonably right. Distribution of libfm (no GTK) includes 2 modules, and libfm-gtk adds 4 more to total 6 modules. They will be installed in any case therefore mentioned directory is already created, no extra hooks required.
If your package splits modules off and has them not in dependencies (which is also wrong because users will lose some functionality) then it should create an empty directory where modules are normally installed to supress the warning.
Thank you very much.
Distribution of libfm (no GTK) includes 2 modules, and libfm-gtk adds 4 more to total 6 modules
The directory you are speaking here is "$(libdir)/libfm/modules", not I am speaking here. I am speaking of the directory "$(libdir)/pcmanfm", see the link to pcmanfm source I posted, not the source of libfm.
Also see the gdb log I already posted, it says that "$(libdir)/pcmanfm" is missing, not "$(libdir)/libfm/modules".
Also see the "NEWS" of pcmanfm, not libfm, link here
The plugins should be installed into $(libdir)/pcmanfm folder and use "#include <pcmanfm-modules.h>" directive in the code.
Ah, I see, I'm sorry, I read this not enough closesy and misinterpreted. Thank you very much for clarifying and for the patch.
The changes are in GIT sources now. Thank you very much.
Anonymous