#689 Honour freedesktop escaping rules for Exec

1.1
closed-invalid
libfm (306)
5
2013-05-30
2012-12-13
memeplex
No

As described here:

http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s06.html

In particular, %% must escape % and not just ignore it as the current code does:

const char* p = strstr(cmdline, " %");
if(p)
{
if( !strchr("fFuU", *(p + 2)) )
p = NULL;
}

Discussion

  • memeplex

    memeplex - 2012-12-13

    AFAICS this applies to current trunk also.

     
  • Lonely Stranger

    Lonely Stranger - 2013-01-09
    • milestone: 3172103 --> 2334032
     
  • Lonely Stranger

    Lonely Stranger - 2013-05-30

    What is your problem with that? That mentioned code is just a test if command line entered by user has mention of argument, nothing more. It has nothing to do with desktop entry execution. The execution of the desktop entry fully honors the '%%' sequence.

     
  • Lonely Stranger

    Lonely Stranger - 2013-05-30
    • assigned_to: nobody --> lstranger
    • milestone: 2334032 --> 1.1
    • status: open --> closed-invalid
     

Anonymous
Anonymous

Cancel  Add attachments