#608 Applications menu issue with libfm/fm-file.

1.1
closed-fixed
libfm (303)
7
2012-09-21
2012-09-18
No

Latest libfm/fm-file and pcmanfm/1.0.2 from git.
When I clicked 'Applications' on the side pane only 'Run program' showed up.
I'm using Xfce now so I have desktop directories that start with xfce-xxxxx.directory or normal ones that are just xxxxx.directory (which I use with IceWM and is probably what pmanfm used to show).
With master branches of libfm/pcmanfm Applications tab work fine.

Then after it showed only one item I moved back to home folder and clicked back again in Applications item in side pane then menu-cache segfaulted.

http://pastebin.com/thDbbf5y

I'll try reproducing it again.

Discussion

  • Sérgio Cipolla

    Sérgio Cipolla - 2012-09-18

    Actually it has issues not only with Applications tab.
    I opened pcmanfm, then I clicked on the Desktop item in the side pane and it segfaulted.

    http://pastebin.com/rCVbafS8

     
  • Lonely Stranger

    Lonely Stranger - 2012-09-18

    I've changed menu-cache calling. Test it again, please. I hope it will not crash. Thank you!

     
  • Lonely Stranger

    Lonely Stranger - 2012-09-18
    • labels: --> libfm
    • priority: 5 --> 7
    • assigned_to: nobody --> lstranger
     
  • Sérgio Cipolla

    Sérgio Cipolla - 2012-09-18

    Hi, I didn't test the Applications bookmark (side pane) but clicking on other bookmarked folder on the side pane segfaulted with the same error I posted before (with the Desktop folder).
    If you want I open a different bug report for that.

     
  • Lonely Stranger

    Lonely Stranger - 2012-09-19

    Thank you very much. No needs in another report. I think it's some memory issue. I'll run it under valgrind massively and I hope I can catch it.

     
  • Lonely Stranger

    Lonely Stranger - 2012-09-20

    Ran it under valgrind, tried to open folders/windows/tabs/bookmarks, context menu, do cut/paste, drag&drop - could not find any memory problems and no crashes happened as well. :(
    Unfortunately Applications menu wasn't shown under valgrind - it seems menu-cache has some problems with starting it's daemon under valgrind as well as it's library crashes in Xfce. I'll try to start it in Xfce session then and if it is not the menu-cache problem then I'll fix it.

    If you still can reproduce the crash with latest libfm/fm-file and pcmanfm/1.0.2 code then I would like to have your help with inspecting the coredump. Better would be to do it in IRC if you can come there. Thank you very much!

     
  • Sérgio Cipolla

    Sérgio Cipolla - 2012-09-20

    It still crashes when clicking on a bookmark on the side pane.

    $ gdb pcmanfm
    GNU gdb (GDB) Fedora (7.4.50.20120120-50.fc17)
    Copyright (C) 2012 Free Software Foundation, Inc.
    License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
    This is free software: you are free to change and redistribute it.
    There is NO WARRANTY, to the extent permitted by law. Type "show copying"
    and "show warranty" for details.
    This GDB was configured as "i686-redhat-linux-gnu".
    For bug reporting instructions, please see:
    <http://www.gnu.org/software/gdb/bugs/>...
    Reading symbols from /usr/bin/pcmanfm...done.
    (gdb) run
    Starting program: /usr/bin/pcmanfm
    [Thread debugging using libthread_db enabled]
    Using host libthread_db library "/lib/libthread_db.so.1".
    [New Thread 0xb231cb40 (LWP 18786)]
    [New Thread 0xb19ffb40 (LWP 18787)]
    [Thread 0xb19ffb40 (LWP 18787) exited]
    [New Thread 0xb19ffb40 (LWP 18788)]
    [Thread 0xb19ffb40 (LWP 18788) exited]
    [New Thread 0xb19ffb40 (LWP 18789)]

    Program received signal SIGSEGV, Segmentation fault.
    [Switching to Thread 0xb19ffb40 (LWP 18789)]
    0x081dd497 in ?? ()
    (gdb) bt
    #0 0x081dd497 in ?? ()
    #1 0xb72663ce in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:133
    (gdb) q

    Which IRC channel, please?

     
  • Sérgio Cipolla

    Sérgio Cipolla - 2012-09-20

    Now you said about Xfce, I'll try it in IceWM to see if it makes any difference.

     
  • Lonely Stranger

    Lonely Stranger - 2012-09-20

    IRC channel is #lxde on irc.oftc.net.

     
  • Lonely Stranger

    Lonely Stranger - 2012-09-20

    It depends on XDG_MENU_PREFIX variable so can be tested without actual Xfce start. I've pushed fix into git. Thank you very much!

    And about that crash I have no idea right now how to solve the problem :(

     
  • Lonely Stranger

    Lonely Stranger - 2012-09-20

    The crash was due to new GLib 2.32 API. I hope I've workarounded the crash. Test it thoroughly, please.
    Thank you very much.

     
  • Sérgio Cipolla

    Sérgio Cipolla - 2012-09-20

    Ok, I'll do.
    I just compiled libfm/pcmanfm from master branch but later I'll go back to fm-file branch and test.

    Did you notice some configure errors? http://pastebin.com/xyQuNkmK

     
  • Sérgio Cipolla

    Sérgio Cipolla - 2012-09-20

    Warnings, I mean. (fm-file, before your latest commit)

     
  • Lonely Stranger

    Lonely Stranger - 2012-09-20

    Yes, I've seen those. They are harmless but anyway I've fixed that few moments ago. Thank you.

     
  • Lonely Stranger

    Lonely Stranger - 2012-09-21
    • status: open --> closed-fixed
     
  • Lonely Stranger

    Lonely Stranger - 2012-09-21

    All the changes are in master git branch. I hope all issues are fixed. If there is something wrong still then reopen the ticket, please. Thank you very much.

     


Anonymous

Cancel  Add attachments