PCMan File Manager / Bugs / #1085 Some keyboard shortcuts stopped working: Alt+Home, Alt+Up

Michael Weghorn - 2018-12-27

I have also encountered this. The attached patch fixes the issue for me and I'd be happy if it could be merged.

0001-SF-1085-Avoid-undefined-isdigit-behaviour.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Mamoru TASAKA - 2019-01-09

Well,

I cannot reproduce this issue on Fedora

My colleague using Arch linux also is unable to reproduce this issue

On the other hand, on Fedora some people are reporting this issue

And the above people (i.e. bug reporters on Fedora) say the above patch does NOT work.

So this should be related to some environment settings (I guess). Hard to debug because I cannot reproduce...

Last edit: Mamoru TASAKA 2019-01-09
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

riveravaldez - 2019-01-09

Hi, Mamoru

If you could give me instructions on what to do/test with environment settings (I think I don't know nothing about that) I could try it and report.

Let me know if there's any other thing I could do to help.

Best regards!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous - 2019-01-09

I've encountered the issue on Debian testing and there's another Debian user reporting the same issue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917522

I can also reproduce with PCManFM built directly from git (not only with the Debian package). Interestingly, the patch does actually fix the issue for me. In my personal opinion avoiding undefined behaviour seems to be a good in any case...

Any chance you could possibly try on Debian? Or is there anything else I can do to help?
Would it help if I try to reproduce on Fedora and analyse the issue there?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Michael Weghorn - 2019-01-09

Just to clarify: The last comment was mine (i.e. from the person that attached the patch). Sorry, I forgot to log in before posting...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.
- Mamoru TASAKA - 2019-01-09
  
  Well, for me the previous comment is shown as "Post awaiting moderation", and I have not received it via email yet. So it may be preferable that you would repost your message.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Anonymous
    
    Add attachments
    Cancel
    You seem to have CSS turned off. Please don't fill out this field.
    
    You seem to have CSS turned off. Please don't fill out this field.
  - Anonymous - 2019-01-09
    
    OK, it was like (exact words may differ, since I can't see the comment myself anymore):
    
    I encountered the bug on Debian testing and there's also a report by another Debian user at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917522 .
    
    Is there any chance you could possibly try on Debian? Or is there anything else I can do to help? Would it help if I try to reproduce and analyse the issue on Fedora?
    
    On Debian testing, I can reproduce the issue also with a build directly from git master (not just with the version packaged by Debian). The patch fixes the issue for me. In any case, it seems a good idea to me to avoid undefined behaviour. Interestingly it works in Debian stable, and the changed behaviour might be due to the "undefined behaviour" having changed with the update of some underlying library (e.g. glibc...).
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    
    Anonymous
    
    Add attachments
    Cancel
    You seem to have CSS turned off. Please don't fill out this field.
    
    You seem to have CSS turned off. Please don't fill out this field.
  - Michael Weghorn - 2019-01-09
    
    Let me try again (can't see the exact message myself anymore, and forgot once again to login...):
    
    I myself encountered the issue on Debian testing, and another Debian user has reported the same issue at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917522 .
    
    Is there any chance you could possibly try on Debian testing? Or is there anything else I can do to help? Would it help if I try to reproduce and analyse the issue on Fedora as well?
    
    In any case, it seems a good idea to me to avoid undefined behaviour. Interestingly, it works on Debian stable, and I think the issue in Debian testing might be that the "undefined behaviour" has changed e.g. due to some change in underlying libraries (e.g. glibc,...).
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    
    Anonymous
    
    Add attachments
    Cancel
    You seem to have CSS turned off. Please don't fill out this field.
    
    You seem to have CSS turned off. Please don't fill out this field.

Mamoru TASAKA - 2019-01-09

Well, actually now I can reproduce this issue with LANG=zh_TW.utf8 LC_ALL=zh_TW.utf8 or LANG=en_US.utf8 LC_ALL=en_US.utf8 , however this issue is not reproducible with LANG=ja_JP.utf8 LC_ALL=ja_JP.utf8 . Now I will try debugging (but it may take long time...)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.
- Mamoru TASAKA - 2019-01-09
  
  ... And actually, with LANG=zh_TW.utf8 or with LANG=en_US.utf8 ,
  
  Actually when pressing "Alt+Home" or "Alt+Up", evt->keyval is recognized as "isdigit()", while with ja_JP.utf8 the judgment isdigit() fail (so it works with ja_JP.utf8)
  
  And the patch from Michael does work - i.e. with the patch, with LANG=zh_TW.utf8 or with LANG=en_US.utf8, "Alt+Home" or "Alt+Up" come to work.
  
  So from me +1 for merging the patch anyway.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Anonymous
    
    Add attachments
    Cancel
    You seem to have CSS turned off. Please don't fill out this field.
    
    You seem to have CSS turned off. Please don't fill out this field.

Lonely Stranger - 2019-01-09

Thank you for reporting this and for the patch. Pushed it into GIT repository, it will appear in next release. Sorry for being so late on this.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Lonely Stranger - 2019-01-09

labels: keyboard, debian, arch, shortcuts --> keyboard, debian, arch, shortcuts, pcmanfm

status: open --> pending-fixed

assigned_to: Lonely Stranger

Priority: 5 --> 6
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Michael Weghorn - 2019-01-09

Thank you for looking into this and for merging the patch!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

bugzilla97 - 2019-02-13

Both shortcuts remain unresponsive for me. I tried it with LANG=en_US.utf8 too.

My versions are the same as riveravaldez, except for:
Linux 4.19.0-2-686-pae #1 SMP Debian 4.19.16-1 (2019-01-17) i686 GNU/Linux
en_GB.UTF-8

I hope I am doing something wrong, but I have tried not to. (unpack tarball; configure; patch (checked); make; src/pcmanfm)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous - 2019-04-10

What git repository are you using, I did not find this fix at git://pcmanfm.git.sourceforge.net/gitroot/pcmanfm/pcmanfm master branch?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous - 2019-05-08

I downgraded to the last two prior versions of PCManFM for Debian today and the issue was present in both prior versions, so maybe another package or system change is affecting the PCManFM keyboard shortcuts.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Den Drix - 2020-10-12

I still experience this bug on ArchLinux with community/pcmanfm 1.3.1-2 (that's the GTK2 version):

LANG=en_IE.UTF-8

Finnish/Swedish keyboard layout (AFAIU they are the same)

kernel 5.4.70-1-lts x86_64

Symptoms:

If I don't change anything, I can use Alt-LeftArrow and Alt-RightArrow, but NOT Alt-Home or Alt-UpArrow

If I change LANG to e.g. en_US.utf8, or unset it, I can use Alt-Home, but still not Alt-UpArrow.

I have applied the patch manually to the latest tarball and /usr/local-installed that version - now everything works as desired, i.e. I do not have to change locale or LANG to use Alt-Home, Alt-UpArrow.

I would appreciate if this patch could be incorporated into the release.

BTW, is it possible to clone the git repo directly?

❤️
1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous - 2021-03-17

Post awaiting moderation.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Some keyboard shortcuts stopped working: Alt+Home, Alt+Up

Group

Searches

Help

#1085 Some keyboard shortcuts stopped working: Alt+Home, Alt+Up

Discussion