From: stephan b. <st...@s1...> - 2004-12-28 23:08:53
|
Yo! Marc just committed his Prefs and Variant (another name for LexT) code, and i've got it compiling under p2 and in the makefiles. i have one concern: you guys know i hate circular deps on the modules. i'm a build maintainer, by nature, and circular deps eventually cause a tree to break down. Look at Qt: you can't use a single part without using all the rest. Try creating a QPixmap without creating a QApp. Doesn't work. So now i come to the IO/Util dependencies... PrefsStore throws an IOException when load() or update() fail. This introduces a dependency on IO::IOError. What i would propose is: - Remove the exception. - Change return type to bool. - Never throw from those functions. Good points: - One less dep. - Simplified client usage. - This is the only place in the API which relies on IO::, so the rest of the interface is unaffected. Bad point: - Inconsistent with other i/o API in the lib. However, i feel that this object is "high level" enough that a simple bool would do the trick. ??? -- ----- st...@s1... http://s11n.net "...pleasure is a grace and is not obedient to the commands of the will." -- Alan W. Watts |