From: Christian P. <cp...@se...> - 2004-12-27 19:24:43
|
Hi ! No .. you should change the SharedLib.generic.cpp to SharedLib.common.cpp, cause all SharedLib implementations may use the common code. z.B. CriticalSection.win32.cpp is win32 impl of criticalsection CriticalSection.generic.cpp is a generic criticalsection impl that uses a Mutex and works on all Systems (when they dont support CriticalSections). Code in FileInfo.common.cpp is common to all FileInfo platform dependant code. Is the difference clear to you ? Greetings, Christian Am Montag 27 Dezember 2004 18:27 schrieb stephan beal: > Yo! > > U src/System/FileInfo.common.cpp > > Could i convince you to rename that to FileInfo.generic.cpp? The reason > is this: all the other code follows this convention. As we change the > build process to be cross-platform-friendly, it will be easier if we > can look up files based on, e.g., Foo.$(LIBPSYSTEM_PLATFORM).cpp. > > Consistent patterns are critical to any automation :). |